Restrict libp2p_ping::handler::Failure::Other with Sync?
              
              #5040
            
            
              
  
  Closed
              
          
                  
                    
                      drHuangMHT
                    
                  
                
                  started this conversation in
                Ideas
              
            Replies: 1 comment
-
| 
         Yes that makes sense. I am wondering if this is a breaking change? I don't think it is so because we are adding a trait bound, not removing one.  | 
  
Beta Was this translation helpful? Give feedback.
                  
                    0 replies
                  
                
            
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
        
    
Uh oh!
There was an error while loading. Please reload this page.
-
Othervariant holds value of this type:rust-libp2p/protocols/ping/src/handler.rs
Lines 97 to 99 in 4260702
Which is not
Sync, thus cannot be shared between threads, preventing it from being broadcast to subscribers.Should we add
Syncbound to it?Beta Was this translation helpful? Give feedback.
All reactions