-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Closed
Labels
difficulty:easygetting-startedIssues that can be tackled if you don't know the internals of libp2p very wellIssues that can be tackled if you don't know the internals of libp2p very wellhelp wantedpriority:nicetohave
Description
Description
Currently, libp2p-kad
has several public modules like handler
that don't need to be public. This makes it much more likely that a change is breaking in practice despite likely being irrelevant to users. See #3504 for an example.
Implementation suggestion
We want to ship this as a non-breaking change, thus we should adopt a similar approach as done in #3238 where we first deprecate these modules with a note that they will be made private.
Are you planning to do it yourself in a pull request?
No.
mxinden
Metadata
Metadata
Assignees
Labels
difficulty:easygetting-startedIssues that can be tackled if you don't know the internals of libp2p very wellIssues that can be tackled if you don't know the internals of libp2p very wellhelp wantedpriority:nicetohave