feat(request-response): add Behaviour::send_request_with_addresses()
#5938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
force-pushed
the
send-request-with-addresses
branch
from
b8775c8 to
5e033bf
Compare
nazar-pc
changed the title
Behavior::send_request_with_addresses()Behaviour::send_request_with_addresses()
nazar-pc
force-pushed
the
send-request-with-addresses
branch
from
5e033bf to
6dc22b1
Compare
elenaf9
reviewed
Mar 26, 2025
Member
|
Friendly ping @nazar-pc: there are still two small docs nits open, then I think we can merge this. |
Co-authored-by: Elena Frank <[email protected]>
Contributor
Author
|
Applied suggestions, CI is happy now too |
4 tasks
lla-dane
pushed a commit
to lla-dane/rust-libp2p
that referenced
this pull request
Apr 17, 2025
This is agreed alternative to libp2p#5692, which resolves libp2p#5634 Pull-Request: libp2p#5938.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is agreed alternative to #5692, which resolves #5634
Notes & open questions
#5692 was open for a long time, and it was requested that I add an additional method that simply takes addresses as an extra parameter, so this is exactly what I did here.
Change checklist