feat(quic): make send window configurable#6280
Open
orlandohohmeier wants to merge 1 commit intolibp2p:masterfrom
Open
feat(quic): make send window configurable#6280orlandohohmeier wants to merge 1 commit intolibp2p:masterfrom
orlandohohmeier wants to merge 1 commit intolibp2p:masterfrom
Conversation
Add Config::max_connection_send_data to override Quinn's connection-level send window independently from max_connection_data. This enables tuning for high BDP to improve throughput, while preserving Quinn's default TransportConfig::send_window when unset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
Config::max_connection_send_datato override Quinn's connection-level send window independently from max_connection_data.This enables tuning for high BDP to improve throughput, while preserving Quinn's default
TransportConfig::send_windowwhen unset.Notes & open questions
We've originally made this change for https://github.com/hypha-space/hypha to improve cross continental cloud-to-cloud links as defaulted to
max_connection_datain casemax_connection_send_dataisn't set in line with what the docs say but for backward compatibility I've change this such that we fallback to Quinn's defaults. In line with that I've adjusted the docs.Change checklist
Add Config::max_connection_send_data to override Quinn's connection-level send window independently from max_connection_data.
This enables tuning for high BDP to improve throughput, while preserving Quinn's default TransportConfig::send_window when unset.