250813.074146.CST fortran/tests/makefiles/Makefile.common: add -Wl,-z,noexecstack to the compiler options, to test that our code does not need executable stacks

Author: zaikunzhang

fortran/tests/makefiles/Makefile.common

@@ -24,6 +24,13 @@
 # empty, then we will test both an optimized version (compiled with -O3) and a debugging version
 # (compiled with -g -O0); otherwise, a version indicated by FFLAGS will be tested.
 #
+# 4. `-Wl,-z,noexecstack` passes the `-z noexecstack` option to the linker and tells the linker to
+# set the "stack is not executable" attribute in the output file. If executable stacks are actually
+# needed, then it will lead to a runtime error. This is to test that our code does not require executable
+# stacks, which is a security risk. COBYLA used to use an internal subroutine passed as an actual
+# argument, which necessitates an executable stack with some compilers, but such code has been
+# removed on 20250812. See git commit 5e5e871 and
+# https://fortran-lang.discourse.group/t/implementation-of-a-parametrized-objective-function-without-using-module-variables-or-internal-subroutines
 # Coded by Zaikun ZHANG (www.zhangzk.net).
 #
 # Started: September 2021
@@ -361,6 +368,7 @@ ifeq ($(TESTDIM),small)
 endif
 # Strangely, with `-Mchkptr`, the compiler may not print the error message of `-Mbounds` anymore.
 DFORT := $(AFLANG) -std=f$(FSTD) -pedantic -Weverything -Wall -Wextra -Minform=warn -Mstandard -Mbounds -Mrecursive #-Kieee #-Mchkptr
+DFORT := $(DFORT) -Wl,-z,noexecstack
 
 dtest_i2_r4_d1_tst_c dtest_i4_r4_d1_tst_c dtest_i8_r4_d1_tst_c dtest_i2_r4_d0_tst_c dtest_i4_r4_d0_tst_c dtest_i8_r4_d0_tst_c: \
 	FCO := $(DFORT) $(FFLAGSO)
@@ -397,6 +405,7 @@ else
 	FFORT := $(FFORT) -fno-stack-arrays -mmlir -fdynamic-heap-array
 endif
 FFORT := $(FFORT) -std=f2018 -pedantic  # As of flang 19.0, only -std=f2018 is supported
+FFORT := $(FFORT) -Wl,-z,noexecstack
 
 ftest_i2_r4_d1_tst_c ftest_i4_r4_d1_tst_c ftest_i8_r4_d1_tst_c ftest_i2_r4_d0_tst_c ftest_i4_r4_d0_tst_c ftest_i8_r4_d0_tst_c: \
 	FCO := $(FFORT) $(FFLAGSO)
@@ -468,6 +477,7 @@ GFORT := $(GFORT) $(GFSTD) -fall-intrinsics -frecursive \
 	-ftrapv
 	#-finit-real=nan -finit-integer=-9999999  # This will hide some warnings on uninitialized variables.
 	#-Wrealloc-lhs -Wrealloc-lhs-all
+GFORT := $(GFORT) -Wl,-z,noexecstack
 
 gtest_i2_r4_d1_tst_c gtest_i4_r4_d1_tst_c gtest_i8_r4_d1_tst_c gtest_i2_r4_d0_tst_c gtest_i4_r4_d0_tst_c gtest_i8_r4_d0_tst_c: \
 	FCO := $(GFORT) $(FFLAGSO) -Wno-function-elimination -ffpe-trap=zero
@@ -514,6 +524,7 @@ else
 	IFORT := $(IFORT) -auto -heap-arrays
 endif
 IFORT := $(IFORT) -standard-semantics -assume recursion -fimplicit-none
+IFORT := $(IFORT) -Wl,-z,noexecstack
 
 itest_i2_r4_d1_tst_c itest_i4_r4_d1_tst_c itest_i8_r4_d1_tst_c itest_i2_r4_d0_tst_c itest_i4_r4_d0_tst_c itest_i8_r4_d0_tst_c: \
 	FCO := $(IFORT) $(FFLAGSO) -fp-trap=divzero
@@ -549,6 +560,7 @@ NFORT := $(NFORT) -I $(TESTSUITE_DIR)
 NFORT := $(NFORT) -colour=error:red,warn:magenta,info:cyan
 NFORT := $(NFORT) -f$(FSTD) -recursive -info -gline -u -C -C=alias -C=dangling -C=intovf -C=undefined -kind=unique \
 	-Warn=constant_coindexing -Warn=subnormal #-Warn=allocation
+NFORT := $(NFORT) -Wl,-z,noexecstack
 
 ntest_i2_r4_d1_tst_c ntest_i4_r4_d1_tst_c ntest_i8_r4_d1_tst_c ntest_i2_r4_d0_tst_c ntest_i4_r4_d0_tst_c ntest_i8_r4_d0_tst_c: \
 	FCO := $(NFORT) $(FFLAGSO) -nan -ieee=full
@@ -582,6 +594,7 @@ else
 	VFORT := $(VFORT) -Mnostack_arrays
 endif
 VFORT := $(VFORT) -C -Wall -Wextra -Minform=warn -Mstandard -Mrecursive -Mbounds -Mchkstk -Mchkptr -traceback
+VFORT := $(VFORT) -Wl,-z,noexecstack
 
 vtest_i2_r4_d1_tst_c vtest_i4_r4_d1_tst_c vtest_i8_r4_d1_tst_c vtest_i2_r4_d0_tst_c vtest_i4_r4_d0_tst_c vtest_i8_r4_d0_tst_c: \
 	FCO := $(VFORT) $(FFLAGSO) #-Ktrap=divz #-Kieee
@@ -614,6 +627,7 @@ else
 	RFORT := $(RFORT) -fno-stack-arrays
 endif
 RFORT := $(RFORT) -std=f$(FSTD) -pedantic -Weverything -Wall -Wextra -Minform=warn -Mstandard -Mrecursive -Mbounds -Mchkptr #-Kieee
+RFORT := $(RFORT) -Wl,-z,noexecstack
 
 rtest_i2_r4_d1_tst_c rtest_i4_r4_d1_tst_c rtest_i8_r4_d1_tst_c rtest_i2_r4_d0_tst_c rtest_i4_r4_d0_tst_c rtest_i8_r4_d0_tst_c: \
 	FCO := $(RFORT) $(FFLAGSO)
@@ -643,6 +657,7 @@ ifeq ($(TESTDIM),small)
 	SFORT := $(SFORT) -stackvar  # Force all automatic arrays to be on the stack to test whether stack overflow can occur
 endif
 SFORT := $(SFORT) -w3 -u -U -ansi -xcheck=%all -C
+SFORT := $(SFORT) -Wl,-z,noexecstack
 
 stest_i2_r4_d1_tst_c stest_i4_r4_d1_tst_c stest_i8_r4_d1_tst_c stest_i2_r4_d0_tst_c stest_i4_r4_d0_tst_c stest_i8_r4_d0_tst_c: \
 	FCO := $(SFORT) $(FFLAGSO) -fnonstd -ftrap=division
@@ -682,6 +697,7 @@ else
 	XFORT := $(XFORT) -auto -heap-arrays
 endif
 XFORT := $(XFORT) -standard-semantics -assume recursion -fimplicit-none
+XFORT := $(XFORT) -Wl,-z,noexecstack
 
 # In the following, `-check all,nouninit` can be changed to `-check all` later, probably with OneAPI 2024.1. See
 # https://community.intel.com/t5/Intel-Fortran-Compiler/ifx-missing-clang-rt-msan-to-link-Fortran-program-in-debug-build/m-p/1533430
@@ -723,6 +739,7 @@ xtest_i2_r16_d1_tst_c xtest_i4_r16_d1_tst_c xtest_i8_r16_d1_tst_c xtest_i2_r16_d
 	-Werror=100,113,115,137,146,147,159,163 \
 	-Wimplicit-none -Wline-truncation -Wprecision-loss -Wunused-module-vars -Wunused-vars -Wunset-vars \
 	-fimplicit-none -fbounds-check -ftrace=full -freal=nan -fmodule-private
+9FORT := $(9FORT) -Wl,-z,noexecstack
 
 9test_i2_r4_d1_tst_c 9test_i4_r4_d1_tst_c 9test_i8_r4_d1_tst_c 9test_i2_r4_d0_tst_c 9test_i4_r4_d0_tst_c 9test_i8_r4_d0_tst_c: \
 	FCO := $(9FORT) $(FFLAGSO)