250812.173457.CST remove the internal subroutine calcfc_internal from cobylb.f90; as of 20250812, internal subroutines passed as actual arguments implies executable stacks for current compilers; executable stacks are not allowed by glibc 2.4+; see https://fortran-lang.discourse.group/t/implementation-of-a-parametrized-objective-function-without-using-module-variables-or-internal-subroutines, JuliaLang/julia#57250, https://forums.gentoo.org/viewtopic-p-8866168.html

Author: zaikunzhang

.development

@@ -17,7 +17,7 @@ module cobylb_mod
 !
 ! Started: July 2021
 !
-! Last Modified: Thursday, April 04, 2024 AM11:23:03
+! Last Modified: Tue 12 Aug 2025 04:58:06 PM CST
 !--------------------------------------------------------------------------------------------------!
 
 implicit none
@@ -202,8 +202,8 @@ subroutine cobylb(calcfc, iprint, maxfilt, maxfun, amat, bvec, ctol, cweight, et
 ! function value (regardless of the constraint violation), and SIM(:, 1:N) holds the displacements
 ! from the other vertices to SIM(:, N+1). FVAL, CONMAT, and CVAL hold the function values,
 ! constraint values, and constraint violations on the vertices in the order corresponding to SIM.
-call initxfc(calcfc_internal, iprint, maxfun, constr, ctol, f, ftarget, rhobeg, x, nf, chist, conhist, &
-   & conmat, cval, fhist, fval, sim, simi, xhist, evaluated, subinfo)
+call initxfc(calcfc, iprint, maxfun, amat, bvec, constr, ctol, f, ftarget, rhobeg, x, nf, chist, &
+    & conhist, conmat, cval, fhist, fval, sim, simi, xhist, evaluated, subinfo)
 
 ! Report the current best value, and check if user asks for early termination.
 terminate = .false.
@@ -393,7 +393,8 @@ subroutine cobylb(calcfc, iprint, maxfilt, maxfun, amat, bvec, ctol, cweight, et
             cstrv = cval(j)
         else
             ! Evaluate the objective and constraints at X, taking care of possible Inf/NaN values.
-            call evaluate(calcfc_internal, x, f, constr)
+            constr(1:m_lcon) = matprod(x, amat) - bvec
+            call evaluate(calcfc, x, f, constr(m_lcon + 1:m))
             cstrv = maximum([ZERO, constr])
             nf = nf + 1_IK
             ! Save X, F, CONSTR, CSTRV into the history.
@@ -585,7 +586,8 @@ subroutine cobylb(calcfc, iprint, maxfilt, maxfun, amat, bvec, ctol, cweight, et
             cstrv = cval(j)
         else
             ! Evaluate the objective and constraints at X, taking care of possible Inf/NaN values.
-            call evaluate(calcfc_internal, x, f, constr)
+            constr(1:m_lcon) = matprod(x, amat) - bvec
+            call evaluate(calcfc, x, f, constr(m_lcon + 1:m))
             cstrv = maximum([ZERO, constr])
             nf = nf + 1_IK
             ! Save X, F, CONSTR, CSTRV into the history.
@@ -650,7 +652,8 @@ subroutine cobylb(calcfc, iprint, maxfilt, maxfun, amat, bvec, ctol, cweight, et
 ! Ensure that D has not been updated after SHORTD == TRUE occurred, or the code below is incorrect.
 x = sim(:, n + 1) + d
 if (info == SMALL_TR_RADIUS .and. shortd .and. norm(x - sim(:, n + 1)) > 1.0E-3_RP * rhoend .and. nf < maxfun) then
-    call evaluate(calcfc_internal, x, f, constr)
+    constr(1:m_lcon) = matprod(x, amat) - bvec
+    call evaluate(calcfc, x, f, constr(m_lcon + 1:m))
     cstrv = maximum([ZERO, constr])
     nf = nf + 1_IK
     ! Save X, F, CONSTR, CSTRV into the history.
@@ -702,25 +705,6 @@ subroutine cobylb(calcfc, iprint, maxfilt, maxfun, amat, bvec, ctol, cweight, et
         & 'No point in the history is better than X', srname)
 end if
 
-
-contains
-
-
-subroutine calcfc_internal(x_internal, f_internal, constr_internal)
-!--------------------------------------------------------------------------------------------------!
-! This internal subroutine evaluates the objective function and ALL the constraints.
-! In MATLAB/Python/R/Julia, this can be implemented as a lambda function / anonymous function.
-!--------------------------------------------------------------------------------------------------!b
-implicit none
-! Inputs
-real(RP), intent(in) :: x_internal(:)
-! Outputs
-real(RP), intent(out) :: f_internal
-real(RP), intent(out) :: constr_internal(:)
-constr_internal(1:m_lcon) = matprod(x_internal, amat) - bvec
-call calcfc(x_internal, f_internal, constr_internal(m_lcon + 1:m))
-end subroutine calcfc_internal
-
 end subroutine cobylb
 
 

fortran/cobyla/cobylb.f90

@@ -8,7 +8,7 @@ module initialize_cobyla_mod
 !
 ! Started: July 2021
 !
-! Last Modified: Saturday, March 16, 2024 PM04:48:11
+! Last Modified: Tue 12 Aug 2025 04:57:48 PM CST
 !--------------------------------------------------------------------------------------------------!
 
 implicit none
@@ -19,8 +19,8 @@ module initialize_cobyla_mod
 contains
 
 
-subroutine initxfc(calcfc, iprint, maxfun, constr0, ctol, f0, ftarget, rhobeg, x0, nf, chist, &
-    & conhist, conmat, cval, fhist, fval, sim, simi, xhist, evaluated, info)
+subroutine initxfc(calcfc, iprint, maxfun, amat, bvec, constr0, ctol, f0, ftarget, rhobeg, x0, nf, &
+    & chist, conhist, conmat, cval, fhist, fval, sim, simi, xhist, evaluated, info)
 !--------------------------------------------------------------------------------------------------!
 ! This subroutine does the initialization concerning X, function values, and constraints.
 !--------------------------------------------------------------------------------------------------!
@@ -33,7 +33,7 @@ subroutine initxfc(calcfc, iprint, maxfun, constr0, ctol, f0, ftarget, rhobeg, x
 use, non_intrinsic :: history_mod, only : savehist
 use, non_intrinsic :: infnan_mod, only : is_nan, is_posinf, is_finite
 use, non_intrinsic :: infos_mod, only : INFO_DFT
-use, non_intrinsic :: linalg_mod, only : eye, inv, isinv, maximum
+use, non_intrinsic :: linalg_mod, only : eye, inv, isinv, maximum, matprod
 use, non_intrinsic :: message_mod, only : fmsg
 use, non_intrinsic :: pintrf_mod, only : OBJCON
 
@@ -43,6 +43,8 @@ subroutine initxfc(calcfc, iprint, maxfun, constr0, ctol, f0, ftarget, rhobeg, x
 procedure(OBJCON) :: calcfc ! N.B.: INTENT cannot be specified if a dummy procedure is not a POINTER
 integer(IK), intent(in) :: iprint
 integer(IK), intent(in) :: maxfun
+real(RP), intent(in) :: amat(:, :) ! AMAT(N, M_LCON)
+real(RP), intent(in) :: bvec(:) ! BVEC(M_LCON)
 real(RP), intent(in) :: constr0(:)  ! CONSTR0(M)
 real(RP), intent(in) :: ctol
 real(RP), intent(in) :: f0
@@ -70,6 +72,7 @@ subroutine initxfc(calcfc, iprint, maxfun, constr0, ctol, f0, ftarget, rhobeg, x
 integer(IK) :: j
 integer(IK) :: k
 integer(IK) :: m
+integer(IK) :: m_lcon
 integer(IK) :: maxchist
 integer(IK) :: maxconhist
 integer(IK) :: maxfhist
@@ -84,6 +87,7 @@ subroutine initxfc(calcfc, iprint, maxfun, constr0, ctol, f0, ftarget, rhobeg, x
 real(RP), parameter :: itol = TENTH
 
 ! Sizes
+m_lcon = int(size(bvec), kind(m_lcon))
 m = int(size(conmat, 1), kind(m))
 n = int(size(sim, 1), kind(n))
 maxchist = int(size(chist), kind(maxchist))
@@ -97,6 +101,7 @@ subroutine initxfc(calcfc, iprint, maxfun, constr0, ctol, f0, ftarget, rhobeg, x
     call assert(m >= 0, 'M >= 0', srname)
     call assert(n >= 1, 'N >= 1', srname)
     call assert(abs(iprint) <= 3, 'IPRINT is 0, 1, -1, 2, -2, 3, or -3', srname)
+    call assert(size(amat, 1) == n .and. size(amat, 2) == size(bvec), 'SIZE(AMAT) == [N, SIZE(BVEC)]', srname)
     call assert(size(conmat, 1) == m .and. size(conmat, 2) == n + 1, 'SIZE(CONMAT) = [M, N+1]', srname)
     call assert(size(cval) == n + 1, 'SIZE(CVAL) == N+1', srname)
     call assert(size(fval) == n + 1, 'SIZE(FVAL) == N+1', srname)
@@ -156,7 +161,8 @@ subroutine initxfc(calcfc, iprint, maxfun, constr0, ctol, f0, ftarget, rhobeg, x
     else
         j = k - 1_IK
         x(j) = x(j) + rhobeg
-        call evaluate(calcfc, x, f, constr)
+        constr(1:m_lcon) = matprod(x, amat) - bvec
+        call evaluate(calcfc, x, f, constr(m_lcon + 1:m))
     end if
     cstrv = maximum([ZERO, constr])
 

fortran/cobyla/initialize.f90

@@ -8,7 +8,7 @@ module initialize_newuoa_mod
 !
 ! Dedicated to the late Professor M. J. D. Powell FRS (1936--2015).
 !
-! Last Modified: Saturday, March 16, 2024 PM02:13:43
+! Last Modified: Tue 12 Aug 2025 04:48:20 PM CST
 !--------------------------------------------------------------------------------------------------!
 
 implicit none
@@ -134,7 +134,7 @@ subroutine initxf(calfun, iprint, maxfun, ftarget, rhobeg, x0, ij, kopt, nf, fhi
 ! Initialize XHIST, FHIST, and FVAL. Otherwise, compilers may complain that they are not
 ! (completely) initialized if the initialization aborts due to abnormality (see CHECKEXIT).
 ! N.B.: 1. Initializing them to NaN would be more reasonable (NaN is not available in Fortran).
-! 2. Do not initialize the models if the current initialization aborts due to abnormality. Otherwise, 
+! 2. Do not initialize the models if the current initialization aborts due to abnormality. Otherwise,
 ! errors or exceptions may occur, as FVAL and XPT etc are uninitialized.
 xhist = -REALMAX
 fhist = REALMAX