250812.212651.CST matlab: update set_compiler_options and restore_compiler_options

Author: zaikunzhang

matlab/tests/private/get_solvers.m

@@ -99,7 +99,10 @@
 try
 
     if with_compiler_options
-        set_compiler_options(options.compiler_options);
+        sco_success = set_compiler_options(options.compiler_options);
+        if ~sco_success
+            warning('Failed to set compiler options!!!');
+        end
     end
 
     for is = 1 : length(solvers)
@@ -155,8 +158,11 @@
 end
 
 % Restore the compiler options.
-if with_compiler_options
-    restore_compiler_options();
+if with_compiler_options && sco_success
+    rco_success = restore_compiler_options();
+    if ~rco_success
+        warning('Failed to restore compiler options!!!');
+    end
 end
 % Go back to the old directory.
 cd(olddir);

matlab/tests/private/iswritable.m

@@ -0,0 +1,11 @@
+function iw = iswritable(fdname)
+%ISWRITABLE returns true or false to indicate whether the file or directory is writable.
+[status, attributes] = fileattrib(fdname);
+
+iw = false;
+if status == 1
+    iw = attributes.UserWrite;
+else
+    errid = 'IsWritable:FDNotExists';
+    error(errid, 'IsWritable:Error checking the attribute of %s. The file or directory does not exist', fdname);
+end

matlab/tests/private/restore_compiler_options.m

@@ -1,12 +1,19 @@
-function restore_compiler_options()
+function success = restore_compiler_options()
 %Restore the compiler options by restoring the mexopts files. It is hacky!!!
 
 if ~isunix || ismac
     error('Configuration of compiler options supports only Linux.')
 end
 
+success = false;
+
 config_dir = fullfile(matlabroot,'bin', 'glnxa64', 'mexopts');
 config_files = {dir(fullfile(config_dir, 'gfortran*.xml')).name};
+fileattrib(config_dir, '+w');
+if ~iswritable(config_dir)
+    warning('The directory %s is not writable. Compile options not restored.', config_dir);
+    return;
+end
 for ifile = 1 : length(config_files)
     cfile = fullfile(config_dir, config_files{ifile});
     cfile_orig = fullfile(config_dir, [config_files{ifile}, '.orig']);
@@ -38,10 +45,17 @@ function restore_compiler_options()
 mex_setup_file = fullfile(prefdir, ['mex_FORTRAN_', computer('arch'), '.xml']);
 if exist(mex_setup_file, 'file')
     fileattrib(prefdir, '+w');
+    if ~iswritable(prefdir)
+        warning('The directory %s is not writable. The restored compile options may not take effect.', prefdir);
+    end
     fileattrib(mex_setup_file, '+w');
+    if ~iswritable(mex_setup_file)
+        warning('The file %s is not writable. The restored compile options may not take effect.', mex_setup_file);
+    end
     delete(mex_setup_file);
 end
 
 fprintf('\nCompiler options restored successfully.\n\n');
+success = true;
 
 return

matlab/tests/private/set_compiler_options.m

@@ -1,19 +1,29 @@
-function set_compiler_options(compiler_options)
+function success = set_compiler_options(compiler_options)
 %Configure the compiler options by editing the mexopts files. It is hacky!!!
 
 if ~isunix || ismac
     error('Configuration of compiler options supports only Linux.')
 end
 
+success = false;
+
 mfilepath = fileparts(mfilename('fullpath')); % The directory containing this setup script
 
 % Modify mexopts files in `config_dir` after making backups.
 config_dir = fullfile(matlabroot, 'bin', 'glnxa64', 'mexopts');
 config_files = {dir(fullfile(config_dir, 'gfortran*.xml')).name};
 fileattrib(config_dir, '+w');
+if ~iswritable(config_dir)
+    warning('The directory %s is not writable. Compile options not set.', config_dir);
+    return;
+end
 for ifile = 1 : length(config_files)
     cfile = fullfile(config_dir, config_files{ifile});
     fileattrib(cfile, '+w')
+    if ~iswritable(cfile)
+        warning('The file %s is not writable. Compile options not set.', cfile);
+        return;
+    end
 
     cfile_orig = fullfile(config_dir, [config_files{ifile}, '.orig']);
     if ~exist(cfile_orig, 'file')
@@ -41,15 +51,22 @@ function set_compiler_options(compiler_options)
 % We delete it so that MEX will be reconfigured according to `config_files`.
 % Why not making a backup for it? Because the existing version may be generated using the modified
 % `config_files` when this script was called the last time (N.B.: `mex_setup_file` does not exist
-% in a fresh installation of MATLAB), in which case it would be wrong to store % this copy and
+% in a fresh installation of MATLAB), in which case it would be wrong to store this copy and
 % restore `mex_setup_file` using it.
 mex_setup_file = fullfile(prefdir, ['mex_FORTRAN_', computer('arch'), '.xml']);
 if exist(mex_setup_file, 'file')
     fileattrib(prefdir, '+w');
+    if ~iswritable(prefdir)
+        warning('The directory %s is not writable. The modified compile options may not take effect.', prefdir);
+    end
     fileattrib(mex_setup_file, '+w');
+    if ~iswritable(mex_setup_file)
+        warning('The file %s is not writable. The modified compile options may not take effect.', mex_setup_file);
+    end
     delete(mex_setup_file);
 end
 
 fprintf('\nCompiler options set to \n\n%s\n\n', compiler_options);
+success = true;
 
 return