250814.073928.CST [skip ci] add a comment about OUTPROD

zaikunzhang · zaikunzhang · commit f2d0687ac4c1 · 2025-08-14T07:39:28.000+08:00
diff --git a/fortran/bobyqa/rescue.f90 b/fortran/bobyqa/rescue.f90
@@ -18,7 +18,7 @@ module rescue_mod
 !
 ! Started: February 2022
 !
-! Last Modified: Thursday, March 14, 2024 PM01:18:04
+! Last Modified: Thu 14 Aug 2025 07:34:53 AM CST
 !--------------------------------------------------------------------------------------------------!
 
 implicit none
@@ -769,6 +769,7 @@ subroutine updateh_rsc(knew, beta, vlag_in, bmat, zmat, info)
 v1 = (alpha * vlag(npt + 1:npt + n) - tau * hcol(npt + 1:npt + n)) / denom
 v2 = (-beta * hcol(npt + 1:npt + n) - tau * vlag(npt + 1:npt + n)) / denom
 bmat = bmat + outprod(v1, vlag) + outprod(v2, hcol) !call r2update(bmat, ONE, v1, vlag, ONE, v2, hcol)
+! N.B.: The use of OUTPROD is expensive memory-wise, but it is not our concern in this implementation.
 ! Numerically, the update above does not guarantee BMAT(:, NPT+1 : NPT+N) to be symmetric.
 call symmetrize(bmat(:, npt + 1:npt + n))
 
diff --git a/fortran/bobyqa/update.f90 b/fortran/bobyqa/update.f90
@@ -8,7 +8,7 @@ module update_bobyqa_mod
 !
 ! Started: February 2022
 !
-! Last Modified: Friday, March 15, 2024 PM12:15:35
+! Last Modified: Thu 14 Aug 2025 07:34:12 AM CST
 !--------------------------------------------------------------------------------------------------!
 
 implicit none
@@ -146,6 +146,7 @@ subroutine updateh(knew, kopt, d, xpt, bmat, zmat, info)
 v1 = (alpha * vlag(npt + 1:npt + n) - tau * hcol(npt + 1:npt + n)) / denom
 v2 = (-beta * hcol(npt + 1:npt + n) - tau * vlag(npt + 1:npt + n)) / denom
 bmat = bmat + outprod(v1, vlag) + outprod(v2, hcol) !call r2update(bmat, ONE, v1, vlag, ONE, v2, hcol)
+! N.B.: The use of OUTPROD is expensive memory-wise, but it is not our concern in this implementation.
 ! Numerically, the update above does not guarantee BMAT(:, NPT+1 : NPT+N) to be symmetric.
 call symmetrize(bmat(:, npt + 1:npt + n))
 
diff --git a/fortran/cobyla/update.f90 b/fortran/cobyla/update.f90
@@ -8,7 +8,7 @@ module update_cobyla_mod
 !
 ! Started: July 2021
 !
-! Last Modified: Monday, August 07, 2023 AM03:53:59
+! Last Modified: Thu 14 Aug 2025 07:34:04 AM CST
 !--------------------------------------------------------------------------------------------------!
 
 implicit none
@@ -104,6 +104,7 @@ subroutine updatexfc(jdrop, constr, cpen, cstrv, d, f, conmat, cval, fval, sim,
 
 sim_old = sim
 simi_old = simi
+! N.B.: The use of OUTPROD is expensive memory-wise, but it is not our concern in this implementation.
 if (jdrop <= n) then
     sim(:, jdrop) = d
     simi_jdrop = simi(jdrop, :) / inprod(simi(jdrop, :), d)
diff --git a/fortran/common/linalg.f90 b/fortran/common/linalg.f90
@@ -39,7 +39,7 @@ module linalg_mod
 !
 ! Started: July 2020
 !
-! Last Modified: Sunday, April 21, 2024 PM03:49:40
+! Last Modified: Thu 14 Aug 2025 07:36:47 AM CST
 !--------------------------------------------------------------------------------------------------!
 
 implicit none
@@ -222,6 +222,7 @@ subroutine r1(A, alpha, x, y)
 ! Calculation starts !
 !====================!
 
+! N.B.: The use of OUTPROD is expensive memory-wise, but it is not our concern in this implementation.
 A = A + outprod(alpha * x, y)
 !A = A + alpha * outprod(x, y)
 
@@ -318,6 +319,7 @@ subroutine r2(A, alpha, x, y, beta, u, v)
 ! Calculation starts !
 !====================!
 
+! N.B.: The use of OUTPROD is expensive memory-wise, but it is not our concern in this implementation.
 A = A + outprod(alpha * x, y) + outprod(beta * u, v)
 !A = A + (alpha * outprod(x, y) + beta * outprod(u, v))
 
diff --git a/fortran/common/powalg.f90 b/fortran/common/powalg.f90
@@ -21,7 +21,7 @@ module powalg_mod
 !
 ! Started: July 2020
 !
-! Last Modified: Wed 06 Aug 2025 06:54:55 AM CST
+! Last Modified: Thu 14 Aug 2025 07:36:04 AM CST
 !--------------------------------------------------------------------------------------------------!
 
 implicit none
@@ -1250,6 +1250,7 @@ subroutine updateh(knew, kref, d, xpt, idz, bmat, zmat, info)
 v1 = (alpha * vlag(npt + 1:npt + n) - tau * hcol(npt + 1:npt + n)) / denom
 v2 = (-beta * hcol(npt + 1:npt + n) - tau * vlag(npt + 1:npt + n)) / denom
 bmat = bmat + outprod(v1, vlag) + outprod(v2, hcol) !call r2update(bmat, ONE, v1, vlag, ONE, v2, hcol)
+! N.B.: The use of OUTPROD is expensive memory-wise, but it is not our concern in this implementation.
 ! Numerically, the update above does not guarantee BMAT(:, NPT+1 : NPT+N) to be symmetric.
 call symmetrize(bmat(:, npt + 1:npt + n))
 
diff --git a/fortran/common/shiftbase.f90 b/fortran/common/shiftbase.f90
@@ -9,7 +9,7 @@ module shiftbase_mod
 !
 ! Started: July 2020
 !
-! Last Modified: Thursday, April 11, 2024 AM10:57:22
+! Last Modified: Thu 14 Aug 2025 07:35:47 AM CST
 !--------------------------------------------------------------------------------------------------!
 
 implicit none
diff --git a/fortran/uobyqa/update.f90 b/fortran/uobyqa/update.f90
@@ -8,7 +8,7 @@ module update_uobyqa_mod
 !
 ! Started: July 2020
 !
-! Last Modified: Thursday, April 11, 2024 PM06:37:06
+! Last Modified: Thu 14 Aug 2025 07:37:19 AM CST
 !--------------------------------------------------------------------------------------------------!
 
 implicit none
@@ -85,6 +85,7 @@ subroutine update(knew, d, f, moderr, kopt, fval, pl, pq, xpt)
 pl(:, knew) = pl(:, knew) / vlag(knew)
 plnew = pl(:, knew)
 pl = pl - outprod(plnew, vlag)
+! N.B.: The use of OUTPROD is expensive memory-wise, but it is not our concern in this implementation.
 pl(:, knew) = plnew
 
 ! Update the quadratic model.

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ module rescue_mod`
`18`	`18`	`!`
`19`	`19`	`! Started: February 2022`
`20`	`20`	`!`
`21`		`-! Last Modified: Thursday, March 14, 2024 PM01:18:04`
	`21`	`+! Last Modified: Thu 14 Aug 2025 07:34:53 AM CST`
`22`	`22`	`!--------------------------------------------------------------------------------------------------!`
`23`	`23`
`24`	`24`	`implicit none`
`@@ -769,6 +769,7 @@ subroutine updateh_rsc(knew, beta, vlag_in, bmat, zmat, info)`
`769`	`769`	`v1 = (alpha * vlag(npt + 1:npt + n) - tau * hcol(npt + 1:npt + n)) / denom`
`770`	`770`	`v2 = (-beta * hcol(npt + 1:npt + n) - tau * vlag(npt + 1:npt + n)) / denom`
`771`	`771`	`bmat = bmat + outprod(v1, vlag) + outprod(v2, hcol) !call r2update(bmat, ONE, v1, vlag, ONE, v2, hcol)`
	`772`	`+! N.B.: The use of OUTPROD is expensive memory-wise, but it is not our concern in this implementation.`
`772`	`773`	`! Numerically, the update above does not guarantee BMAT(:, NPT+1 : NPT+N) to be symmetric.`
`773`	`774`	`call symmetrize(bmat(:, npt + 1:npt + n))`
`774`	`775`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ module update_bobyqa_mod`
`8`	`8`	`!`
`9`	`9`	`! Started: February 2022`
`10`	`10`	`!`
`11`		`-! Last Modified: Friday, March 15, 2024 PM12:15:35`
	`11`	`+! Last Modified: Thu 14 Aug 2025 07:34:12 AM CST`
`12`	`12`	`!--------------------------------------------------------------------------------------------------!`
`13`	`13`
`14`	`14`	`implicit none`
`@@ -146,6 +146,7 @@ subroutine updateh(knew, kopt, d, xpt, bmat, zmat, info)`
`146`	`146`	`v1 = (alpha * vlag(npt + 1:npt + n) - tau * hcol(npt + 1:npt + n)) / denom`
`147`	`147`	`v2 = (-beta * hcol(npt + 1:npt + n) - tau * vlag(npt + 1:npt + n)) / denom`
`148`	`148`	`bmat = bmat + outprod(v1, vlag) + outprod(v2, hcol) !call r2update(bmat, ONE, v1, vlag, ONE, v2, hcol)`
	`149`	`+! N.B.: The use of OUTPROD is expensive memory-wise, but it is not our concern in this implementation.`
`149`	`150`	`! Numerically, the update above does not guarantee BMAT(:, NPT+1 : NPT+N) to be symmetric.`
`150`	`151`	`call symmetrize(bmat(:, npt + 1:npt + n))`
`151`	`152`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ module update_cobyla_mod`
`8`	`8`	`!`
`9`	`9`	`! Started: July 2021`
`10`	`10`	`!`
`11`		`-! Last Modified: Monday, August 07, 2023 AM03:53:59`
	`11`	`+! Last Modified: Thu 14 Aug 2025 07:34:04 AM CST`
`12`	`12`	`!--------------------------------------------------------------------------------------------------!`
`13`	`13`
`14`	`14`	`implicit none`
`@@ -104,6 +104,7 @@ subroutine updatexfc(jdrop, constr, cpen, cstrv, d, f, conmat, cval, fval, sim,`
`104`	`104`
`105`	`105`	`sim_old = sim`
`106`	`106`	`simi_old = simi`
	`107`	`+! N.B.: The use of OUTPROD is expensive memory-wise, but it is not our concern in this implementation.`
`107`	`108`	`if (jdrop <= n) then`
`108`	`109`	`sim(:, jdrop) = d`
`109`	`110`	`simi_jdrop = simi(jdrop, :) / inprod(simi(jdrop, :), d)`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ module powalg_mod`
`21`	`21`	`!`
`22`	`22`	`! Started: July 2020`
`23`	`23`	`!`
`24`		`-! Last Modified: Wed 06 Aug 2025 06:54:55 AM CST`
	`24`	`+! Last Modified: Thu 14 Aug 2025 07:36:04 AM CST`
`25`	`25`	`!--------------------------------------------------------------------------------------------------!`
`26`	`26`
`27`	`27`	`implicit none`
`@@ -1250,6 +1250,7 @@ subroutine updateh(knew, kref, d, xpt, idz, bmat, zmat, info)`
`1250`	`1250`	`v1 = (alpha * vlag(npt + 1:npt + n) - tau * hcol(npt + 1:npt + n)) / denom`
`1251`	`1251`	`v2 = (-beta * hcol(npt + 1:npt + n) - tau * vlag(npt + 1:npt + n)) / denom`
`1252`	`1252`	`bmat = bmat + outprod(v1, vlag) + outprod(v2, hcol) !call r2update(bmat, ONE, v1, vlag, ONE, v2, hcol)`
	`1253`	`+! N.B.: The use of OUTPROD is expensive memory-wise, but it is not our concern in this implementation.`
`1253`	`1254`	`! Numerically, the update above does not guarantee BMAT(:, NPT+1 : NPT+N) to be symmetric.`
`1254`	`1255`	`call symmetrize(bmat(:, npt + 1:npt + n))`
`1255`	`1256`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ module shiftbase_mod`
`9`	`9`	`!`
`10`	`10`	`! Started: July 2020`
`11`	`11`	`!`
`12`		`-! Last Modified: Thursday, April 11, 2024 AM10:57:22`
	`12`	`+! Last Modified: Thu 14 Aug 2025 07:35:47 AM CST`
`13`	`13`	`!--------------------------------------------------------------------------------------------------!`
`14`	`14`
`15`	`15`	`implicit none`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ module update_uobyqa_mod`
`8`	`8`	`!`
`9`	`9`	`! Started: July 2020`
`10`	`10`	`!`
`11`		`-! Last Modified: Thursday, April 11, 2024 PM06:37:06`
	`11`	`+! Last Modified: Thu 14 Aug 2025 07:37:19 AM CST`
`12`	`12`	`!--------------------------------------------------------------------------------------------------!`
`13`	`13`
`14`	`14`	`implicit none`
`@@ -85,6 +85,7 @@ subroutine update(knew, d, f, moderr, kopt, fval, pl, pq, xpt)`
`85`	`85`	`pl(:, knew) = pl(:, knew) / vlag(knew)`
`86`	`86`	`plnew = pl(:, knew)`
`87`	`87`	`pl = pl - outprod(plnew, vlag)`
	`88`	`+! N.B.: The use of OUTPROD is expensive memory-wise, but it is not our concern in this implementation.`
`88`	`89`	`pl(:, knew) = plnew`
`89`	`90`
`90`	`91`	`! Update the quadratic model.`