Skip to content

Commit 5575e15

Browse files
committed
refactor: Simplify CMake dependencies and fix clang-tidy warnings
Streamlined CMakeLists.txt files to avoid redundant transitive dependencies, and resolved remaining clang-tidy warnings for struct initialization and unused return values to improve CI code quality checks.
1 parent 59305a2 commit 5575e15

File tree

9 files changed

+8
-24
lines changed

9 files changed

+8
-24
lines changed

src/CMakeLists.txt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,7 @@ add_executable(mygramdb main.cpp)
2626

2727
target_link_libraries(mygramdb PRIVATE
2828
mygramdb_config
29-
mygramdb_index
30-
mygramdb_storage
3129
mygramdb_server
32-
mygramdb_utils
33-
mygramdb_query
34-
spdlog::spdlog
35-
Threads::Threads
3630
)
3731

3832
# Link MySQL library if available

src/cli/mygram-cli.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,7 @@ class MygramClient {
331331
continue;
332332
}
333333

334-
struct sockaddr_in server_addr{};
334+
struct sockaddr_in server_addr = {};
335335
server_addr.sin_family = AF_INET;
336336
server_addr.sin_port = htons(config_.port);
337337

src/client/mygramclient.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,14 +147,14 @@ class MygramClient::Impl {
147147
}
148148

149149
// Set socket timeout
150-
struct timeval timeout_val{};
150+
struct timeval timeout_val = {};
151151
timeout_val.tv_sec = static_cast<decltype(timeout_val.tv_sec)>(config_.timeout_ms / 1000);
152152
timeout_val.tv_usec =
153153
static_cast<decltype(timeout_val.tv_usec)>((config_.timeout_ms % 1000) * 1000);
154154
setsockopt(sock_, SOL_SOCKET, SO_RCVTIMEO, &timeout_val, sizeof(timeout_val));
155155
setsockopt(sock_, SOL_SOCKET, SO_SNDTIMEO, &timeout_val, sizeof(timeout_val));
156156

157-
struct sockaddr_in server_addr{};
157+
struct sockaddr_in server_addr = {};
158158
server_addr.sin_family = AF_INET;
159159
server_addr.sin_port = htons(config_.port);
160160

src/server/CMakeLists.txt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,6 @@ target_include_directories(mygramdb_server PUBLIC
1111

1212
target_link_libraries(mygramdb_server PUBLIC
1313
mygramdb_query
14-
mygramdb_index
15-
mygramdb_storage
16-
mygramdb_utils
17-
spdlog::spdlog
1814
httplib::httplib
1915
nlohmann_json::nlohmann_json
2016
Threads::Threads

src/server/tcp_server.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ bool TcpServer::Start() {
8282
}
8383

8484
// Bind
85-
struct sockaddr_in address{};
85+
struct sockaddr_in address = {};
8686
std::memset(&address, 0, sizeof(address));
8787
address.sin_family = AF_INET;
8888
address.sin_addr.s_addr = INADDR_ANY;
@@ -169,7 +169,7 @@ void TcpServer::AcceptThreadFunc() {
169169
spdlog::info("Accept thread started");
170170

171171
while (!should_stop_) {
172-
struct sockaddr_in client_addr{};
172+
struct sockaddr_in client_addr = {};
173173
socklen_t client_len = sizeof(client_addr);
174174

175175
int client_fd =
@@ -824,7 +824,7 @@ std::string TcpServer::ProcessRequest(const std::string& request, ConnectionCont
824824

825825
// Load from directory
826826
// Check if directory exists
827-
struct stat file_stat{};
827+
struct stat file_stat = {};
828828
if (stat(filepath.c_str(), &file_stat) != 0 || !S_ISDIR(file_stat.st_mode)) {
829829
loading_ = false;
830830
return FormatError("Snapshot directory not found: " + filepath);

tests/client/CMakeLists.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ target_link_libraries(mygramclient_test
88
mygramclient_static
99
mygramdb_server
1010
mygramdb_mysql
11-
mygramdb_index
12-
mygramdb_storage
1311
GTest::gtest_main
1412
)
1513

tests/query/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ add_executable(result_sorter_test
3232

3333
target_link_libraries(result_sorter_test
3434
mygramdb_query
35-
mygramdb_storage
3635
GTest::gtest_main
3736
)
3837

tests/storage/CMakeLists.txt

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,8 @@ if(USE_MYSQL AND MYSQL_FOUND)
5454
)
5555

5656
target_link_libraries(snapshot_save_load_test
57-
mygramdb_storage
58-
mygramdb_index
59-
mygramdb_mysql
6057
mygramdb_query
61-
mygramdb_utils
58+
mygramdb_mysql
6259
mygramdb_config
6360
)
6461
endif()

tests/storage/document_store_concurrent_test.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ TEST(DocumentStoreConcurrentTest, ConcurrentLoadAndRead) {
122122
// Thread that loads from file
123123
threads.emplace_back([&store2, &test_file, &load_done]() {
124124
std::this_thread::sleep_for(std::chrono::milliseconds(10));
125-
store2.LoadFromFile(test_file + ".docs");
125+
[[maybe_unused]] auto result = store2.LoadFromFile(test_file + ".docs");
126126
load_done = true;
127127
});
128128

0 commit comments

Comments
 (0)