Skip to content

Commit bab033e

Browse files
authored
Merge pull request #2 from bigdrum/delete-temp-file
2 parents e55ecdb + 82dd48b commit bab033e

File tree

1 file changed

+25
-2
lines changed

1 file changed

+25
-2
lines changed

api/request.go

Lines changed: 25 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,18 +37,41 @@ func RequestHandler(c *gin.Context) {
3737

3838
tempFilename += "-" + form.Name
3939

40-
inFile, _ := os.CreateTemp(depot.WorkDir, tempFilename)
40+
inFile, err := os.CreateTemp(depot.WorkDir, tempFilename)
41+
if err != nil {
42+
log.Println("Create temp file failed", err)
43+
c.String(http.StatusInternalServerError, "unknown error")
44+
return
45+
}
4146
filePath := inFile.Name()
47+
defer func() {
48+
err := os.Remove(filePath)
49+
if err != nil {
50+
log.Println("Delege temp file failed", err)
51+
}
52+
}()
4253

4354
// Save file to working directory
4455
err = c.SaveUploadedFile(form.File, filePath)
4556
if err != nil {
57+
log.Println("Convert failed", err)
4658
c.String(http.StatusInternalServerError, "unknown error")
4759
return
4860
}
4961

5062
// Prepare output file path
51-
outFile, _ := os.CreateTemp(depot.WorkDir, tempFilename+"."+form.ConvertTo)
63+
outFile, err := os.CreateTemp(depot.WorkDir, tempFilename+"."+form.ConvertTo)
64+
if err != nil {
65+
log.Println("Create temp file failed", err)
66+
c.String(http.StatusInternalServerError, "unknown error")
67+
return
68+
}
69+
defer func() {
70+
err := os.Remove(outFile.Name())
71+
if err != nil {
72+
log.Println("Delege temp file failed", err)
73+
}
74+
}()
5275

5376
// Run unoconvert command with options
5477
// If context timeout is 0s run without timeout

0 commit comments

Comments
 (0)