Skip to content

Commit bcab321

Browse files
committed
Fixed bug that could cause Connection to use HTTP instead of HTTPS on servers that support both; Updated to latest gradle, android studio, etc; Bumped version to 1.2.3
1 parent 65e0c4c commit bcab321

File tree

7 files changed

+16
-9
lines changed

7 files changed

+16
-9
lines changed

Speedtest-Android/.idea/compiler.xml

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Speedtest-Android/.idea/gradle.xml

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Speedtest-Android/.idea/misc.xml

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Speedtest-Android/app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ android {
77
applicationId "your.name.here.speedtest"
88
minSdkVersion 15
99
targetSdkVersion 28
10-
versionCode 8
11-
versionName '1.2.2'
10+
versionCode 9
11+
versionName '1.2.3'
1212
testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
1313
}
1414
buildTypes {

Speedtest-Android/app/src/main/java/com/fdossena/speedtest/core/base/Connection.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public class Connection {
2121
private int mode=MODE_NOT_SET;
2222
private static final int MODE_NOT_SET=0, MODE_HTTP=1, MODE_HTTPS=2;
2323

24-
private static final String USER_AGENT="Speedtest-Android/1.2 (SDK "+Build.VERSION.SDK_INT+"; "+Build.PRODUCT+"; Android "+Build.VERSION.RELEASE+")",
24+
private static final String USER_AGENT="Speedtest-Android/1.2.3 (SDK "+Build.VERSION.SDK_INT+"; "+Build.PRODUCT+"; Android "+Build.VERSION.RELEASE+")",
2525
LOCALE= Build.VERSION.SDK_INT>=21?Locale.getDefault().toLanguageTag():null;
2626

2727
public Connection(String url, int connectTimeout, int soTimeout, int recvBuffer, int sendBuffer){
@@ -59,7 +59,7 @@ public Connection(String url, int connectTimeout, int soTimeout, int recvBuffer,
5959
throw new IllegalArgumentException("Malformed URL (Unknown or unspecified protocol)");
6060
}
6161
try{
62-
if(tryHTTPS){
62+
if(mode == MODE_NOT_SET && tryHTTPS){
6363
SocketFactory factory = SSLSocketFactory.getDefault();
6464
socket=factory.createSocket();
6565
if(connectTimeout>0){
@@ -71,7 +71,7 @@ public Connection(String url, int connectTimeout, int soTimeout, int recvBuffer,
7171
}
7272
}catch(Throwable t){}
7373
try{
74-
if(tryHTTP){
74+
if(mode == MODE_NOT_SET && tryHTTP){
7575
SocketFactory factory = SocketFactory.getDefault();
7676
socket=factory.createSocket();
7777
if(connectTimeout>0) {

Speedtest-Android/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ buildscript {
77

88
}
99
dependencies {
10-
classpath 'com.android.tools.build:gradle:4.0.1'
10+
classpath 'com.android.tools.build:gradle:4.1.3'
1111

1212
// NOTE: Do not place your application dependencies here; they belong
1313
// in the individual module build.gradle files
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
#Sun Sep 27 20:23:36 CEST 2020
1+
#Mon Apr 12 15:03:57 CEST 2021
22
distributionBase=GRADLE_USER_HOME
33
distributionPath=wrapper/dists
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists
6-
distributionUrl=https\://services.gradle.org/distributions/gradle-6.1.1-all.zip
6+
distributionUrl=https\://services.gradle.org/distributions/gradle-6.5-bin.zip

0 commit comments

Comments
 (0)