My fork fails to build after merging #1524

[michaelherger]

Thanks @lemon-sh, @roderickvd et al. for working so hard to get librespot working again! It's highly appreciated.

I have a fork of librespot (https://github.com/michaelherger/librespot/tree/spotty-0.6-dev) which currently fails to even compile with PR #1524 merged:

   Compiling librespot-core v0.6.0-dev (/Users/mh/SynologyDrive/git/librespot/core)
error[E0277]: the trait bound `Uri: From<U>` is not satisfied
   --> core/src/spclient.rs:766:14
    |
766 |             .uri(cdn_url)
    |              ^^^ the trait `From<U>` is not implemented for `Uri`
    |
    = note: required for `U` to implement `Into<Uri>`
    = note: required for `Uri` to implement `TryFrom<U>`
help: consider introducing a `where` clause, but there might be an alternative better way to express this requirement
    |
109 | impl SpClient where Uri: From<U> {
    |               ++++++++++++++++++

For more information about this error, try `rustc --explain E0277`.
error: could not compile `librespot-core` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

What is puzzling me is that none of the changes in that PR touch any file I modified on my end. My changes are relatively simple, disabling (using defaults) some options from the command line, adding an option to play a single track. There used to be a lot more which I've started to remove.

As I didn't touch the above file I'm wonder what could cause the compilation error. Pure, naked librespot would compile ok. Would you have any hint?

[photovoltex]

So in particular I don't know what it could be, but we had something similar here #1503. Besides that, did you already clean your artifacts once so that there are no leftovers which might be broken?

[michaelherger]

I saw that. But as my code is not calling this, I would have expected it to just work, as the caller would have been updated upstream. The closest I probably get is calling player.load(track, true, start_position);. How would that cause a compile time error?

[photovoltex]

Do you have any additional dependencies to then the ones librespot uses by defaylt? They might cause a conflict and by that result in issue perhaps.

[michaelherger]

Yes, I added serde_json at the top level. According to @lemon-sh my code seems to build ok by now (see #1533 (reply in thread)). I don't get it...

[photovoltex]

Well then you can close the discussion as solved, right?

[michaelherger]

Indeed: I double checked with a clean checkout, removing my workaround, and it builds as expected. Whatever that was. Maybe one of your most recent changes magically fixed it.

[urknall]

from my limited knowledge i can only guess:

            let req = Request::builder()
                .method(Method::POST)
                .uri(base_url.to_string())

A string is not of a type that can be converted into a Uri?
You need to ensure that this is of a type that can be turned into a Uri.
You cannot pass a String or &str directly into .uri(...) unless it's wrapped properly.
Convert it to a Uri using Uri::from_str or something like that and do error handling

[urknall]

maybe something like this, i bet you can do better:

let uri = match Uri::from_str(base_url) {
Ok(u) => u,
Err(e) => {
warn!("Invalid base URL '{}': {}", base_url, e);
return;
}
};

let req = Request::builder()
.method(Method::POST)
.uri(uri)

[michaelherger]

I'm a bit confused as I have no clue where such code would currently be living or should be applied?

[urknall]

ups sorry michael, for the confusion!!! i was in an old branch not 0.6-dev

[urknall]

sorry again michael, i was in the wrong branch, but i hope i pointed you in the right direction...

[lemon-sh]

@michaelherger could you push the version of the code you're trying to compile somewhere so I could take a look?

I cloned your repo, merged with librespot@dev (which has the PR merged), fixed merge conflicts and it compiles fine for me.

lemon@cytryna ~\coding\librespot-mich :3 cargo run                                                                                                                                                                        
   Compiling spotty v1.9.96 (C:\Users\lemon\coding\librespot-mich)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.66s
warning: the following packages contain code that will be rejected by a future version of Rust: bytemuck v1.23.2, windows-sys v0.59.0
note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 3`
     Running `target\debug\spotty.exe`
[2025-08-13T15:54:45Z INFO  spotty] spotty v1.9.96 - using librespot 0.6.0-dev 120eead (Built on 2025-08-13, Build ID: KFJN0CIU, Profile: debug)
[2025-08-13T15:54:45Z INFO  librespot_playback::mixer::softmixer] Mixing with softvol and volume control: Linear
[2025-08-13T15:54:45Z INFO  librespot_playback::audio_backend::pipe] Using StdoutSink (pipe) with format: S16

[michaelherger]

just pushed the latest https://github.com/michaelherger/librespot/tree/spotty-0.6-dev

As you can see in https://github.com/michaelherger/librespot/blob/spotty-0.6-dev/core/src/spclient.rs#L764-L787 I've feature flagged some of the code. If you remove the customisation around those lines you'll get the failure. It's my workaround for now until I've figured out what's wrong. But I'd prefer to stick with standard librespot code, rather than my hacks...

[lemon-sh]

I pulled your code, replaced stream_from_cdn with current librespot dev version and it builds fine for me. Weird.

[michaelherger]

Hmm... thanks for testing! I'll have to double check. In the mean time I had reverted more differences without re-validating the above. I was simply happy to have things working again... I'll check in a bit.

[michaelherger]

Is building as expected again after merging more of yesterday's changes. Thanks @roderickvd & @lemon-sh!