ios: coreaudio microphone shutdown fix

Author: warmenhoven

audio/audio_driver.c

@@ -2163,9 +2163,6 @@ static void mic_driver_microphone_handle_init(retro_microphone_t *microphone,
       unsigned microphone_sample_rate   = settings->uints.microphone_sample_rate;
       microphone->microphone_context    = NULL;
       microphone->flags                 = MICROPHONE_FLAG_ACTIVE;
-      microphone->sample_buffer         = NULL;
-      microphone->sample_buffer_length  = 0;
-
       microphone->requested_params.rate = params ? params->rate : microphone_sample_rate;
       microphone->actual_params.rate    = 0;
       /* We don't set the actual parameters until we actually open the mic.
@@ -2195,13 +2192,6 @@ static void mic_driver_microphone_handle_free(retro_microphone_t *microphone, bo
       microphone->microphone_context = NULL;
    }
 
-   if (microphone->sample_buffer)
-   {
-      memalign_free(microphone->sample_buffer);
-      microphone->sample_buffer = NULL;
-      microphone->sample_buffer_length = 0;
-   }
-
    if (microphone->outgoing_samples)
    {
       fifo_free(microphone->outgoing_samples);
@@ -2236,6 +2226,9 @@ bool microphone_driver_init_internal(void *settings_data)
    if (!settings->bools.microphone_enable)
    {
       mic_st->flags &= ~MICROPHONE_DRIVER_FLAG_ACTIVE;
+      /* Ensure microphone struct is clean to prevent crashes on deinit
+       * if there was stale data from a previous session */
+      memset(&mic_st->microphone, 0, sizeof(mic_st->microphone));
       return false;
    }
 
@@ -2329,13 +2322,6 @@ static bool mic_driver_open_mic_internal(retro_microphone_t* microphone)
    if (!microphone || !mic_driver || !(mic_st->flags & MICROPHONE_DRIVER_FLAG_ACTIVE))
       return false;
 
-   microphone->sample_buffer_length = max_samples * sizeof(int16_t);
-   microphone->sample_buffer        =
-         (int16_t*)memalign_alloc(64, microphone->sample_buffer_length);
-
-   if (!microphone->sample_buffer)
-      goto error;
-
    microphone->outgoing_samples = fifo_new(max_samples * sizeof(int16_t));
    if (!microphone->outgoing_samples)
       goto error;

audio/drivers/coreaudio_mic_ios.m

@@ -358,7 +358,9 @@ static void coreaudio_microphone_set_format(coreaudio_microphone_t *microphone,
          AudioComponentInstanceDispose(microphone->audio_unit);
          microphone->audio_unit = nil;
       }
-      free(microphone);
+      if (microphone->sample_buffer)
+         fifo_free(microphone->sample_buffer);
+      /* Don't free microphone - it's the driver context, freed by coreaudio_microphone_free */
    }
    return NULL;
 }
@@ -378,8 +380,11 @@ static void coreaudio_microphone_close_mic(void *driver_context, void *microphon
          microphone->audio_unit = nil;
       }
       if (microphone->sample_buffer)
+      {
          fifo_free(microphone->sample_buffer);
-      free(microphone);
+         microphone->sample_buffer = NULL;
+      }
+      /* Don't free microphone - it's the driver context, freed by coreaudio_microphone_free */
    }
    else
    {

audio/microphone_driver.h

@@ -135,16 +135,6 @@ struct retro_microphone
     */
    void *microphone_context;
 
-   /**
-    * Pointer to the data that will be copied to cores.
-    */
-   int16_t* sample_buffer;
-
-   /**
-    * Length of \c sample_buffer in bytes, \em not samples.
-    */
-   size_t sample_buffer_length;
-
    /**
     * Bit flags that describe the state of this microphone.
     *