Skip to content

Commit 1adeea5

Browse files
committed
dialog: Print DBus errors where available
1 parent 29f86b7 commit 1adeea5

File tree

1 file changed

+17
-2
lines changed

1 file changed

+17
-2
lines changed

src/dialog/unix/SDL_portaldialog.c

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -350,6 +350,7 @@ void SDL_Portal_ShowFileDialogWithProperties(SDL_FileDialogType type, SDL_Dialog
350350
}
351351

352352
SDL_DBusContext *dbus = SDL_DBus_GetContext();
353+
DBusError error;
353354
DBusMessage *msg;
354355
DBusMessageIter params, options;
355356
const char *signal_id = NULL;
@@ -361,6 +362,8 @@ void SDL_Portal_ShowFileDialogWithProperties(SDL_FileDialogType type, SDL_Dialog
361362

362363
const char *err_msg = validate_filters(filters, nfilters);
363364

365+
dbus->error_init(&error);
366+
364367
if (err_msg) {
365368
SDL_SetError("%s", err_msg);
366369
callback(userdata, NULL, -1);
@@ -459,7 +462,13 @@ void SDL_Portal_ShowFileDialogWithProperties(SDL_FileDialogType type, SDL_Dialog
459462
}
460463
dbus->message_iter_close_container(&params, &options);
461464

462-
DBusMessage *reply = dbus->connection_send_with_reply_and_block(dbus->session_conn, msg, DBUS_TIMEOUT_INFINITE, NULL);
465+
DBusMessage *reply = dbus->connection_send_with_reply_and_block(dbus->session_conn, msg, DBUS_TIMEOUT_INFINITE, &error);
466+
if (dbus->error_is_set(&error)) {
467+
SDL_SetError("Failed to open dialog via DBus, %s: %s", error.name, error.message);
468+
dbus->error_free(&error);
469+
goto cleanup;
470+
}
471+
463472
if (reply) {
464473
DBusMessageIter reply_iter;
465474
dbus->message_iter_init(reply, &reply_iter);
@@ -485,9 +494,15 @@ void SDL_Portal_ShowFileDialogWithProperties(SDL_FileDialogType type, SDL_Dialog
485494
}
486495

487496
SDL_snprintf(filter, filter_len, SIGNAL_FILTER"%s'", signal_id);
488-
dbus->bus_add_match(dbus->session_conn, filter, NULL);
497+
dbus->bus_add_match(dbus->session_conn, filter, &error);
489498
SDL_free(filter);
490499

500+
if (dbus->error_is_set(&error)) {
501+
SDL_SetError("Failed to set up DBus listener for dialog, %s: %s", error.name, error.message);
502+
dbus->error_free(&error);
503+
goto cleanup;
504+
}
505+
491506
SignalCallback *data = SDL_malloc(sizeof(SignalCallback));
492507
if (!data) {
493508
callback(userdata, NULL, -1);

0 commit comments

Comments
 (0)