Fix #13083 segfault in SDL_RemoveTrayEntry() for submenu entries

bwRavencl · slouken · commit 22828d5f2a19 · 2025-05-21T13:32:28.000-07:00
Use `g_object_ref_sink()` in `SDL_CreateTraySubmenu()` as introduced with 3be67ce for the top-level menu.
diff --git a/src/tray/unix/SDL_tray.c b/src/tray/unix/SDL_tray.c
@@ -541,7 +541,7 @@ SDL_TrayMenu *SDL_CreateTraySubmenu(SDL_TrayEntry *entry)
         return NULL;
     }
 
-    entry->submenu->menu = (GtkMenuShell *)gtk_menu_new();
+    entry->submenu->menu = g_object_ref_sink(gtk_menu_new());
     entry->submenu->parent_tray = NULL;
     entry->submenu->parent_entry = entry;
     entry->submenu->nEntries = 0;

Original file line number	Diff line number	Diff line change
`@@ -541,7 +541,7 @@ SDL_TrayMenu SDL_CreateTraySubmenu(SDL_TrayEntry entry)`
`541`	`541`	`return NULL;`
`542`	`542`	`}`
`543`	`543`
`544`		`- entry->submenu->menu = (GtkMenuShell *)gtk_menu_new();`
	`544`	`+ entry->submenu->menu = g_object_ref_sink(gtk_menu_new());`
`545`	`545`	`entry->submenu->parent_tray = NULL;`
`546`	`546`	`entry->submenu->parent_entry = entry;`
`547`	`547`	`entry->submenu->nEntries = 0;`