linux/SDL_syshaptic.c:SDL_SYS_HapticStopAll(): Fix return on error

Sackzement · slouken · commit 43f39913980b · 2025-08-09T09:27:35.000-07:00
diff --git a/src/haptic/linux/SDL_syshaptic.c b/src/haptic/linux/SDL_syshaptic.c
@@ -1117,13 +1117,12 @@ bool SDL_SYS_HapticResume(SDL_Haptic *haptic)
  */
 bool SDL_SYS_HapticStopAll(SDL_Haptic *haptic)
 {
-    int i, ret;
+    int i;
 
     // Linux does not support this natively so we have to loop.
     for (i = 0; i < haptic->neffects; i++) {
         if (haptic->effects[i].hweffect != NULL) {
-            ret = SDL_SYS_HapticStopEffect(haptic, &haptic->effects[i]);
-            if (ret < 0) {
+            if (!SDL_SYS_HapticStopEffect(haptic, &haptic->effects[i])) {
                 return SDL_SetError("Haptic: Error while trying to stop all playing effects.");
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -1117,13 +1117,12 @@ bool SDL_SYS_HapticResume(SDL_Haptic *haptic)`
`1117`	`1117`	`*/`
`1118`	`1118`	`bool SDL_SYS_HapticStopAll(SDL_Haptic *haptic)`
`1119`	`1119`	`{`
`1120`		`- int i, ret;`
	`1120`	`+ int i;`
`1121`	`1121`
`1122`	`1122`	`// Linux does not support this natively so we have to loop.`
`1123`	`1123`	`for (i = 0; i < haptic->neffects; i++) {`
`1124`	`1124`	`if (haptic->effects[i].hweffect != NULL) {`
`1125`		`- ret = SDL_SYS_HapticStopEffect(haptic, &haptic->effects[i]);`
`1126`		`- if (ret < 0) {`
	`1125`	`+ if (!SDL_SYS_HapticStopEffect(haptic, &haptic->effects[i])) {`
`1127`	`1126`	`return SDL_SetError("Haptic: Error while trying to stop all playing effects.");`
`1128`	`1127`	`}`
`1129`	`1128`	`}`