Fixed replacing existing specific gamepad mappings

slouken · slouken · commit 582696687386 · 2025-06-06T09:53:15.000-07:00
If the first mapping we see doesn't have a CRC, continue looking for another exact CRC match.

Fixes testautomation --filter TestVirtualJoystick
diff --git a/src/joystick/SDL_gamepad.c b/src/joystick/SDL_gamepad.c
@@ -958,7 +958,7 @@ static GamepadMapping_t *SDL_PrivateMatchGamepadMappingForGUID(SDL_GUID guid, bo
                 // An exact match, including CRC
                 return mapping;
             } else if (crc && exact_match_crc) {
-                return NULL;
+                continue;
             }
 
             if (!best_match) {

Original file line number	Diff line number	Diff line change
`@@ -958,7 +958,7 @@ static GamepadMapping_t *SDL_PrivateMatchGamepadMappingForGUID(SDL_GUID guid, bo`
`958`	`958`	`// An exact match, including CRC`
`959`	`959`	`return mapping;`
`960`	`960`	`} else if (crc && exact_match_crc) {`
`961`		`- return NULL;`
	`961`	`+ continue;`
`962`	`962`	`}`
`963`	`963`
`964`	`964`	`if (!best_match) {`