SDL_gpu.c: Fixed deref-before-check warning

Sackzement · slouken · commit 6a5af95364f7 · 2025-07-26T12:08:23.000-07:00
diff --git a/src/gpu/SDL_gpu.c b/src/gpu/SDL_gpu.c
@@ -2242,14 +2242,14 @@ void SDL_DrawGPUIndexedPrimitivesIndirect(
 void SDL_EndGPURenderPass(
     SDL_GPURenderPass *render_pass)
 {
-    CommandBufferCommonHeader *commandBufferCommonHeader;
-    commandBufferCommonHeader = (CommandBufferCommonHeader *)RENDERPASS_COMMAND_BUFFER;
-
     if (render_pass == NULL) {
         SDL_InvalidParamError("render_pass");
         return;
     }
 
+    CommandBufferCommonHeader *commandBufferCommonHeader;
+    commandBufferCommonHeader = (CommandBufferCommonHeader *)RENDERPASS_COMMAND_BUFFER;
+
     if (RENDERPASS_DEVICE->debug_mode) {
         CHECK_RENDERPASS
     }

Original file line number	Diff line number	Diff line change
`@@ -2242,14 +2242,14 @@ void SDL_DrawGPUIndexedPrimitivesIndirect(`
`2242`	`2242`	`void SDL_EndGPURenderPass(`
`2243`	`2243`	`SDL_GPURenderPass *render_pass)`
`2244`	`2244`	`{`
`2245`		`- CommandBufferCommonHeader *commandBufferCommonHeader;`
`2246`		`- commandBufferCommonHeader = (CommandBufferCommonHeader *)RENDERPASS_COMMAND_BUFFER;`
`2247`		`-`
`2248`	`2245`	`if (render_pass == NULL) {`
`2249`	`2246`	`SDL_InvalidParamError("render_pass");`
`2250`	`2247`	`return;`
`2251`	`2248`	`}`
`2252`	`2249`
	`2250`	`+ CommandBufferCommonHeader *commandBufferCommonHeader;`
	`2251`	`+ commandBufferCommonHeader = (CommandBufferCommonHeader *)RENDERPASS_COMMAND_BUFFER;`
	`2252`	`+`
`2253`	`2253`	`if (RENDERPASS_DEVICE->debug_mode) {`
`2254`	`2254`	`CHECK_RENDERPASS`
`2255`	`2255`	`}`