Don't leave garbage in output parameters

slouken · slouken · commit c663b6ec1f34 · 2025-07-29T20:48:56.000-07:00
diff --git a/src/audio/SDL_audiocvt.c b/src/audio/SDL_audiocvt.c
@@ -531,6 +531,12 @@ bool SDL_UnlockAudioStream(SDL_AudioStream *stream)
 bool SDL_GetAudioStreamFormat(SDL_AudioStream *stream, SDL_AudioSpec *src_spec, SDL_AudioSpec *dst_spec)
 {
     if (!stream) {
+        if (src_spec) {
+            SDL_zerop(src_spec);
+        }
+        if (dst_spec) {
+            SDL_zerop(dst_spec);
+        }
         return SDL_InvalidParamError("stream");
     }
 

Original file line number	Diff line number	Diff line change
`@@ -531,6 +531,12 @@ bool SDL_UnlockAudioStream(SDL_AudioStream *stream)`
`531`	`531`	`bool SDL_GetAudioStreamFormat(SDL_AudioStream stream, SDL_AudioSpec src_spec, SDL_AudioSpec *dst_spec)`
`532`	`532`	`{`
`533`	`533`	`if (!stream) {`
	`534`	`+ if (src_spec) {`
	`535`	`+ SDL_zerop(src_spec);`
	`536`	`+ }`
	`537`	`+ if (dst_spec) {`
	`538`	`+ SDL_zerop(dst_spec);`
	`539`	`+ }`
`534`	`540`	`return SDL_InvalidParamError("stream");`
`535`	`541`	`}`
`536`	`542`