Add hint for blocking win key when using raw keyboard #13066
+59
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Susko3
suggested changes
Aug 3, 2025
expikr
changed the title
expikr
force-pushed
the
rawkey
branch
3 times, most recently
from
91a9e26 to
6f443ff
Compare
expikr
changed the title
Susko3
suggested changes
Aug 28, 2025
Susko3
suggested changes
Aug 30, 2025
There was a problem hiding this comment.
From my side and from our intended usage of this hint, I've tested it works as expected. ✅ I'd just like to note that on Windows 11, there is no old-style Alt-Tab dialog and pressing Alt-Tab just switches to the previously used application (this is fine and works as expected).
The internal implementation seems a bit convoluted and hacked in, there's space to improve it and improving it isn't too difficult, just try to follow existing practices and match existing code patterns.
The current code in this PR could affect GameInput, but refactoring the code should remove unexpected interactions. I haven't tested GameInput.
expikr
force-pushed
the
rawkey
branch
2 times, most recently
from
c20904a to
789aeb0
Compare
Susko3
suggested changes
Aug 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Susko3 windows' rawinput keyboard natively support blocking the Windows key via RIDEV_NOHOTKEYS while leaving alt-tab intact. The only drawback is that the Alt-Tab menu becomes the classic style when tabbing out.