Add FIRST and LAST event aliases to SDL_event #13331
Open
+21
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wasn't sure on how to name the keyboard events, so I left out SDL_EVENT_KEYBOARD_FIRST and LAST. Should I name it that, and have it include everything under that section? |
slouken
reviewed
Jul 11, 2025
slouken
reviewed
Jul 11, 2025
slouken
reviewed
Jul 11, 2025
This makes it easier for SDL users to offload handling of event types to different handlers, and have those handlers match on the specific event type; the event poller only has to check the ranges to know who to hand the event to.
|
FYI, this failed CI and needs to be fixed before merging. |
|
Wouldn't the presence of a LAST plug prevent new event types of the same category from being added due to ABI compatibility guarantees? e.g. if one were to add a new SDL_EVENT_MOUSE_RAW_MOTION event then the status quo would permit it since it doesn't change the enum value, whereas with this addition it will break ABI compat of the LAST enum member. |
|
This is API, not ABI, I believe. The app compiles against an integer value
of LAST that stays that way until it recompiles, and even if SDL put out
the new event, the app wouldn't know what to do with it, so there's no
point in worrying about that.
We already have some FIRST and LAST events, so what's done is done. It's
more convenient to have it apply to all categories.
…On Sat, Aug 30, 2025, 7:02 PM expikr ***@***.***> wrote:
*expikr* left a comment (libsdl-org/SDL#13331)
<#13331 (comment)>
Wouldn't the presence of a LAST plug prevent new event types of the same
category from being added due to ABI compatibility guarantees? e.g. if one
were to add a new SDL_EVENT_MOUSE_RAW_MOTION event then the status quo
would permit it since it doesn't change the enum value, whereas with this
addition it will break ABI compat of the LAST enum member.
—
Reply to this email directly, view it on GitHub
<#13331 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWHH7L6PVS34R6WSIM75H233QI3R3AVCNFSM6AAAAACA4WHC7SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMZZGYYTKOBWGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier for SDL users to offload handling of event types to different handlers, and have those handlers match on the specific event type; the event poller only has to check the ranges to know who to hand the event to.