UT2004 (via sdl12-compat) splash screen doesn't center.

[icculus]

The splash screen in UT2004:

Should be centered on the desktop before the game loads, as it is when sdl12-compat is talking to real SDL2:

But it's loading over on the left hand side when chained through sdl12-compat to sdl2-compat to SDL3:

Relevant code in UT2004:

    putenv("SDL_WINDOW_POS=center");        // legacy.
    putenv("SDL_VIDEO_WINDOW_POS=center");  // new in SDL CVS.
    SDL_Surface *screen = SDL_SetVideoMode(bmp->w, bmp->h, 0, SDL_NOFRAME);
    putenv("SDL_WINDOW_POS=nopref");  // !!! FIXME: is there a portable way to delete values?
    putenv("SDL_VIDEO_WINDOW_POS=nopref");  // !!! FIXME: is there a portable way to delete values?

[madebr]

I don't have the game, but what is the video driver? wayland does not allow putting windows at specific coordinates.

[icculus]

In this case, SDL's x11 backend, on real X11...not XWayland or anything.

[icculus]

in sdl12-compat:

static void
GetEnvironmentWindowPosition(int *x, int *y)
{
    int display = VideoDisplayIndex;
    const char *window = SDL20_getenv("SDL_VIDEO_WINDOW_POS");
    const char *center = SDL20_getenv("SDL_VIDEO_CENTERED");

...window is coming up as NULL. If I swap SDL20_getenv with SDL12COMPAT_GetEnvAtStartup, it works.

Something with the SDL3 environment management stuff? It probably doesn't catch the app calling putenv after it's already been set up.

[slouken]

Something with the SDL3 environment management stuff? It probably doesn't catch the app calling putenv after it's already been set up.

Yes, the environment is cached in SDL3 because it's not thread-safe.

[icculus]

If it's just ut2004 (etc) trying to center a splash screen, we can add a quirk and be done with it, otherwise this was a way that SDL-1.2 apps interacted with SDL before there was a Hint API, so we should probably go back to unsafe getenv in sdl12-compat.

[slouken]

If it's just ut2004 (etc) trying to center a splash screen, we can add a quirk and be done with it, otherwise this was a way that SDL-1.2 apps interacted with SDL before there was a Hint API, so we should probably go back to unsafe getenv in sdl12-compat.

Yeah, we should use the unsafe getenv in sdl12-compat.

[icculus]

Mmm...doing this right is going to take more work, since SDL3 will want to check its own SDL_Environment internally, too, so we need to deal with SDL_VIDEODRIVER, etc, when the app sets it too late to make it into that table. We'll need to check those things with the OS interfaces and forward them to SDL20_setenv() at the appropriate times.

For this specific issue, we could cheat for now and just check this one thing with unsafe getenv(), and come back to this later for a more-robust solution.

[icculus]

Well...maybe it's just a handful of things, and we can just forward them to the actual Hint APIs instead. I dunno.

[icculus]

I put together a Pull Request for sdl12-compat, which I think covers the reasonable bits.

We may need something like this in sdl2-compat, too, if there are apps setting environment variables on the fly instead of using SDL_SetHint(). But maybe we cross that bridge if we come to it, and call this done when the sdl12-compat PR merges.