try adding an icon theme #79
Conversation
This kind-of works, you do get better icons, however: - the fullscreen icon (top right of right-click menu) is still a placeholder (should be a pair of arrows pointing in opposite directions), despite the correct SVG being copied into the correct place in the build - icons are not rendered with desktop scaling changes, so they get fuzzy at eg. 225% (this works correctly on my ubuntu fwiw) - it'd be good to attach the vipsdisp icon to the generated exe as well, I suppose we need an ICO version of the PNG
|
Eg. at 225% on win10 I see: 
The difference in sharpness between the icons and the text is jarring. |
|
Ah here's a better comparison ... ubuntu at 300%: 
win10 at 200%: 
|
|
vipsdisp now has a program icon at least: 
|
|
Great! Commit 6a7bbca updates adwaita-icon-theme to 48.1, but the icons still appear blurry at 200% scale. I'm not sure why that's happening (perhaps it uses PNG images rather than SVG?). |
|
Ah, the fullscreen icon is still a placeholder. Weird. |
|
Maybe the gtk SVG loader isn't enabled for some reason? I'll see if I can test it somehow. |
|
Here are the debug logs: Details$ set GTK_DEBUG=icontheme,iconfallback
$ set G_WIN32_ATTACH_CONSOLE=stdout,stderr
$ vipsdisp
look for icon cache in C:\Users\kleisauke\vipsdisp-x86_64-4.1.1-windows-icon\share\icons\Adwaita
icon cache outdated
...
Current icon themes Adwaita hicolor
754 strings, 5 chunks
...
org.libvips.vipsdisp
...
view-fullscreen-symbolic
...
looking up icon view-fullscreen-symbolic for scale 2
lookup name: view-fullscreen-symbolic-ltr
lookup name: view-fullscreen-symbolic
lookup name: view-fullscreen-ltr
lookup name: view-fullscreen
No icon found in Adwaita (or fallbacks) for: view-fullscreen-symbolic-ltr, view-fullscreen-symbolic, view-fullscreen-ltr, view-fullscreen
lookup name: image-missingIt looks like it doesn't want to use the scalable variant of |
|
Ah, I think I know what's wrong. librsvg only became a dependency of GTK starting with v4.19.2 (GNOME/gtk@939bf25). In earlier versions, it's likely using the librsvg loader via GDK-PixBuf, which isn't built. build-win64-mxe/build/overrides.mk Line 560 in 89d7736 |
|
Ah, I wondered if it was something like that. I just made a test vipsdisp which adds a SVG backdrop to imagewindow: https://github.com/jcupitt/vipsdisp/releases/tag/v4.1.1-test-gtk-svg-load |
|
For the icon cache warning, I think when we copy (though I think the warning is probably harmless) |
|
Yes, adding the touch fixes the icon cache warning. I now see: The SVG backdrop fails to render though, so as you say I think pixbuf is missing that loader. |
|
librsvg fails to build with pixbuf-loader enabled: It looks like we need to patch I'll have a go. |
|
Commit 4a04adc should fix this. Phew! |
|
Oh haha you beat me! I was trying to update gtk4 to 4.19.2 instead. I'll try your patch! |
|
Commit f35126c in PR #77 did update GTK to 4.19.2, but I reverted that due to https://gitlab.gnome.org/GNOME/gtk/-/issues/7567. I'll give it another shot once that's sorted out. Anyway, I forgot to upload a screenshot: |
|
That looks great! Except for the stupid lion in the background. |
|
I made a vipsdisp 4.1.2 release with the icon stuff in, it all works very well now! Thank you for fixing it! https://github.com/jcupitt/vipsdisp/releases/tag/v4.1.2 I promise not to touch any of this again for many weeks. |
kleisauke
left a comment
kleisauke
left a comment
There was a problem hiding this comment.
Thank you! The MSI installer is the only thing left on my GTK TODO list now. :)
Haha! Good luck with that. |
This kind-of works, you do get better icons, however:
the fullscreen icon (top right of right-click menu) is still a placeholder (should be a pair of arrows pointing in opposite directions), despite the correct SVG being copied into the correct place in the build
icons are not rendered with desktop scaling changes, so they get fuzzy at eg. 225% (this works correctly on my ubuntu fwiw)
it'd be good to attach the vipsdisp icon to the generated exe as well, I suppose we need an ICO version of the PNG