Merge pull request #71 from libwww-perl/oalders/perlimports

Apply perlimports to tests

Author: simbabque

.github/workflows/build-and-test.yml

@@ -16,7 +16,7 @@ jobs:
     name: Build distribution
     runs-on: ubuntu-latest
     container:
-      image: perldocker/perl-tester:5.32
+      image: perldocker/perl-tester:5.36
     steps:
       - uses: actions/checkout@v2
       - name: install aspell
@@ -28,7 +28,7 @@ jobs:
           EXTENDED_TESTING: 1
           RELEASE_TESTING: 1
         run: upgrade-perl-helpers && auto-build-and-test-dist
-      - uses: actions/upload-artifact@master
+      - uses: actions/upload-artifact@v3
         with:
           name: build_dir
           path: build_dir
@@ -37,10 +37,10 @@ jobs:
     needs: build-job
     runs-on: ubuntu-latest
     container:
-      image: perldocker/perl-tester:5.32
+      image: perldocker/perl-tester:5.36
     steps:
       - uses: actions/checkout@v2 # codecov wants to be inside a Git repository
-      - uses: actions/download-artifact@master
+      - uses: actions/download-artifact@v3
         with:
           name: build_dir
           path: .
@@ -70,9 +70,11 @@ jobs:
           - "5.28"
           - "5.30"
           - "5.32"
+          - "5.34"
+          - "5.36"
     steps:
       - uses: actions/checkout@v2
-      - uses: actions/download-artifact@master
+      - uses: actions/download-artifact@v3
         with:
           name: build_dir
           path: .
@@ -98,12 +100,14 @@ jobs:
           - "5.28"
           - "5.30"
           - "5.32"
+          - "5.34"
+          - "5.36"
     steps:
       - name: Set Up Perl
         uses: shogo82148/actions-setup-perl@v1
         with:
           perl-version: ${{ matrix.perl-version }}
-      - uses: actions/download-artifact@master
+      - uses: actions/download-artifact@v3
         with:
           name: build_dir
           path: .
@@ -137,7 +141,7 @@ jobs:
         with:
           perl-version: ${{ matrix.perl-version }}
           distribution: strawberry # this option only used on Windows
-      - uses: actions/download-artifact@master
+      - uses: actions/download-artifact@v3
         with:
           name: build_dir
           path: .
@@ -146,4 +150,4 @@ jobs:
         with:
           cpanfile: "cpanfile"
           args: "--with-suggests --with-test --with-develop"
-      - run: cpanm --testonly -v .
+      - run: cpanm --testonly -v .

perlimports.toml

@@ -0,0 +1,25 @@
+# Valid log levels are:
+# debug, info, notice, warning, error, critical, alert, emergency
+# critical, alert and emergency are not currently used.
+#
+# Please use boolean values in this config file. Negated options (--no-*) are
+# not permitted here. Explicitly set options to true or false.
+#
+# Some of these values deviate from the regular perlimports defaults. In
+# particular, you're encouraged to leave preserve_duplicates and
+# preserve_unused disabled.
+
+cache                           = false # setting this to true is currently discouraged
+ignore_modules                  = ["Test::More"]
+ignore_modules_filename         = ""
+ignore_modules_pattern          = "" # regex like "^(Foo|Foo::Bar)"
+ignore_modules_pattern_filename = ""
+libs                            = ["lib", "t/lib"]
+log_filename                    = ""
+log_level                       = "warn"
+never_export_modules            = []
+never_export_modules_filename   = ""
+padding                         = true
+preserve_duplicates             = false
+preserve_unused                 = false
+tidy_whitespace                 = true

t/cookies.t

@@ -1,10 +1,11 @@
 #!perl -w
 
-use Test::More tests => 79;
+use HTTP::Cookies ();
+use HTTP::Request ();
+use HTTP::Response ();
+use URI ();
 
-use HTTP::Cookies;
-use HTTP::Request;
-use HTTP::Response;
+use Test::More tests => 79;
 
 #-------------------------------------------------------------------
 # First we check that it works for the original example at
@@ -443,7 +444,6 @@ $c->extract_cookies($res);
 
 print $c->as_string;
 
-require URI;
 $req = HTTP::Request->new(POST => URI->new("http://foo.bar.acme.com/foo"));
 $c->add_cookie_header($req);
 #print $req->as_string;

t/issue26.t

@@ -1,8 +1,8 @@
 use strict;
 use Test::More;
-use HTTP::Cookies;
-use HTTP::Response;
-use HTTP::Request;
+use HTTP::Cookies ();
+use HTTP::Response ();
+use HTTP::Request ();
 
 my $CRLF="\015\012";
 

t/issue32.t

@@ -2,9 +2,9 @@ use strict;
 use warnings;
 use Test::More;
 
-use HTTP::Cookies;
-use HTTP::Request;
-use HTTP::Response;
+use HTTP::Cookies ();
+use HTTP::Request ();
+use HTTP::Response ();
 
 my $nextyear = 1901+(gmtime())[5];