Ensure status checks have a value and test. Fixes #39

Author: genio

META.json

@@ -4,7 +4,7 @@
       "Gisle Aas <[email protected]>"
    ],
    "dynamic_config" : 0,
-   "generated_by" : "Dist::Zilla version 6.007, CPAN::Meta::Converter version 2.150010",
+   "generated_by" : "Dist::Zilla version 6.008, CPAN::Meta::Converter version 2.150010",
    "license" : [
       "perl_5"
    ],
@@ -118,15 +118,16 @@
       "Jerome Eteve <[email protected]>",
       "john9art <[email protected]>",
       "Karen Etheridge <[email protected]>",
+      "Karen Etheridge <[email protected]>",
       "Mark Overmeer <[email protected]>",
       "Mark Stosberg <[email protected]>",
       "Mark Stosberg <[email protected]>",
       "Mark Stosberg <[email protected]>",
       "Martin H. Sluka <[email protected]>",
       "mickey <[email protected]>",
       "Mickey Nasriachi <[email protected]>",
+      "Mike Schilli <[email protected]>",
       "Mike Schilli <[email protected]>",
-      "mschilli <[email protected]>",
       "murphy <[email protected]>",
       "Olaf Alders <[email protected]>",
       "Olivier Mengu\u00e9 <[email protected]>",
@@ -153,6 +154,6 @@
       "Yuri Karaban <[email protected]>",
       "Zefram <[email protected]>"
    ],
-   "x_serialization_backend" : "Cpanel::JSON::XS version 3.0217"
+   "x_serialization_backend" : "Cpanel::JSON::XS version 3.0225"
 }
 

Makefile.PL

@@ -1,4 +1,4 @@
-# This file was automatically generated by Dist::Zilla::Plugin::MakeMaker v6.007.
+# This file was automatically generated by Dist::Zilla::Plugin::MakeMaker v6.008.
 use strict;
 use warnings;
 

lib/HTTP/Status.pm

@@ -102,12 +102,12 @@ our %EXPORT_TAGS = (
 
 sub status_message  ($) { $StatusCode{$_[0]}; }
 
-sub is_info         ($) { $_[0] >= 100 && $_[0] < 200; }
-sub is_success      ($) { $_[0] >= 200 && $_[0] < 300; }
-sub is_redirect     ($) { $_[0] >= 300 && $_[0] < 400; }
-sub is_error        ($) { $_[0] >= 400 && $_[0] < 600; }
-sub is_client_error ($) { $_[0] >= 400 && $_[0] < 500; }
-sub is_server_error ($) { $_[0] >= 500 && $_[0] < 600; }
+sub is_info         ($) { $_[0] && $_[0] >= 100 && $_[0] < 200; }
+sub is_success      ($) { $_[0] && $_[0] >= 200 && $_[0] < 300; }
+sub is_redirect     ($) { $_[0] && $_[0] >= 300 && $_[0] < 400; }
+sub is_error        ($) { $_[0] && $_[0] >= 400 && $_[0] < 600; }
+sub is_client_error ($) { $_[0] && $_[0] >= 400 && $_[0] < 500; }
+sub is_server_error ($) { $_[0] && $_[0] >= 500 && $_[0] < 600; }
 
 1;
 
@@ -267,4 +267,3 @@ the C<:constants> tag instead of relying on this.
 =cut
 
 #ABSTRACT: HTTP Status code processing
-

t/response.t

@@ -5,12 +5,23 @@ use strict;
 use warnings;
 
 use Test::More;
-plan tests => 23;
+plan tests => 29;
 
 use HTTP::Date;
 use HTTP::Request;
 use HTTP::Response;
 
+# make sure we get no failures from undefined response values
+{
+    my $req = HTTP::Response->new();
+    is($req->is_success(), undef, 'Empty res: is_success');
+    is($req->is_info(), undef, 'Empty res: is_info');
+    is($req->is_redirect(), undef, 'Empty res: is_redirect');
+    is($req->is_error(), undef, 'Empty res: is_error');
+    is($req->is_client_error(), undef, 'Empty res: is_client_error');
+    is($req->is_server_error(), undef, 'Empty res: is_server_error');
+}
+
 my $time = time;
 
 my $req = HTTP::Request->new(GET => 'http://www.sn.no');

tidyall.ini

@@ -1,23 +1,15 @@
 [PerlTidy]
 select = **/*.{pl,pm,t,psgi}
+ignore = .build/**/*
+ignore = HTTP-Message-*/**/*
+ignore = blib/**/*
 ignore = t/00-*
 ignore = t/author-*
 ignore = t/release-*
-ignore = blib/**/*
-ignore = .build/**/*
-ignore = HTTP-Message-*/**/*
+ignore = t/zzz-*
+ignore = xt/**/*
 argv = --profile=$ROOT/perltidyrc
 
-;[PerlCritic]
-;select = **/*.{pl,pm,t,psgi}
-;ignore = t/00-*
-;ignore = t/author-*
-;ignore = t/release-*
-;ignore = blib/**/*
-;ignore = .build/**/*
-;ignore = HTTP-Message-*/**/*
-;argv = --profile $ROOT/perlcriticrc --program-extensions .pl  --program-extensions .t --program-extensions .psgi
-
 [SortLines::Naturally]
 select = .gitignore