Adding WebSocket (ws) URI #158
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for WebSocket URI schemes (ws:// and wss://) to the URI library. WebSocket URIs are defined in RFC 6455 and enable two-way communication between clients and servers, with wss:// providing SSL-secured connections.
- Implementation of
URI::wsandURI::wssmodules that inherit fromURI::httpandURI::httpsrespectively - Addition of comprehensive test coverage for WebSocket URI functionality
- Documentation updates to include WebSocket scheme descriptions
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/URI/ws.pm | Implements the ws:// URI scheme by inheriting from URI::http |
| lib/URI/wss.pm | Implements the wss:// URI scheme by inheriting from URI::https |
| t/ws.t | Test suite covering WebSocket URI parsing, port handling, and scheme switching |
| lib/URI.pm | Documentation additions describing the ws:// and wss:// schemes |
| dist.ini | Adds "WebSocket" as an accepted spelling for documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding WebSocket scheme