Bump minimum Perl to 5.8

JRaspass · oalders · commit 6e1f465bb3ff · 2022-08-30T12:46:48.000-04:00
Fixes #351
diff --git a/Changes b/Changes
@@ -1,11 +1,15 @@
 Revision history for WWW::Mechanize
 
 {{$NEXT}}
+    [FIXED]
+    - Raise minimum Perl to 5.8 to match what we test, what dependencies
+      depend on, etc. (GH#352) (James Raspass)
 
 2.15      2022-08-21 07:47:35Z
     [FIXED]
     - There was a test suite failure on some Windows machines introduced in
       2.14 that is now fixed. (GH#350) (Julien Fiegehenn)
+
     [ENHANCEMENTS]
     - form_with and all_forms_with() now support the "action" attribute to find
       forms (GH#349) (Julien Fiegehenn)
diff --git a/META.json b/META.json
@@ -80,7 +80,7 @@
             "URI::URL" : "0",
             "URI::file" : "0",
             "base" : "0",
-            "perl" : "5.006",
+            "perl" : "5.008",
             "strict" : "0",
             "warnings" : "0"
          }
@@ -962,4 +962,3 @@
    "x_spdx_expression" : "Artistic-1.0-Perl OR GPL-1.0-or-later",
    "x_static_install" : 1
 }
-
diff --git a/Makefile.PL b/Makefile.PL
@@ -2,7 +2,7 @@
 use strict;
 use warnings;
 
-use 5.006;
+use 5.008;
 
 use ExtUtils::MakeMaker;
 
@@ -17,7 +17,7 @@ my %WriteMakefileArgs = (
     "script/mech-dump"
   ],
   "LICENSE" => "perl",
-  "MIN_PERL_VERSION" => "5.006",
+  "MIN_PERL_VERSION" => "5.008",
   "NAME" => "WWW::Mechanize",
   "PREREQ_PM" => {
     "Carp" => 0,
diff --git a/cpanfile b/cpanfile
@@ -17,7 +17,7 @@ requires "Tie::RefHash" => "0";
 requires "URI::URL" => "0";
 requires "URI::file" => "0";
 requires "base" => "0";
-requires "perl" => "5.006";
+requires "perl" => "5.008";
 requires "strict" => "0";
 requires "warnings" => "0";
 recommends "Compress::Zlib" => "0";
diff --git a/dist.ini b/dist.ini
@@ -23,7 +23,7 @@ dir = script
 [Test::Pod::LinkCheck]
 
 [Prereqs / RuntimeRequires]
-perl = 5.006
+perl = 5.008
 HTML::Form = 6.08
 Scalar::Util = 1.14
 
diff --git a/t/add_header.t b/t/add_header.t
@@ -6,7 +6,6 @@ use Test::More tests => 4;
 use HTTP::Request::Common qw( GET );
 
 BEGIN {
-    delete @ENV{qw( PATH IFS CDPATH ENV BASH_ENV )};  # Placates taint-unsafe Cwd.pm in 5.6.1
     use_ok( 'WWW::Mechanize' );
 }
 
diff --git a/t/field.t b/t/field.t
@@ -7,7 +7,6 @@ use Test::More;
 use URI::file ();
 
 BEGIN {
-    delete @ENV{qw(PATH IFS CDPATH ENV BASH_ENV)}; # Placates taint-unsafe Cwd.pm in 5.6.1
     use_ok( 'WWW::Mechanize' );
 }
 
diff --git a/t/find_frame.t b/t/find_frame.t
@@ -6,7 +6,6 @@ use Test::More tests => 5;
 use URI::file ();
 
 BEGIN {
-    delete @ENV{qw(PATH IFS CDPATH ENV BASH_ENV)};  # Placates taint-unsafe Cwd.pm in 5.6.1
     use_ok( 'WWW::Mechanize' );
 }
 
diff --git a/t/find_image.t b/t/find_image.t
@@ -10,7 +10,6 @@ use Test::Deep qw( all cmp_deeply isa methods re superhashof );
 use URI::file ();
 
 BEGIN {
-    delete @ENV{qw(PATH IFS CDPATH ENV BASH_ENV)};  # Placates taint-unsafe Cwd.pm in 5.6.1
     use_ok( 'WWW::Mechanize' );
 }
 
diff --git a/t/find_inputs.t b/t/find_inputs.t
@@ -7,7 +7,6 @@ use Test::More tests => 11;
 use URI::file ();
 
 BEGIN {
-    delete @ENV{qw(PATH IFS CDPATH ENV BASH_ENV)};  # Placates taint-unsafe Cwd.pm in 5.6.1
     use_ok( 'WWW::Mechanize' );
 }
 
diff --git a/t/find_link-warnings.t b/t/find_link-warnings.t
@@ -6,8 +6,6 @@ use Test::Warn qw( warning_like );
 use URI::file      ();
 use WWW::Mechanize ();
 
-BEGIN { delete @ENV{ qw( http_proxy HTTP_PROXY PATH IFS CDPATH ENV BASH_ENV) }; }
-
 my $mech = WWW::Mechanize->new( cookie_jar => undef, max_redirect => 0 );
 isa_ok( $mech, 'WWW::Mechanize' );
 
diff --git a/t/find_link.t b/t/find_link.t
@@ -7,7 +7,6 @@ use Test::More;
 use URI::file ();
 
 BEGIN {
-    delete @ENV{qw(PATH IFS CDPATH ENV BASH_ENV)};  # Placates taint-unsafe Cwd.pm in 5.6.1
     use_ok( 'WWW::Mechanize' );
 }
 
diff --git a/t/find_link_id.t b/t/find_link_id.t
@@ -6,7 +6,6 @@ use Test::More 'no_plan';
 use URI::file ();
 
 BEGIN {
-    delete @ENV{qw(PATH IFS CDPATH ENV BASH_ENV)};  # Placates taint-unsafe Cwd.pm in 5.6.1
     use_ok( 'WWW::Mechanize' );
 }
 
diff --git a/t/find_link_xhtml.t b/t/find_link_xhtml.t
@@ -7,7 +7,6 @@ use Test::More;
 use URI::file ();
 
 BEGIN {
-    delete @ENV{qw(PATH IFS CDPATH ENV BASH_ENV)};  # Placates taint-unsafe Cwd.pm in 5.6.1
     use_ok( 'WWW::Mechanize' );
 }
 
diff --git a/t/form_with_fields.t b/t/form_with_fields.t
@@ -9,7 +9,6 @@ use Test::Deep qw( cmp_deeply re array_each code );
 use URI::file ();
 
 BEGIN {
-    delete @ENV{qw(PATH IFS CDPATH ENV BASH_ENV)};  # Placates taint-unsafe Cwd.pm in 5.6.1
     use_ok( 'WWW::Mechanize' );
 }
 
diff --git a/t/form_with_fields_passthrough_params.t b/t/form_with_fields_passthrough_params.t
@@ -9,7 +9,6 @@ use Test::Deep qw( cmp_deeply re );
 use URI::file ();
 
 BEGIN {
-    delete @ENV{qw(PATH IFS CDPATH ENV BASH_ENV)};  # Placates taint-unsafe Cwd.pm in 5.6.1
     use_ok( 'WWW::Mechanize' );
 }
 
@@ -243,4 +242,4 @@ ok( $mech->success, "Fetched $uri" ) or die q{Can't get test page};
     );
     isa_ok( $form, 'HTML::Form' );
     is($form->attr('name'), '1st_form', '... and form matches');
-}
+}
diff --git a/t/frames.t b/t/frames.t
@@ -6,7 +6,6 @@ use Test::More tests => 7;
 use URI::file ();
 
 BEGIN {
-    delete @ENV{qw(PATH IFS CDPATH ENV BASH_ENV)};  # Placates taint-unsafe Cwd.pm in 5.6.1
     use_ok( 'WWW::Mechanize' );
 }
 
diff --git a/t/history.t b/t/history.t
@@ -14,8 +14,6 @@ use URI::file ();
 use WWW::Mechanize ();
 
 BEGIN {
-    delete @ENV{qw(PATH IFS CDPATH ENV BASH_ENV)}
-        ;    # Placates taint-unsafe Cwd.pm in 5.6.1
     use_ok('WWW::Mechanize');
 }
 
diff --git a/t/image-parse.t b/t/image-parse.t
@@ -7,7 +7,6 @@ use Test::More tests => 47;
 use URI::file ();
 
 BEGIN {
-    delete @ENV{qw(PATH IFS CDPATH ENV BASH_ENV)};  # Placates taint-unsafe Cwd.pm in 5.6.1
     use_ok( 'WWW::Mechanize' );
 }
 
@@ -93,4 +92,4 @@ is( $css_first->alt, undef, 'alt' );
 
 my $css_second = $images[1];
 is( $css_second->url, 'images/logo.png', 'Got the second image' );
-is( $css_second->tag, 'css', 'css tag' );
+is( $css_second->tag, 'css', 'css tag' );
diff --git a/t/link-relative.t b/t/link-relative.t
@@ -7,7 +7,6 @@ use Test::More tests => 6;
 use URI::file ();
 
 BEGIN {
-    delete @ENV{qw(PATH IFS CDPATH ENV BASH_ENV)}; # Placates taint-unsafe Cwd.pm in 5.6.1
     use_ok( 'WWW::Mechanize' );
 }
 
diff --git a/t/save_content.t b/t/save_content.t
@@ -7,7 +7,6 @@ use Test::More tests => 8;
 use URI::file ();
 
 BEGIN {
-    delete @ENV{qw(PATH IFS CDPATH ENV BASH_ENV)};  # Placates taint-unsafe Cwd.pm in 5.6.1
     use_ok( 'WWW::Mechanize' );
 }
 
diff --git a/t/select.t b/t/select.t
@@ -6,7 +6,6 @@ use Test::More tests => 14;
 use URI::file ();
 
 BEGIN {
-    delete @ENV{qw(PATH IFS CDPATH ENV BASH_ENV)};  # Placates taint-unsafe Cwd.pm in 5.6.1
     use_ok( 'WWW::Mechanize' );
 }
 
diff --git a/t/tick.t b/t/tick.t
@@ -7,7 +7,6 @@ use Test::Fatal qw( exception );
 use Test::More;
 use URI::file ();
 
-delete @ENV{qw(PATH IFS CDPATH ENV BASH_ENV)};  # Placates taint-unsafe Cwd.pm in 5.6.1
 use_ok( 'WWW::Mechanize' );
 
 my $mech = WWW::Mechanize->new( cookie_jar => undef );

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@`
`80`	`80`	`"URI::URL" : "0",`
`81`	`81`	`"URI::file" : "0",`
`82`	`82`	`"base" : "0",`
`83`		`- "perl" : "5.006",`
	`83`	`+ "perl" : "5.008",`
`84`	`84`	`"strict" : "0",`
`85`	`85`	`"warnings" : "0"`
`86`	`86`	`}`
`@@ -962,4 +962,3 @@`
`962`	`962`	`"x_spdx_expression" : "Artistic-1.0-Perl OR GPL-1.0-or-later",`
`963`	`963`	`"x_static_install" : 1`
`964`	`964`	`}`
`965`		`-`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,6 @@ use Test::More tests => 4;`
`6`	`6`	`use HTTP::Request::Common qw( GET );`
`7`	`7`
`8`	`8`	`BEGIN {`
`9`		`- delete @ENV{qw( PATH IFS CDPATH ENV BASH_ENV )}; # Placates taint-unsafe Cwd.pm in 5.6.1`
`10`	`9`	`use_ok( 'WWW::Mechanize' );`
`11`	`10`	`}`
`12`	`11`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,6 @@ use Test::More;`
`7`	`7`	`use URI::file ();`
`8`	`8`
`9`	`9`	`BEGIN {`
`10`		`- delete @ENV{qw(PATH IFS CDPATH ENV BASH_ENV)}; # Placates taint-unsafe Cwd.pm in 5.6.1`
`11`	`10`	`use_ok( 'WWW::Mechanize' );`
`12`	`11`	`}`
`13`	`12`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,6 @@ use Test::Deep qw( all cmp_deeply isa methods re superhashof );`
`10`	`10`	`use URI::file ();`
`11`	`11`
`12`	`12`	`BEGIN {`
`13`		`- delete @ENV{qw(PATH IFS CDPATH ENV BASH_ENV)}; # Placates taint-unsafe Cwd.pm in 5.6.1`
`14`	`13`	`use_ok( 'WWW::Mechanize' );`
`15`	`14`	`}`
`16`	`15`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,6 @@ use Test::More tests => 11;`
`7`	`7`	`use URI::file ();`
`8`	`8`
`9`	`9`	`BEGIN {`
`10`		`- delete @ENV{qw(PATH IFS CDPATH ENV BASH_ENV)}; # Placates taint-unsafe Cwd.pm in 5.6.1`
`11`	`10`	`use_ok( 'WWW::Mechanize' );`
`12`	`11`	`}`
`13`	`12`