add autocheck() method #232

Author: simbabque

Changes

@@ -1,6 +1,9 @@
 Revision history for WWW::Mechanize
 
 {{$NEXT}}
+    [ENHANCEMENTS]
+    - Add autocheck() to enable or disable autochecking at run time in
+      addition to setting it at object creation (GH#232) (Julien Fiegehenn)
 
 2.13      2022-07-29 09:44:46Z
     [ENHANCEMENTS]

lib/WWW/Mechanize.pm

@@ -188,11 +188,12 @@ are errors, not warnings.
 The default value is ON, unless it's being subclassed, in which
 case it is OFF.  This means that standalone L<WWW::Mechanize> instances
 have autocheck turned on, which is protective for the vast majority
-of Mech users who don't bother checking the return value of get()
-and post() and can't figure why their code fails. However, if
-L<WWW::Mechanize> is subclassed, such as for L<Test::WWW::Mechanize>
-or L<Test::WWW::Mechanize::Catalyst>, this may not be an appropriate
-default, so it's off.
+of Mech users who don't bother checking the return value of
+C<L<< get()|/"$mech->get( $uri )" >>>
+and C<L<< post()|/"$mech->post( $uri, content => $content )" >>> and can't
+figure why their code fails. However, if L<WWW::Mechanize> is subclassed, such
+as for L<Test::WWW::Mechanize> or L<Test::WWW::Mechanize::Catalyst>, this may
+not be an appropriate default, so it's off.
 
 =item * C<< noproxy => [0|1] >>
 
@@ -2656,6 +2657,28 @@ sub quiet {
     return $self->{quiet};
 }
 
+=head2 $mech->autocheck(true/false)
+
+Allows you to enable and disable autochecking.
+
+Autocheck checks each request made to see if it was successful. This saves you
+the trouble of manually checking yourself. Any errors found are errors, not
+warnings. Please see C<L<< new|/"new()" >>> for more details.
+
+    $mech->autocheck(1); # turns on automatic request checking (the default)
+    $mech->autocheck(0); # turns off automatic request checking
+    $mech->autocheck();  # returns the current autocheck status
+
+=cut
+
+sub autocheck {
+    my $self = shift;
+
+    $self->{autocheck} = $_[0] if @_;
+
+    return $self->{autocheck};
+}
+
 =head2 $mech->stack_depth( $max_depth )
 
 Get or set the page stack depth. Use this if you're doing a lot of page

t/autocheck.t

@@ -10,17 +10,33 @@ use WWW::Mechanize ();
 my $bad_url = "file:///foo.foo.xx.random";
 
 AUTOCHECK_OFF: {
-    my $mech = WWW::Mechanize->new( autocheck => 0 );
-    $mech->get( $bad_url );
-    ok( !$mech->success, qq{Didn't fetch $bad_url, but didn't die, either} );
+  my $mech = WWW::Mechanize->new( autocheck => 0 );
+  ok( !$mech->autocheck, q{Autocheck is set to off via new()} );
+
+  $mech->get($bad_url);
+  ok( !$mech->success, qq{Didn't fetch $bad_url, but didn't die, either} );
+
+  $mech->autocheck(1);
+  ok( $mech->autocheck, q{Autocheck is now on} );
+  like( exception { $mech->get($bad_url) },
+        qr/Error GETing/,
+        qq{... and couldn't fetch $bad_url, and died as a result} );
 }
 
 AUTOCHECK_ON: {
-    like(
-        exception { WWW::Mechanize->new->get($bad_url) },
+  my $mech = WWW::Mechanize->new;
+  ok( $mech->autocheck, q{Autocheck is on by default} );
+
+  like( exception { $mech->get($bad_url) },
         qr/Error GETing/,
-        qq{Couldn't fetch $bad_url, and died as a result}
-    );
+        qq{Couldn't fetch $bad_url, and died as a result} );
+
+  $mech->autocheck(0);
+  ok( !$mech->autocheck, q{Autocheck is now off} );
+
+  $mech->get($bad_url);
+  ok( !$mech->success,
+      qq{... and didn't fetch $bad_url, but didn't die, either} );
 }
 
 done_testing();