allow setting number in select #76

Author: simbabque

Changes

@@ -4,8 +4,10 @@ Revision history for WWW::Mechanize
     [ENHANCEMENTS]
     - WWW::Mechanize no longer taints the responses it receives.  This also
     removes Test::Taint as a prerequisite.
+    - select() now accepts a number argument to specify which instance of an
+      element with multiple occurrences to use (GH#189) (Julien Fiegehenn)
     [DOCUMENTATION]
-    - Improve FAQ (GH#189) (Julien Fiegehenn)
+    - Improve FAQ (GH#76) (Julien Fiegehenn)
 
 2.19      2024-09-16 15:25:45Z
     [DOCUMENTATION]

lib/WWW/Mechanize.pm

@@ -2057,6 +2057,8 @@ sub field {
 
 =head2 $mech->select($name, $new_or_additional_single_value)
 
+=head2 $mech->select($name, $new_or_additional_single_value, $number)
+
 =head2 $mech->select($name, \%new_single_value_by_number)
 
 =head2 $mech->select($name, \@new_list_of_values)
@@ -2069,6 +2071,13 @@ specified.
     # select 'foo'
     $mech->select($name, 'foo');
 
+The optional C<$number> parameter is used to distinguish between two fields
+with the same name.  The fields are numbered from 1. Note that this only works
+for selecting simple values, not for selecting multiple values as once.
+
+    # select the second field with the name 'foo'
+    $mech->select($name, 'foo', 2);
+
 If the field is not C<< <select multiple> >> and the
 C<$value> is an array reference, only the B<first> value will be set.  [Note:
 until version 1.05_03 the documentation claimed that only the last value would
@@ -2117,11 +2126,12 @@ false and calls C<< $self->warn() >> with an error message.
 =cut
 
 sub select {
-    my ( $self, $name, $value ) = @_;
+    my ( $self, $name, $value, $number ) = @_;
+    $number ||= 1;
 
     my $form = $self->current_form();
 
-    my $input = $form->find_input($name);
+    my $input = $form->find_input( $name, undef, $number );
     if ( !$input ) {
         $self->warn(qq{Input "$name" not found});
         return;
@@ -2188,7 +2198,7 @@ sub select {
         return 1;
     }
 
-    $form->value( $name => $value );
+    $form->find_input( $name, undef, $number )->value($value);
     return 1;
 }
 

t/select.html

@@ -17,6 +17,17 @@
 <option value="ccc">ccc</a>
 <option value="ddd">ddd</a>
 </select>
+
+<select name="exists_twice">
+    <option value="one">one</option>
+    <option value="two">two</option>
+</select>
+
+<select name="exists_twice">
+    <option value="three">three</option>
+    <option value="four">four</option>
+</select>
+
 </FORM>
 </BODY>
 </HTML>

t/select.t

@@ -99,4 +99,22 @@ like warning { $rv = $mech->select( 'missing_list', 1 ) }, qr/not found/,
     'warning when field is not found';
 is( $rv, undef, 'return undef after failed select' );
 
+# test setting a number
+$mech->select( 'exists_twice', 'two',  1 );
+$mech->select( 'exists_twice', 'four', 2 );
+@return = $form->param('exists_twice');
+is_deeply(
+    \@return, [ 'two', 'four' ],
+    'select exists twice, set both and values are ' . join( ' ', @return )
+);
+
+$mech->select( 'exists_twice', 'one', 1 );
+$mech->select( 'exists_twice', 'one', 2 );
+@return = $form->param('exists_twice');
+is_deeply(
+    \@return, [ 'one', 'one' ],
+    'select exists twice, set to double values and they are '
+        . join( ' ', @return )
+);
+
 done_testing;