tutor supports variants

but not opening metrics since variant have no named openings

Author: ornicar

modules/insight/src/main/PovToEntry.scala

@@ -208,9 +208,8 @@ final private class PovToEntry(
     )
 
   private def findOpening(from: RichPov): Option[SimpleOpening] =
-    from.pov.game.variant.standard.so(
+    from.pov.game.variant.standard.so:
       OpeningDb
         .searchInPositions(from.boards)
         .map(_.opening)
         .flatMap(SimpleOpening.apply)
-    )

modules/tutor/src/main/TutorBuilder.scala

@@ -61,7 +61,7 @@ final private class TutorBuilder(
   yield TutorFullReport(config, nowInstant, perfs)
 
   private[tutor] def eligiblePerfKeysOf(user: UserWithPerfs): List[PerfKey] =
-    lila.rating.PerfType.standardWithUltra.filter: pt =>
+    supportedPerfs.filter: pt =>
       val perf = user.perfs(pt)
       perf.nb >= 30 && perf.latest.exists(_.isAfter(lila.insight.minDate))
 

modules/tutor/src/main/TutorPerfReport.scala

@@ -24,6 +24,9 @@ case class TutorPerfReport(
     pieces: TutorPieces,
     flagging: TutorFlagging
 ):
+
+  def variant = lila.rating.PerfType.variantOf(perf)
+
   lazy val estimateTotalTime: Option[FiniteDuration] =
     (perf != PerfType.Correspondence).option(stats.time * 2)
 

modules/tutor/src/main/package.scala

@@ -9,6 +9,8 @@ export lila.common.extensions.*
 
 private val logger = lila.log("tutor")
 
+private val supportedPerfs = lila.rating.PerfType.standardWithUltra ::: lila.rating.PerfType.variants
+
 private given Ordering[lila.analyse.AccuracyPercent] = doubleOrdering
 private given Ordering[ClockPercent] = doubleOrdering
 private given Ordering[IntRating] = intOrdering

modules/tutor/src/main/ui/TutorPerfUi.scala

@@ -45,8 +45,12 @@ final class TutorPerfUi(helpers: Helpers, bits: TutorBits):
             frag(report.perf.trans, " openings"),
             full.url.angle(report.perf, "opening").some
           )(
-            selectFourOpenings(report).map: (color, fam) =>
-              grade.peerGrade(concept.opening(fam.family, color), fam.mix, h4)
+            cls := (if report.variant.exotic then "tutor__perf__angle--na" else ""),
+            if report.variant.exotic
+            then "Not applicable to variants"
+            else
+              selectFourOpenings(report).map: (color, fam) =>
+                grade.peerGrade(concept.opening(fam.family, color), fam.mix, h4)
           ),
           angleCard(
             frag(report.perf.trans, " time management"),

ui/tutor/css/_angles.scss

@@ -1,9 +1,19 @@
-.tutor__perf__angle--pieces {
-  @media (min-width: at-least($medium)) {
-    grid-column: span 2;
+.tutor__perf__angle {
+  @extend %flex-column;
+  &--pieces {
+    @media (min-width: at-least($medium)) {
+      grid-column: span 2;
+    }
+    .tutor-grades {
+      display: grid;
+      grid-template-columns: repeat(2, 1fr);
+    }
   }
   .tutor-grades {
-    display: grid;
-    grid-template-columns: repeat(2, 1fr);
+    flex: 1 1 100%;
+  }
+  &--na {
+    @extend %flex-center-center;
+    color: $c-font-dim;
   }
 }