Might want to lock stuff here?

[iProgramMC]

lidgren-network-gen3/Lidgren.Network/NetPeer.cs

Line 96 in f99b006

get { return m_connections.Count; }

Might want to put this in lock brackets, like when getting Connections

[PJB3005]

While it's perhaps not 100% kosher, reading integers is atomic in C# so with CoreCLR's current List<T> implementation there shouldn't actually be any chance of getting any threading bugs on this.

[iProgramMC]

That sounds perfect! I didn't know, thanks

…

On Mon, Feb 22, 2021, 21:00 Pieter-Jan Briers ***@***.***> wrote: While it's perhaps not 100% kosher, reading integers is atomic in C# so with CoreCLR's current List<T> implementation there shouldn't actually be any chance of getting any threading bugs on this. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#151 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEHFR5SLEI37BVHIHJC2SD3TAKSTZANCNFSM4YAHNVWA> .