feat(orc-458): set-limits tw command added

Author: chasingrainbows

programs/exit-bus-oracle.ts

@@ -536,3 +536,58 @@ oracle
       logger.error('Failed to trigger validator exits:', error);
     }
   });
+
+oracle
+  .command('set-limits')
+  .description('Set exit request limits on VEB contract')
+  .option('--max-exit-requests-limit <limit>', 'Maximum exit requests limit')
+  .option('--exits-per-frame <exits>', 'Number of exits per frame')
+  .option('--frame-duration <duration>', 'Frame duration in seconds')
+  .action(async (options) => {
+    const { maxExitRequestsLimit, exitsPerFrame, frameDuration } = options;
+
+    if (!maxExitRequestsLimit || !exitsPerFrame || !frameDuration) {
+      logger.error('All parameters are required: --max-exit-requests-limit, --exits-per-frame, --frame-duration');
+      logger.log('Example usage:');
+      logger.log('  ./run.sh vebo set-limits --max-exit-requests-limit 11200 --exits-per-frame 1 --frame-duration 48');
+      return;
+    }
+
+    try {
+      const maxLimit = parseInt(maxExitRequestsLimit, 10);
+      const exitsCount = parseInt(exitsPerFrame, 10);
+      const durationSec = parseInt(frameDuration, 10);
+
+      if (isNaN(maxLimit) || isNaN(exitsCount) || isNaN(durationSec)) {
+        logger.error('All parameters must be valid numbers');
+        return;
+      }
+
+      if (maxLimit <= 0 || exitsCount <= 0 || durationSec <= 0) {
+        logger.error('All parameters must be positive numbers');
+        return;
+      }
+
+      logger.log('Setting exit request limits on VEB contract...');
+      logger.log('Parameters:');
+      logger.log(`  Max Exit Requests Limit: ${maxLimit}`);
+      logger.log(`  Exits Per Frame: ${exitsCount}`);
+      logger.log(`  Frame Duration: ${durationSec} seconds`);
+      logger.log('Contract address:', exitBusOracleContract.target);
+
+      const tx = await exitBusOracleContract.setExitRequestLimit(maxLimit, exitsCount, durationSec);
+      logger.log('Transaction hash:', tx.hash);
+
+      logger.log('Waiting for transaction confirmation...');
+      const receipt = await tx.wait();
+
+      if (receipt.status === 1) {
+        logger.log('Exit request limits set successfully!');
+        logger.log('Transaction confirmed in block:', receipt.blockNumber);
+      } else {
+        logger.error('Transaction failed');
+      }
+    } catch (error) {
+      logger.error('Failed to set exit request limits:', error);
+    }
+  });

tests/test-tw-commands.sh

@@ -139,6 +139,7 @@ setup_test_permissions() {
     local TEST_ACCOUNT="0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266"
     local ADMIN_ACCOUNT="0x0534aA41907c9631fae990960bCC72d75fA7cfeD"
     local SUBMITTER_ROLE="0x22ebb4dbafb72948800c1e1afa1688772a1a4cfc54d5ebfcec8163b1139c082e"
+    local EXIT_REQUEST_LIMIT_MANAGER_ROLE="0x9c616dd118785b2e2fccf45a4ff151a335ff7b6a84cd1c4d7fd9f97f39ea9342"
 
     print_status "Impersonating Aragon Agent and granting role..."
 
@@ -147,19 +148,32 @@ setup_test_permissions() {
         -d "{\"jsonrpc\":\"2.0\",\"method\":\"anvil_impersonateAccount\",\"params\":[\"$ADMIN_ACCOUNT\"],\"id\":1}" \
         http://localhost:$ANVIL_PORT >/dev/null
 
-    # Give it ETH
+    # Give ETH to admin account (100 ETH)
     curl -s -X POST -H "Content-Type: application/json" \
-        -d "{\"jsonrpc\":\"2.0\",\"method\":\"anvil_setBalance\",\"params\":[\"$ADMIN_ACCOUNT\",\"0x21E19E0C9BAB2400000\"],\"id\":1}" \
+        -d "{\"jsonrpc\":\"2.0\",\"method\":\"anvil_setBalance\",\"params\":[\"$ADMIN_ACCOUNT\",\"0x56BC75E2D630E0000\"],\"id\":1}" \
         http://localhost:$ANVIL_PORT >/dev/null
 
-    # Grant role using cast
+    # Give ETH to test account (1000 ETH to ensure enough for all tests)
+    curl -s -X POST -H "Content-Type: application/json" \
+        -d "{\"jsonrpc\":\"2.0\",\"method\":\"anvil_setBalance\",\"params\":[\"$TEST_ACCOUNT\",\"0x3635C9ADC5DEA00000\"],\"id\":1}" \
+        http://localhost:$ANVIL_PORT >/dev/null
+
+    # Grant submitter role using cast
     print_status "Granting submitter role to test account..."
     ETH_FROM=$ADMIN_ACCOUNT cast send $VEBO_CONTRACT "grantRole(bytes32,address)" \
         $SUBMITTER_ROLE $TEST_ACCOUNT \
         --rpc-url http://localhost:$ANVIL_PORT \
         --unlocked \
         --gas-limit 200000 >/dev/null 2>&1
 
+    # Grant limit manager role using cast
+    print_status "Granting exit request limit manager role to test account..."
+    ETH_FROM=$ADMIN_ACCOUNT cast send $VEBO_CONTRACT "grantRole(bytes32,address)" \
+        $EXIT_REQUEST_LIMIT_MANAGER_ROLE $TEST_ACCOUNT \
+        --rpc-url http://localhost:$ANVIL_PORT \
+        --unlocked \
+        --gas-limit 200000 >/dev/null 2>&1
+
     print_success "Test permissions setup completed"
     sleep 1
 }
@@ -195,7 +209,7 @@ run_test_command() {
     local has_errors=false
     if [ $exit_code -ne 0 ]; then
         has_errors=true
-    elif grep -q "RPC request failed\|execution reverted\|Transaction failed\|Failed to submit\|Error:" "$temp_output"; then
+    elif grep -q "RPC request failed\|execution reverted\|Transaction failed\|Failed to submit\|Error:\|Insufficient funds\|insufficient funds" "$temp_output"; then
         has_errors=true
     fi
 
@@ -238,6 +252,19 @@ run_tests() {
     run_test_command "Trigger exit with submitted data" \
         "../run.sh vebo trigger-exit --calldata 0x000001000000000f00000000000030391234567890abcdef1234567890abcdef1234567890abcdef1234567890abcdef1234567890abcdef1234567890abcdef --format 1 --value 0.001"
 
+    # Test 4: Test set-limits command with valid parameters
+    print_status "Testing set-limits with valid parameters..."
+    print_status "Note: This test sets new exit request limits on the VEB contract"
+
+    # Ensure test account has enough ETH for this expensive transaction
+    print_status "Ensuring sufficient ETH balance for set-limits test..."
+    curl -s -X POST -H "Content-Type: application/json" \
+        -d "{\"jsonrpc\":\"2.0\",\"method\":\"anvil_setBalance\",\"params\":[\"0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266\",\"0x3635C9ADC5DEA00000\"],\"id\":1}" \
+        http://localhost:$ANVIL_PORT >/dev/null
+
+    run_test_command "Set exit request limits" \
+        "../run.sh vebo set-limits --max-exit-requests-limit 11200 --exits-per-frame 1 --frame-duration 48"
+
     print_status "Test suite completed"
 }