Merge pull request #584 from lidofinance/feat/v3-phase-2-ci

feat: Lido V3 CI tests

Author: failingtwice

configs/config_mainnet.py

@@ -182,8 +182,8 @@
 CS_MODULE_NAME = "Community Staking"
 CS_MODULE_MODULE_FEE_BP = 600
 CS_MODULE_TREASURY_FEE_BP = 400
-CS_MODULE_TARGET_SHARE_BP = 500
-CS_MODULE_PRIORITY_EXIT_SHARE_THRESHOLD = 625
+CS_MODULE_TARGET_SHARE_BP = 750
+CS_MODULE_PRIORITY_EXIT_SHARE_THRESHOLD = 900
 CS_MODULE_MAX_DEPOSITS_PER_BLOCK = 30
 CS_MODULE_MIN_DEPOSIT_BLOCK_DISTANCE = 25
 
@@ -407,6 +407,7 @@
 CS_PERMISSIONLESS_GATE_ADDRESS = "0xcF33a38111d0B1246A3F38a838fb41D626B454f0"
 CS_VERIFIER_V2_ADDRESS = "0xdC5FE1782B6943f318E05230d688713a560063DC"
 CS_GATE_SEAL_V2_ADDRESS = "0xE1686C2E90eb41a48356c1cC7FaA17629af3ADB3"
+TWO_PHASE_FRAME_CONFIG_UPDATE = "0xb2B4DB1491cbe949ae85EfF01E0d3ee239f110C1"
 
 # DualGovernance
 DUAL_GOVERNANCE = "0xC1db28B3301331277e307FDCfF8DE28242A4486E"
@@ -530,7 +531,7 @@
 OPERATOR_GRID = "0xC69685E89Cefc327b43B7234AC646451B27c544d"
 LAZY_ORACLE = "0x5DB427080200c235F2Ae8Cd17A7be87921f7AD6c"
 PREDEPOSIT_GUARANTEE = "0xF4bF42c6D6A0E38825785048124DBAD6c9eaaac3"
-VAULTS_ADAPTER = "0xe2DE6d2DefF15588a71849c0429101F8ca9FB14D"
+VAULTS_ADAPTER = "0x28F9Ac198C4E0FA6A9Ad2c2f97CB38F1A3120f27"
 GATE_SEAL_V3 = "0x881dAd714679A6FeaA636446A0499101375A365c"
 STAKING_VAULT_BEACON = "0x5FbE8cEf9CCc56ad245736D3C5bAf82ad54Ca789"
 

tests/regression/test_gate_seal.py

@@ -357,10 +357,6 @@ def test_gate_seal_v3_vaults_scenario(gate_seal_committee):
 
     pause_duration = gate_seal_v3.get_seal_duration_seconds()
 
-    # TODO remove this after PDG unpause
-    reseal_manager_account = accounts.at(RESEAL_MANAGER, force=True)
-    contracts.predeposit_guarantee.resume({"from": reseal_manager_account})
-
     assert not contracts.vault_hub.isPaused()
     assert not contracts.predeposit_guarantee.isPaused()
 

tests/regression/test_permissions.py

@@ -72,7 +72,8 @@
     VAULTS_ADAPTER,
     GATE_SEAL_V3,
     L1_TOKEN_RATE_NOTIFIER,
-    STAKING_VAULT_BEACON
+    STAKING_VAULT_BEACON,
+    TWO_PHASE_FRAME_CONFIG_UPDATE
 )
 
 
@@ -399,7 +400,7 @@ def protocol_permissions():
                 "DEFAULT_ADMIN_ROLE": [contracts.agent],
                 "MANAGE_MEMBERS_AND_QUORUM_ROLE": [contracts.agent],
                 "DISABLE_CONSENSUS_ROLE": [],
-                "MANAGE_FRAME_CONFIG_ROLE": [],
+                "MANAGE_FRAME_CONFIG_ROLE": [TWO_PHASE_FRAME_CONFIG_UPDATE],
                 "MANAGE_FAST_LANE_CONFIG_ROLE": [],
                 "MANAGE_REPORT_PROCESSOR_ROLE": [],
             },

tests/snapshot/test_lido_snapshot.py

@@ -6,6 +6,7 @@
 import pytest
 from brownie import ZERO_ADDRESS, chain, web3, accounts
 from brownie.network.account import Account
+from hexbytes import HexBytes
 from pytest_check import check
 from web3.types import Wei
 
@@ -36,6 +37,11 @@ class Frame(TypedDict):
 
 
 EXPECTED_SNAPSHOT_DIFFS: dict[str, Any] = {
+    # Max external ratio is changed from 3% (300 BP) to 30% (3000 BP) in the upgrade
+    "lido.Lido.lidoLocatorAndMaxExternalRatio": (
+        HexBytes("0x00000000000000000000012cc1d0b3de6792bf6b4b37eccdcc24e45978cfd2eb"),
+        HexBytes("0x000000000000000000000bb8c1d0b3de6792bf6b4b37eccdcc24e45978cfd2eb"),
+    ),
 }
 
 
@@ -417,36 +423,43 @@ def _actions_snaps(builder_arg: Account | None):
                     func=repr(action_fn),
                 )
 
-        contracts.acl.grantPermission(
-            contracts.agent,
-            contracts.lido,
-            contracts.lido.PAUSE_ROLE(),
-            {"from": contracts.agent},
-        )
-        contracts.acl.grantPermission(
-            contracts.agent,
-            contracts.lido,
-            contracts.lido.RESUME_ROLE(),
-            {"from": contracts.agent},
-        )
-        contracts.acl.grantPermission(
-            contracts.agent,
-            contracts.lido,
-            contracts.lido.STAKING_PAUSE_ROLE(),
-            {"from": contracts.agent},
-        )
-        contracts.acl.grantPermission(
-            contracts.agent,
-            contracts.lido,
-            contracts.lido.STAKING_CONTROL_ROLE(),
-            {"from": contracts.agent},
-        )
+        def _grant_lido_permissions():
+            """Grant necessary permissions to agent for Lido operations"""
+            contracts.acl.grantPermission(
+                contracts.agent,
+                contracts.lido,
+                contracts.lido.PAUSE_ROLE(),
+                {"from": contracts.agent},
+            )
+            contracts.acl.grantPermission(
+                contracts.agent,
+                contracts.lido,
+                contracts.lido.RESUME_ROLE(),
+                {"from": contracts.agent},
+            )
+            contracts.acl.grantPermission(
+                contracts.agent,
+                contracts.lido,
+                contracts.lido.STAKING_PAUSE_ROLE(),
+                {"from": contracts.agent},
+            )
+            contracts.acl.grantPermission(
+                contracts.agent,
+                contracts.lido,
+                contracts.lido.STAKING_CONTROL_ROLE(),
+                {"from": contracts.agent},
+            )
+
+        _grant_lido_permissions()
 
         with _chain_snapshot():
             v1_frames = tuple(_actions_snaps(contracts.agent))
 
         execute_vote_and_process_dg_proposals(helpers, vote_ids_from_env, dg_proposal_ids_from_env)
 
+        # Re-grant permissions after upgrade as some may have been revoked
+        _grant_lido_permissions()
+
         v2_frames = tuple(_actions_snaps(contracts.agent))
 
         return v1_frames, v2_frames