small fixes

Author: iamnp

scripts/vote_2026_01_26_hoodi.py

@@ -1,7 +1,7 @@
 """
 Voting 26/01/2026. Hoodi network.
 
-1. Grant MANAGE_SIGNING_KEYS role for operator 0x031624fAD4E9BFC2524e7a87336C4b190E70BCA8 to 0xc8195bb2851d7129D9100af9d65Bd448A6dE11eF on Hoodi
+1. Grant MANAGE_SIGNING_KEYS role for operator ID = 1 to 0xc8195bb2851d7129D9100af9d65Bd448A6dE11eF on Hoodi
 
 # TODO (after vote) Vote #{vote number} passed & executed on ${date+time}, block ${blockNumber}.
 """
@@ -23,15 +23,15 @@
 
 
 # ============================= Description ==================================
-IPFS_DESCRIPTION = "Grant MANAGE_SIGNING_KEYS role for operator 0x031624fAD4E9BFC2524e7a87336C4b190E70BCA8 to 0xc8195bb2851d7129D9100af9d65Bd448A6dE11eF on Hoodi"
+IPFS_DESCRIPTION = "Grant MANAGE_SIGNING_KEYS role for operator ID = 1 to 0xc8195bb2851d7129D9100af9d65Bd448A6dE11eF on Hoodi"
 
 
 def get_vote_items() -> Tuple[List[str], List[Tuple[str, str]]]:
     params = [Param(0, Op.EQ, ArgumentValue(OPERATOR_ID))]
 
     vote_desc_items, call_script_items = zip(
         (
-            "1. Grant MANAGE_SIGNING_KEYS role for operator 0x031624fAD4E9BFC2524e7a87336C4b190E70BCA8 to 0xc8195bb2851d7129D9100af9d65Bd448A6dE11eF on Hoodi",
+            "1. Grant MANAGE_SIGNING_KEYS role for operator ID = 1 to 0xc8195bb2851d7129D9100af9d65Bd448A6dE11eF on Hoodi",
             encode_permission_grant_p(
                 target_app=TARGET_NO_REGISTRY,
                 permission_name="MANAGE_SIGNING_KEYS",

tests/test_2026_01_26_hoodi.py

@@ -32,9 +32,11 @@
 IPFS_DESCRIPTION_HASH = "bafkreies4yycczkmfgwexirpnogbzlo7j262svtrwcj5k2x7ashyvhnaqm"
 
 
-def test_vote_acceptance(helpers, accounts, ldo_holder, vote_ids_from_env):
+def test_vote(helpers, accounts, ldo_holder, vote_ids_from_env):
     voting = interface.Voting(VOTING)
     no = interface.NodeOperatorsRegistry(TARGET_NO_REGISTRY)
+    perm_param = Param(0, Op.EQ, ArgumentValue(OPERATOR_ID))
+    perm_param_uint = perm_param.to_uint256()
 
     # =========================================================================
     # ======================== Identify or Create vote ========================
@@ -51,9 +53,6 @@ def test_vote_acceptance(helpers, accounts, ldo_holder, vote_ids_from_env):
     onchain_script = voting.getVote(vote_id)["script"]
     assert str(onchain_script).lower() == encode_call_script(call_script_items).lower()
 
-    perm_param = Param(0, Op.EQ, ArgumentValue(OPERATOR_ID))
-    perm_param_uint = perm_param.to_uint256()
-
     # =========================================================================
     # ============================= Execute Vote ==============================
     # =========================================================================
@@ -66,7 +65,7 @@ def test_vote_acceptance(helpers, accounts, ldo_holder, vote_ids_from_env):
         # Item 1
         assert no.getNodeOperator(OPERATOR_ID, True)["rewardAddress"] == EXPECTED_REWARD_ADDRESS
         assert not no.canPerform(NEW_MANAGER_ADDRESS, MANAGE_SIGNING_KEYS, [perm_param_uint])
-        # scenario reassurance tests
+        # scenario test
         add_signing_keys_fails_before_vote(accounts)
 
         assert get_lido_vote_cid_from_str(find_metadata_by_vote_id(vote_id)) == IPFS_DESCRIPTION_HASH
@@ -89,11 +88,30 @@ def test_vote_acceptance(helpers, accounts, ldo_holder, vote_ids_from_env):
         permission = Permission(entity=NEW_MANAGER_ADDRESS, app=no, role=MANAGE_SIGNING_KEYS)
         validate_permission_grantp_event(vote_events[0], permission, [perm_param], emitted_by=ACL)
 
-        # scenario happy path tests
+        # scenario tests
         manager_adds_signing_keys(accounts)
         add_signing_keys_to_notallowed_operator_fails(accounts)
 
 
+def add_signing_keys_fails_before_vote(accounts):
+    no = interface.SimpleDVT(TARGET_NO_REGISTRY)
+
+    manager = accounts.at(NEW_MANAGER_ADDRESS, force=True)
+    set_balance(manager, 10)
+
+    pubkeys = random_pubkeys_batch(1)
+    signatures = random_signatures_batch(1)
+
+    with reverts():
+        no.addSigningKeys(
+            OPERATOR_ID,
+            1,
+            pubkeys,
+            signatures,
+            {"from": manager},
+        )
+
+
 def manager_adds_signing_keys(accounts):
     no = interface.SimpleDVT(TARGET_NO_REGISTRY)
 
@@ -116,25 +134,6 @@ def manager_adds_signing_keys(accounts):
     assert total_keys_after == total_keys_before + 1
 
 
-def add_signing_keys_fails_before_vote(accounts):
-    no = interface.SimpleDVT(TARGET_NO_REGISTRY)
-
-    manager = accounts.at(NEW_MANAGER_ADDRESS, force=True)
-    set_balance(manager, 10)
-
-    pubkeys = random_pubkeys_batch(1)
-    signatures = random_signatures_batch(1)
-
-    with reverts():
-        no.addSigningKeys(
-            OPERATOR_ID,
-            1,
-            pubkeys,
-            signatures,
-            {"from": manager},
-        )
-
-
 def add_signing_keys_to_notallowed_operator_fails(accounts):
     no = interface.SimpleDVT(TARGET_NO_REGISTRY)