fixed up titles and some bad assumptions about errors prop

Author: yankeeinlondon

dist/wait-in-parallel.cjs.js

@@ -38,12 +38,13 @@
     "@types/chance": "^1.0.0",
     "@types/faker": "^4.1.2",
     "@types/handlebars": "^4.0.37",
+    "@types/inquirer": "^0.0.41",
     "@types/js-yaml": "^3.11.1",
     "@types/lodash": "^4.14.108",
+    "@types/lodash.first": "^3.0.5",
     "@types/mocha": "^5.2.0",
     "@types/node": "^8.10.0",
     "@types/rimraf": "^2.0.2",
-    "@types/inquirer": "^0.0.41",
     "async-shelljs": "^0.1.2",
     "bili": "^3.1.0",
     "chai": "^4.1.2",

dist/wait-in-parallel.es.js

@@ -1,5 +1,13 @@
 import { IDictionary } from "common-types";
 import { Parallel } from "./index";
+const first = require("lodash.first");
+
+/**
+ * The first key in a Hash/Dictionary
+ */
+function firstKey<T = any>(dictionary: IDictionary<T>) {
+  return first(Object.keys(dictionary));
+}
 
 export class ParallelError<T = any> extends Error {
   name = "ParallelError";
@@ -59,7 +67,9 @@ export class ParallelError<T = any> extends Error {
         };
 
         return errors[f].name === "ParallelError"
-          ? `\n  - ${f} [ParallelError { ${inspect(errors[f] as ParallelError)} }]`
+          ? `\n  - ${f} [ParallelError ${context.title ? context.title : ""} { ${inspect(
+              errors[f] as ParallelError
+            )} }]`
           : `\n  - ${f} [${
               errors[f].code ? `${errors[f].name}:${errors[f].code}` : errors[f].name
             } ${getFirstErrorLocation(errors[f].stack)}]`;
@@ -69,9 +79,11 @@ export class ParallelError<T = any> extends Error {
     this.message = `${context.title ? context.title + ": " : ""}${
       context._get("failed").length
     } of ${failed.length +
-      successful.length} parallel tasks failed.\nTasks failing were: ${errorSummary}.\n\nFirst error message was: ${
-      errors[0].message
-    }`;
+      successful.length} parallel tasks failed.\nTasks failing were: ${errorSummary}."`;
+    this.message +=
+      Object.keys(errors).length > 0
+        ? `\n\nFirst error message was: ${(this, errors[firstKey(errors)].message)}`
+        : "";
     this.errors = errors;
     this.failed = failed;
     this.successful = successful;

package.json

@@ -1,5 +1,5 @@
 // tslint:disable:no-implicit-dependencies
-import Parallel, { IParallelFailureNotification } from "../src/index";
+import { Parallel, IParallelFailureNotification } from "../src/index";
 import * as chai from "chai";
 import { wait } from "common-types";
 import * as helpers from "./testing/helpers";
@@ -39,7 +39,7 @@ describe("Basics →", () => {
   });
 
   it("using get() utility function for invalid property throws error", async () => {
-    const obj = Parallel.create();
+    const obj = Parallel.create("test title");
     try {
       obj._get("foobar");
       throw new Error("Foobar is not a valid get property");
@@ -127,21 +127,23 @@ describe("Basics →", () => {
     };
 
     const masterError = async () => {
-      const p = Parallel.create()
+      const p = Parallel.create("Master Error")
         .add("f3", f3)
         .add("f4", f4);
       await p.isDone();
     };
 
     try {
-      const p = Parallel.create()
+      const p = Parallel.create("Nested Errors")
         .add("success", s1)
         .add("fail1", f1)
         .add("fail2", f2)
         .add("fail4", masterError);
       await p.isDone();
       throw new Error("Error should have been thrown");
     } catch (e) {
+      console.log(e);
+
       expect(e.message).to.include("fail1 [FictitiousError @");
       expect(e.message).to.include("fail4 [ParallelError { f3");
     }

src/ParallelError.ts

@@ -1,5 +1,5 @@
 // tslint:disable:no-implicit-dependencies
-import Parallel, { IParallelFailureNotification } from "../src/index";
+import { Parallel, IParallelFailureNotification } from "../src/index";
 import * as chai from "chai";
 import { wait } from "common-types";
 import * as helpers from "./testing/helpers";

test/basics-spec.ts

@@ -1,5 +1,5 @@
 // tslint:disable:no-implicit-dependencies
-import Parallel, { IParallelFailureNotification } from "../src/index";
+import { Parallel, IParallelFailureNotification } from "../src/index";
 import * as chai from "chai";
 import { wait } from "common-types";
 import { ParallelError } from "../src/ParallelError";

test/done-as-array-spec.ts

@@ -1,5 +1,5 @@
 // tslint:disable:no-implicit-dependencies
-import Parallel, { IParallelFailureNotification } from "../src/index";
+import { Parallel, IParallelFailureNotification } from "../src/index";
 import * as chai from "chai";
 import { wait } from "common-types";
 import { ParallelError } from "../src/ParallelError";

test/fail-fast-spec.ts

@@ -1,5 +1,5 @@
 // tslint:disable:no-implicit-dependencies
-import Parallel, { IParallelFailureNotification } from "../src/index";
+import { Parallel, IParallelFailureNotification } from "../src/index";
 import * as chai from "chai";
 import { wait } from "common-types";
 import { ParallelError } from "../src/ParallelError";

test/fail-slow-spec.ts

@@ -633,6 +633,18 @@
   version "3.11.1"
   resolved "https://registry.yarnpkg.com/@types/js-yaml/-/js-yaml-3.11.1.tgz#ac5bab26be5f9c6f74b6b23420f2cfa5a7a6ba40"
 
+"@types/lodash.first@^3.0.5":
+  version "3.0.5"
+  resolved "https://registry.yarnpkg.com/@types/lodash.first/-/lodash.first-3.0.5.tgz#e6446422d480272af77a374dd4139548c3f7ce4d"
+  integrity sha512-I4a7KdfXAeD+l3T9IYlIRUCYEIhoWE4BttoHBpOcw6tJPXGsJTBBEljce4c0UZgkAiEDym9XEIsgiD/puXGTCw==
+  dependencies:
+    "@types/lodash" "*"
+
+"@types/lodash@*":
+  version "4.14.121"
+  resolved "https://registry.yarnpkg.com/@types/lodash/-/lodash-4.14.121.tgz#9327e20d49b95fc2bf983fc2f045b2c6effc80b9"
+  integrity sha512-ORj7IBWj13iYufXt/VXrCNMbUuCTJfhzme5kx9U/UtcIPdJYuvPDUAlHlbNhz/8lKCLy9XGIZnGrqXOtQbPGoQ==
+
 "@types/lodash@^4.14.108":
   version "4.14.109"
   resolved "https://registry.yarnpkg.com/@types/lodash/-/lodash-4.14.109.tgz#b1c4442239730bf35cabaf493c772b18c045886d"
@@ -1466,10 +1478,15 @@ commander@~2.13.0:
   version "2.13.0"
   resolved "https://registry.yarnpkg.com/commander/-/commander-2.13.0.tgz#6964bca67685df7c1f1430c584f07d7597885b9c"
 
-common-types@^1.1.0, common-types@^1.7.21:
+common-types@^1.1.0:
   version "1.7.33"
   resolved "https://registry.yarnpkg.com/common-types/-/common-types-1.7.33.tgz#efa03d07d39aa22ed6fdc1452cd5011ce033402e"
 
+common-types@^1.9.6s:
+  version "1.9.6"
+  resolved "https://registry.yarnpkg.com/common-types/-/common-types-1.9.6.tgz#ec94d6466e4bd2876fb734297d7f8abf665f4aa3"
+  integrity sha512-JyMYuxDJgrhgqBh1D+A0C7ghCiVw+vxrxwNt/FcgoMhGzh/KqX8vOVwQBA6no5onsXAYcepAwUxrYYjpvrBChA==
+
 commondir@^1.0.1:
   version "1.0.1"
   resolved "https://registry.yarnpkg.com/commondir/-/commondir-1.0.1.tgz#ddd800da0c66127393cca5950ea968a3aaf1253b"
@@ -2693,6 +2710,7 @@ locate-path@^2.0.0:
 lodash.first@^3.0.0:
   version "3.0.0"
   resolved "https://registry.yarnpkg.com/lodash.first/-/lodash.first-3.0.0.tgz#5dae180d7f818ee65fc5b210b104a7bbef98a16a"
+  integrity sha1-Xa4YDX+BjuZfxbIQsQSnu++YoWo=
 
 lodash.last@^3.0.0:
   version "3.0.0"