Skip to content

Commit 954ffc2

Browse files
annasuszterdrewbrokke
authored andcommitted
LPD-56478 remove usages of VersionUtil class
1 parent 15cc7a8 commit 954ffc2

File tree

3 files changed

+11
-16
lines changed

3 files changed

+11
-16
lines changed

tools/plugins/com.liferay.ide.core/src/com/liferay/ide/core/workspace/LiferayWorkspaceUtil.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import com.liferay.ide.core.util.FileUtil;
2424
import com.liferay.ide.core.util.PropertiesUtil;
2525
import com.liferay.ide.core.util.ReleaseUtil;
26-
import com.liferay.ide.core.util.VersionUtil;
2726
import com.liferay.release.util.ReleaseEntry;
2827

2928
import java.io.File;
@@ -230,12 +229,11 @@ public static String getLiferayWorkspaceProjectVersion() {
230229
return null;
231230
}
232231

233-
String simplifiedTargetPlatformVersion = VersionUtil.simplifyTargetPlatformVersion(
234-
liferayWorkspaceProject.getTargetPlatformVersion());
232+
String targetPlatformVersion = liferayWorkspaceProject.getTargetPlatformVersion();
235233

236-
if (CoreUtil.isNotNullOrEmpty(simplifiedTargetPlatformVersion)) {
234+
if (CoreUtil.isNotNullOrEmpty(targetPlatformVersion)) {
237235
try {
238-
ReleaseEntry releaseEntry = ReleaseUtil.getReleaseEntry(simplifiedTargetPlatformVersion);
236+
ReleaseEntry releaseEntry = ReleaseUtil.getReleaseEntry(targetPlatformVersion);
239237

240238
return releaseEntry.getProductGroupVersion();
241239
}

tools/plugins/com.liferay.ide.project.core/src/com/liferay/ide/project/core/modules/fragment/LiferayRuntimeNameValidationService.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import com.liferay.ide.core.IWorkspaceProject;
1818
import com.liferay.ide.core.util.CoreUtil;
1919
import com.liferay.ide.core.util.SapphireContentAccessor;
20-
import com.liferay.ide.core.util.VersionUtil;
2120
import com.liferay.ide.core.workspace.LiferayWorkspaceUtil;
2221
import com.liferay.ide.server.core.portal.PortalRuntime;
2322
import com.liferay.ide.server.util.ServerUtil;
@@ -65,8 +64,7 @@ protected Status compute() {
6564
"make it point to an existing runtime.");
6665
}
6766

68-
String targetPlatformVersion = VersionUtil.simplifyTargetPlatformVersion(
69-
liferayWorkspaceProject.getTargetPlatformVersion());
67+
String targetPlatformVersion = liferayWorkspaceProject.getTargetPlatformVersion();
7068

7169
if (Objects.nonNull(targetPlatformVersion)) {
7270
PortalRuntime liferayRuntime = (PortalRuntime)runtime.loadAdapter(

tools/plugins/com.liferay.ide.upgrade.problems.core/src/com/liferay/ide/upgrade/problems/core/internal/commands/SwitchToUseReleaseAPIDependencyCommand.java

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
package com.liferay.ide.upgrade.problems.core.internal.commands;
1616

1717
import com.liferay.ide.core.IWorkspaceProject;
18-
import com.liferay.ide.core.util.VersionUtil;
1918
import com.liferay.ide.core.workspace.LiferayWorkspaceUtil;
2019
import com.liferay.ide.core.workspace.WorkspaceConstants;
2120
import com.liferay.ide.gradle.core.GradleUtil;
@@ -106,29 +105,29 @@ private List<String> _getAllDependenciesArtifactIds() {
106105
return Collections.emptyList();
107106
}
108107

109-
String simplifiedVersion = VersionUtil.simplifyTargetPlatformVersion(
110-
gradleWorkspaceProject.getTargetPlatformVersion());
108+
String targetPlatformVersion = gradleWorkspaceProject.getTargetPlatformVersion();
111109

112-
if (Objects.isNull(simplifiedVersion)) {
110+
if (Objects.isNull(targetPlatformVersion)) {
113111
return Collections.emptyList();
114112
}
115113

116114
String productKey = gradleWorkspaceProject.getProperty(WorkspaceConstants.WORKSPACE_PRODUCT_PROPERTY, null);
117115

118116
List<String> allArtifactIds = new ArrayList<>();
119117

120-
String[] versionParts = simplifiedVersion.split("\\.");
118+
String[] versionParts = targetPlatformVersion.split("\\.");
121119

122120
if (productKey.startsWith("dxp")) {
123-
simplifiedVersion = versionParts[0] + "." + versionParts[1] + "." + versionParts[2] + ".x";
121+
targetPlatformVersion = versionParts[0] + "." + versionParts[1] + "." + versionParts[2] + ".x";
124122
}
125123
else if (productKey.startsWith("portal")) {
126-
simplifiedVersion = versionParts[0] + "." + versionParts[1] + ".x";
124+
targetPlatformVersion = versionParts[0] + "." + versionParts[1] + ".x";
127125
}
128126

129127
Class<?> clazz = SwitchToUseReleaseAPIDependencyCommand.class;
130128

131-
try (InputStream inputStream = clazz.getResourceAsStream("/release-api/" + simplifiedVersion + "-versions.txt");
129+
try (InputStream inputStream = clazz.getResourceAsStream(
130+
"/release-api/" + targetPlatformVersion + "-versions.txt");
132131
BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(inputStream))) {
133132

134133
String dependency = null;

0 commit comments

Comments
 (0)