Skip to content

Commit 60db513

Browse files
authored
feat(guardian): add APIs to add and remove approver (goto#167)
1 parent 8266bc0 commit 60db513

File tree

1 file changed

+40
-7
lines changed

1 file changed

+40
-7
lines changed

odpf/guardian/v1beta1/guardian.proto

Lines changed: 40 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,19 @@ service GuardianService {
180180
};
181181
}
182182

183+
rpc AddApprover(AddApproverRequest) returns (AddApproverResponse) {
184+
option (google.api.http) = {
185+
post: "/v1beta1/appeals/{appeal_id}/approvals/{approval_id}/approvers"
186+
body: "*"
187+
};
188+
}
189+
190+
rpc DeleteApprover(DeleteApproverRequest) returns (DeleteApproverResponse) {
191+
option (google.api.http) = {
192+
delete: "/v1beta1/appeals/{appeal_id}/approvals/{approval_id}/approvers/{email}"
193+
};
194+
}
195+
183196
rpc RevokeAppeals(RevokeAppealsRequest) returns (RevokeAppealsResponse) {
184197
option (google.api.http) = {
185198
post: "/v1beta1/appeals/revoke"
@@ -377,6 +390,15 @@ message RevokeAppealResponse {
377390
Appeal appeal = 1;
378391
}
379392

393+
message RevokeAppealsRequest {
394+
repeated string account_ids = 1;
395+
repeated string provider_types = 2;
396+
repeated string provider_urns = 3;
397+
repeated string resource_types = 4;
398+
repeated string resource_urns = 5;
399+
string reason = 6;
400+
}
401+
380402
message RevokeAppealsResponse {
381403
repeated Appeal appeals = 1;
382404
}
@@ -434,13 +456,24 @@ message UpdateApprovalResponse {
434456
Appeal appeal = 1;
435457
}
436458

437-
message RevokeAppealsRequest {
438-
repeated string account_ids = 1;
439-
repeated string provider_types = 2;
440-
repeated string provider_urns = 3;
441-
repeated string resource_types = 4;
442-
repeated string resource_urns = 5;
443-
string reason = 6;
459+
message AddApproverRequest {
460+
string appeal_id = 1;
461+
string approval_id = 2;
462+
string email = 3;
463+
}
464+
465+
message AddApproverResponse {
466+
Appeal appeal = 1;
467+
}
468+
469+
message DeleteApproverRequest {
470+
string appeal_id = 1;
471+
string approval_id = 2;
472+
string email = 3;
473+
}
474+
475+
message DeleteApproverResponse {
476+
Appeal appeal = 1;
444477
}
445478

446479
message Role {

0 commit comments

Comments
 (0)