Skip to content

Commit 9f0b4c0

Browse files
committed
More changes
1 parent eaf3fbe commit 9f0b4c0

File tree

2 files changed

+19
-13
lines changed

2 files changed

+19
-13
lines changed

.github/workflows/vcpkg_docker.yml

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
name: Docker Build Images
22

3+
# Based on https://docs.docker.com/build/ci/github-actions/multi-platform/#distribute-build-across-multiple-runners
4+
35
on:
46
schedule:
57
# Once every Wednesday at 00:00
@@ -9,11 +11,11 @@ on:
911
- master
1012
paths:
1113
- 'docker/**'
12-
- '.github/workflows/vcpkg_docker_amd64.yml'
14+
- '.github/workflows/vcpkg_docker.yml'
1315
pull_request:
1416
paths:
1517
- 'docker/**'
16-
- '.github/workflows/vcpkg_docker_amd64.yml'
18+
- '.github/workflows/vcpkg_docker.yml'
1719

1820
concurrency:
1921
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
@@ -29,8 +31,6 @@ jobs:
2931
strategy:
3032
fail-fast: false
3133
matrix:
32-
container:
33-
- { version: '22.04', codename: 'jammy' }
3434
platform:
3535
- linux/amd64
3636
- linux/arm64
@@ -49,8 +49,12 @@ jobs:
4949
- name: Set up Docker Buildx
5050
uses: docker/setup-buildx-action@v3
5151

52-
- name: Log in to GitHub registry
53-
run: echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin
52+
- name: Login to GHCR
53+
uses: docker/login-action@v3
54+
with:
55+
registry: ghcr.io
56+
username: ${{ github.repository_owner }}
57+
password: ${{ secrets.GITHUB_TOKEN }}
5458

5559
- name: Generate Image Name
5660
env:
@@ -112,8 +116,12 @@ jobs:
112116
with:
113117
images: ${{ env.REGISTRY_IMAGE }}
114118

115-
- name: Log in to registry
116-
run: echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin
119+
- name: Login to GHCR
120+
uses: docker/login-action@v3
121+
with:
122+
registry: ghcr.io
123+
username: ${{ github.repository_owner }}
124+
password: ${{ secrets.GITHUB_TOKEN }}
117125

118126
- name: Create manifest list and push
119127
working-directory: /tmp/digests

docker/Dockerfile.ubuntu.vcpkg

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
ARG DISTRO_VERSION=focal
1+
ARG DISTRO_VERSION=jammy
22
ARG LLVM_VERSION=16
33

44
ARG BUILD_BASE=ubuntu:${DISTRO_VERSION}
@@ -47,10 +47,8 @@ ARG DISTRO_VERSION
4747
RUN export DEBIAN_FRONTEND=noninteractive && \
4848
apt-get update && \
4949
\
50-
if [ ${DISTRO_VERSION} != "jammy" ] ; then \
51-
apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys 3FA7E0328081BFF6A14DA29AA6A19B38D3D831EF && \
52-
echo "deb https://download.mono-project.com/repo/ubuntu stable-${DISTRO_VERSION} main" | tee /etc/apt/sources.list.d/mono-official-stable.list ; \
53-
fi && \
50+
apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys 3FA7E0328081BFF6A14DA29AA6A19B38D3D831EF && \
51+
echo "deb https://download.mono-project.com/repo/ubuntu stable-${DISTRO_VERSION} main" | tee /etc/apt/sources.list.d/mono-official-stable.list ; \
5452
\
5553
apt-get update && \
5654
apt-get install --yes mono-devel && \

0 commit comments

Comments
 (0)