Updated XED from 2022 to 2025 #731
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
wizardengineer
force-pushed
the
julius/update-xed
branch
from
c1f9dbe to
d84ad70
Compare
kyle-elliott-tob
approved these changes
Nov 26, 2025
| val = new llvm::BitCastInst(val, int_type, llvm::Twine::createNull(), block); | ||
|
|
||
| val_type = int_type; | ||
| } else if (val_type->isArrayTy()) { |
Collaborator
There was a problem hiding this comment.
Not feeling the best about this, but the alternatives aren't great. We can
- Abuse ExtractValue with a chain of SHIFT/OR operations to build the integer, but that's extremely bloated
- Convert from Array -> Vector -> Integer, I think this is just silly
- Rewrite LoadRegValue with a special case to load certain array sizes as their native integer compliments
I think ultimately, the 3rd option is something worth exploring, but is out of scope for this current PR and I want to trigger a larger discussion for this.
Collaborator
Author
There was a problem hiding this comment.
Yeah, we can look into the 3rd option. I think it might be more viable?
wizardengineer
force-pushed
the
julius/update-xed
branch
from
d84ad70 to
14f1352
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Intel XED to v2025 with Compatibility Fixes
Overview Section
Commit Details (5 commits)
Additional Sections
The document is ready for you to use as your PR description!