enable -Xfatal-warnings

Author: SethTisue

build.sbt

@@ -42,7 +42,8 @@ lazy val `genjavadoc-plugin` = (project in file("plugin"))
       else default
     },
     crossVersion := CrossVersion.full,
-    exportJars := true
+    exportJars := true,
+    scalacOptions ++= Seq("-deprecation", "-feature", "-unchecked", "-Xfatal-warnings")
   )
 
 lazy val defaults = Seq(

plugin/src/main/scala/com/typesafe/genjavadoc/AST.scala

@@ -77,7 +77,7 @@ trait AST { this: TransformCake ⇒
 
   def fabricateParams: Boolean
 
-  final case class DeprecationInfo(msg: String, since: String) {
+  case class DeprecationInfo(msg: String, since: String) {
     def maybeDot = if (msg.endsWith(".")) " " else ". "
     def maybeSinceDot = if (since.endsWith(".")) " " else ". "
     def render = s" * @deprecated ${msg}${maybeDot}Since $since${maybeSinceDot}"

plugin/src/main/scala/com/typesafe/genjavadoc/BaseComments.scala

@@ -73,8 +73,8 @@ trait BaseComments { this: TransformCake ⇒
 
   implicit val positionOrdering: Ordering[Position] = new Ordering[Position] {
     def compare(a: Position, b: Position) =
-      if (a.endOrPoint < b.startOrPoint) -1
-      else if (a.startOrPoint > b.endOrPoint) 1
+      if (a.end < b.start) -1
+      else if (a.start > b.end) 1
       else 0
   }
   var comments = TreeMap[Position, Comment]()
@@ -86,7 +86,7 @@ trait BaseComments { this: TransformCake ⇒
 
   val positions = comments.keySet
 
-  def between(p1: Position, p2: Position) = unit.source.content.slice(p1.startOrPoint, p2.startOrPoint).filterNot(_ == '\n').mkString
+  def between(p1: Position, p2: Position) = unit.source.content.slice(p1.start, p2.start).filterNot(_ == '\n').mkString
 
   object ScalaDoc extends (Comment ⇒ Boolean) {
     def apply(c: Comment): Boolean = c.text.head.startsWith("/**")

plugin/src/main/scala/com/typesafe/genjavadoc/BasicTransform.scala

@@ -52,7 +52,7 @@ trait BasicTransform { this: TransformCake ⇒
         val old = pos
         pos = max(tp, prevTemplateMaxPos)
         if (old.precedes(pos)) {
-          (positions.from(old) intersect positions.to(pos)).toSeq map comments filter ScalaDoc lastOption match {
+          (positions.from(old) intersect positions.to(pos)).toSeq.map(comments).filter(ScalaDoc).lastOption match {
             case Some(c) ⇒ c.text // :+ s"// found in '${between(old, pos)}'"
             case None ⇒
               // s"// empty '${between(old, pos)}' (${pos.lineContent}:${pos.column})" ::

plugin/src/main/scala/com/typesafe/genjavadoc/JavaSig.scala

@@ -12,10 +12,10 @@ trait JavaSig { this: TransformCake ⇒
     def removeThis(in: Type): Type = {
       //          println("transforming " + in)
       in match {
-        case ThisType(parent) if !parent.isPackage ⇒ removeThis(parent.tpe)
-        case SingleType(parent, name)              ⇒ typeRef(removeThis(parent), name, Nil)
-        case TypeRef(pre, sym, args)               ⇒ typeRef(removeThis(pre), sym, args)
-        case x                                     ⇒ x
+        case ThisType(parent) if !parent.hasPackageFlag ⇒ removeThis(parent.tpe)
+        case SingleType(parent, name)                   ⇒ typeRef(removeThis(parent), name, Nil)
+        case TypeRef(pre, sym, args)                    ⇒ typeRef(removeThis(pre), sym, args)
+        case x                                          ⇒ x
       }
     }