Skip to content

Commit 78de2ed

Browse files
efgpintoaludwiko
andauthored
fix(testkit): remove modification of proxy name (#1574)
* fix(testkit): remove modification of proxy name * fixing flaky test --------- Co-authored-by: Andrzej Ludwikowski <[email protected]>
1 parent 9e26fa1 commit 78de2ed

File tree

2 files changed

+19
-7
lines changed

2 files changed

+19
-7
lines changed

sdk/java-sdk-protobuf-testkit/src/main/java/kalix/javasdk/testkit/KalixProxyContainer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public class KalixProxyContainer extends GenericContainer<KalixProxyContainer> {
4141
static {
4242
String customImage = System.getenv("KALIX_TESTKIT_PROXY_IMAGE");
4343
if (customImage == null) {
44-
DEFAULT_PROXY_IMAGE_NAME = DockerImageName.parse(BuildInfo.proxyImage()).withTag(BuildInfo.proxyVersion().replace("-SNAPSHOT", ""));
44+
DEFAULT_PROXY_IMAGE_NAME = DockerImageName.parse(BuildInfo.proxyImage()).withTag(BuildInfo.proxyVersion());
4545
} else {
4646
Logger logger = LoggerFactory.getLogger(KalixProxyContainer.class);
4747
DEFAULT_PROXY_IMAGE_NAME = DockerImageName.parse(customImage);

sdk/java-sdk-spring/src/it/java/com/example/wiring/workflowentities/SpringWorkflowIntegrationTest.java

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -301,8 +301,12 @@ public void shouldRecoverFailingCounterWorkflowWithDefaultRecoverStrategy() {
301301
assertThat(counterValue).isEqualTo(3);
302302
});
303303

304-
var state = getWorkflowState(path);
305-
assertThat(state.finished()).isTrue();
304+
await()
305+
.atMost(10, TimeUnit.of(SECONDS))
306+
.untilAsserted(() -> {
307+
var state = getWorkflowState(path);
308+
assertThat(state.finished()).isTrue();
309+
});
306310
}
307311

308312
@Test
@@ -329,8 +333,12 @@ public void shouldRecoverFailingCounterWorkflowWithRecoverStrategy() {
329333
assertThat(counterValue).isEqualTo(3);
330334
});
331335

332-
var state = getWorkflowState(path);
333-
assertThat(state.finished()).isTrue();
336+
await()
337+
.atMost(10, TimeUnit.of(SECONDS))
338+
.untilAsserted(() -> {
339+
var state = getWorkflowState(path);
340+
assertThat(state.finished()).isTrue();
341+
});
334342
}
335343

336344
@Test
@@ -357,8 +365,12 @@ public void shouldRecoverWorkflowTimeout() {
357365
assertThat(counterValue).isEqualTo(3);
358366
});
359367

360-
var state = getWorkflowState(path);
361-
assertThat(state.finished()).isTrue();
368+
await()
369+
.atMost(10, TimeUnit.of(SECONDS))
370+
.untilAsserted(() -> {
371+
var state = getWorkflowState(path);
372+
assertThat(state.finished()).isTrue();
373+
});
362374
}
363375

364376
@Test

0 commit comments

Comments
 (0)