Skip to content

Commit 33ed164

Browse files
committed
Comment to make people aware configs are not used by SSL Config itself
1 parent b501251 commit 33ed164

File tree

1 file changed

+6
-2
lines changed
  • ssl-config-core/src/main/scala/com/typesafe/sslconfig/ssl

1 file changed

+6
-2
lines changed

ssl-config-core/src/main/scala/com/typesafe/sslconfig/ssl/Config.scala

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,8 @@ object SSLDebugConfig {
260260
* default.
261261
* @param disableHostnameVerification Whether hostname verification should be disabled. Be aware: SSL Config itself is not using this config.
262262
* However, it was kept because 3rd party libraries rely on its existence.
263-
* @param disableSNI Whether SNI should be disabled (up to client library to respect this setting or not)
263+
* @param disableSNI Whether SNI should be disabled (up to client library to respect this setting or not). Be aware: SSL Config itself is not using this config.
264+
* However, it was kept because 3rd party libraries rely on its existence.
264265
* @param acceptAnyCertificate Whether any X.509 certificate should be accepted or not.
265266
*/
266267
final class SSLLooseConfig private[sslconfig] (
@@ -338,9 +339,12 @@ object SSLParametersConfig {
338339
* @param revocationLists The revocation lists to check.
339340
* @param enabledCipherSuites If defined, override the platform default cipher suites.
340341
* @param enabledProtocols If defined, override the platform default protocols.
342+
* @param sslParametersConfig Be aware: SSL Config itself is not using this config.
343+
* However, it was kept because 3rd party libraries rely on its existence.
341344
* @param keyManagerConfig The key manager configuration.
342345
* @param trustManagerConfig The trust manager configuration.
343-
* @param hostnameVerifierClass The hostname verifier class.
346+
* @param hostnameVerifierClass The hostname verifier class. Be aware: SSL Config itself is not using this config.
347+
* However, it was kept because 3rd party libraries rely on its existence.
344348
* @param secureRandom The SecureRandom instance to use. Let the platform choose if None.
345349
* @param debug The debug config.
346350
* @param loose Loose configuratino parameters

0 commit comments

Comments
 (0)