Fix coverity errors

Author: Burak Serdar

crud/src/main/java/com/redhat/lightblue/assoc/ep/JoinSearch.java

@@ -145,10 +145,12 @@ private void retrieveNextBatch() {
                     findRequest.setFrom(from);
                     findRequest.setTo(to);
                     OperationContext opctx = search(ctx, findRequest);
-                    currentIterator=opctx.getDocumentStream();
-                    if(!currentIterator.hasNext()) {
-                        currentIterator.close();
-                        currentIterator=null;
+                    if(opctx!=null) {
+                        currentIterator=opctx.getDocumentStream();
+                        if(!currentIterator.hasNext()) {
+                            currentIterator.close();
+                            currentIterator=null;
+                        }
                     }
                 } else {
                     done=true;

crud/src/main/java/com/redhat/lightblue/hooks/HookManager.java

@@ -183,10 +183,10 @@ public boolean hasHooks(CRUDOperationContext ctx,CRUDOperation op) {
         List<Hook> mdHooks = md.getHooks().getHooks();
         for (Hook h : mdHooks) {
             switch (op) {
-            case INSERT: if(h.isInsert()) return true;
-            case UPDATE: if(h.isUpdate()) return true;
-            case DELETE: if(h.isDelete()) return true;
-            case FIND: if(h.isFind()) return true;
+            case INSERT: if(h.isInsert()) return true;break;
+            case UPDATE: if(h.isUpdate()) return true;break;
+            case DELETE: if(h.isDelete()) return true;break;
+            case FIND: if(h.isFind()) return true;break;
             }
         }
         return false;

crud/src/main/java/com/redhat/lightblue/mediator/Mediator.java

@@ -721,19 +721,21 @@ private void runBulkConstraintValidation(OperationContext ctx) {
         EntityMetadata md = ctx.getTopLevelEntityMetadata();
         ConstraintValidator constraintValidator = factory.getConstraintValidator(md);
         List<DocCtx> docs = ctx.getInputDocumentsWithoutErrors();
-        constraintValidator.validateDocs(docs);
-        Map<JsonDoc, List<Error>> docErrors = constraintValidator.getDocErrors();
-        for (Map.Entry<JsonDoc, List<Error>> entry : docErrors.entrySet()) {
-            JsonDoc doc = entry.getKey();
-            List<Error> errors = entry.getValue();
+        if(docs!=null) {
+            constraintValidator.validateDocs(docs);
+            Map<JsonDoc, List<Error>> docErrors = constraintValidator.getDocErrors();
+            for (Map.Entry<JsonDoc, List<Error>> entry : docErrors.entrySet()) {
+                JsonDoc doc = entry.getKey();
+                List<Error> errors = entry.getValue();
+                if (errors != null && !errors.isEmpty()) {
+                    ((DocCtx) doc).addErrors(errors);
+                }
+            }
+            List<Error> errors = constraintValidator.getErrors();
             if (errors != null && !errors.isEmpty()) {
-                ((DocCtx) doc).addErrors(errors);
+                ctx.addErrors(errors);
             }
         }
-        List<Error> errors = constraintValidator.getErrors();
-        if (errors != null && !errors.isEmpty()) {
-            ctx.addErrors(errors);
-        }
         LOGGER.debug("Constraint validation complete");
         ctx.measure.end("runBulkConstraintValidation");
     }