Skip to content

Commit 1c433f0

Browse files
committed
creates a error for every inaccessable field
1 parent 9e4fc4d commit 1c433f0

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

lightblue-ldap-crud/src/main/java/com/redhat/lightblue/crud/ldap/LdapCRUDController.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,10 @@ public CRUDInsertionResponse insert(CRUDOperationContext ctx,
122122
for(DocCtx document : documents){
123123
List<Path> paths = roles.getInaccessibleFields_Insert(document);
124124
if((paths != null) && !paths.isEmpty()){
125-
document.addError(Error.get("insert", CrudConstants.ERR_NO_FIELD_INSERT_ACCESS, paths.toString()));
126-
continue;
125+
for(Path path : paths){
126+
document.addError(Error.get("insert", CrudConstants.ERR_NO_FIELD_INSERT_ACCESS, path.toString()));
127+
continue;
128+
}
127129
}
128130

129131
JsonNode rootNode = document.getRoot();

lightblue-ldap-integration-test/src/test/java/com/redhat/lightblue/crud/ldap/ITCaseLdapCRUDControllerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ public void series2_phase1_Department_InsertWithInvalidRoles() throws Exception{
261261

262262
assertNoErrors(response);
263263
assertEquals(1, response.getDataErrors().size());
264-
JSONAssert.assertEquals("{\"errors\":[{\"errorCode\":\"crud:insert:NoFieldAccess\",\"msg\":\"[member]\"}]}",
264+
JSONAssert.assertEquals("{\"errors\":[{\"errorCode\":\"crud:insert:NoFieldAccess\",\"msg\":\"member\"}]}",
265265
response.getDataErrors().get(0).toJson().toString(), false);
266266
}
267267

0 commit comments

Comments
 (0)