Skip to content

Commit 504f1be

Browse files
committed
fixes #33 - directly use version in maven dependencies instead of properties
1 parent 615d3f8 commit 504f1be

File tree

2 files changed

+13
-29
lines changed

2 files changed

+13
-29
lines changed

lightblue-ldap-integration-test/pom.xml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,6 @@
3030

3131
<artifactId>lightblue-ldap-integration-test</artifactId>
3232

33-
<properties>
34-
<lightblue.mongo.version>1.3.0-SNAPSHOT</lightblue.mongo.version>
35-
</properties>
36-
3733
<dependencies>
3834
<dependency>
3935
<groupId>com.redhat.lightblue.ldap</groupId>
@@ -49,13 +45,13 @@
4945
<dependency>
5046
<groupId>com.redhat.lightblue.mongo</groupId>
5147
<artifactId>lightblue-mongo-config</artifactId>
52-
<version>${lightblue.mongo.version}</version>
48+
<version>1.3.0-SNAPSHOT</version>
5349
<scope>test</scope>
5450
</dependency>
5551
<dependency>
5652
<groupId>com.redhat.lightblue.mongo</groupId>
5753
<artifactId>lightblue-mongo-test</artifactId>
58-
<version>${lightblue.mongo.version}</version>
54+
<version>1.3.0-SNAPSHOT</version>
5955
<scope>test</scope>
6056
</dependency>
6157
</dependencies>

pom.xml

Lines changed: 11 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
<connection>scm:git:https://github.com/lightblue-platform/lightblue-ldap.git</connection>
5252
<developerConnection>scm:git:[email protected]:lightblue-platform/lightblue-ldap.git</developerConnection>
5353
<url>https://github.com/lightblue-platform/lightblue-ldap</url>
54-
<tag>HEAD</tag>
54+
<tag>HEAD</tag>
5555
</scm>
5656

5757
<distributionManagement>
@@ -62,18 +62,6 @@
6262
</distributionManagement>
6363

6464
<properties>
65-
<!-- Lightblue Core -->
66-
<lightblue-core.version>1.3.0-SNAPSHOT</lightblue-core.version>
67-
68-
<!-- 3rd Party -->
69-
<unboundid.version>2.3.8</unboundid.version>
70-
<hystrix.version>1.3.16</hystrix.version>
71-
<slf4j.version>1.7.7</slf4j.version>
72-
73-
<!-- Test -->
74-
<junit.version>4.11</junit.version>
75-
<mockito.version>1.10.8</mockito.version>
76-
7765
<!-- Sonar -->
7866
<sonar.exclusions>**/*Test.java,**/*Exception.java</sonar.exclusions>
7967
<sonar.jdbc.url>jdbc:mysql://127.0.0.1:3306/sonar?useUnicode=true&amp;characterEncoding=utf8&amp;rewriteBatchedStatements=true</sonar.jdbc.url>
@@ -98,7 +86,7 @@
9886
<dependency>
9987
<groupId>org.slf4j</groupId>
10088
<artifactId>slf4j-api</artifactId>
101-
<version>${slf4j.version}</version>
89+
<version>1.7.7</version>
10290
</dependency>
10391

10492
<!-- Global Test Dependencies -->
@@ -126,17 +114,17 @@
126114
<dependency>
127115
<groupId>com.redhat.lightblue</groupId>
128116
<artifactId>lightblue-core-config</artifactId>
129-
<version>${lightblue-core.version}</version>
117+
<version>1.3.0-SNAPSHOT</version>
130118
</dependency>
131119
<dependency>
132120
<groupId>com.redhat.lightblue</groupId>
133121
<artifactId>lightblue-core-crud</artifactId>
134-
<version>${lightblue-core.version}</version>
122+
<version>1.3.0-SNAPSHOT</version>
135123
</dependency>
136124
<dependency>
137125
<groupId>com.redhat.lightblue</groupId>
138126
<artifactId>lightblue-core-metadata</artifactId>
139-
<version>${lightblue-core.version}</version>
127+
<version>1.3.0-SNAPSHOT</version>
140128
</dependency>
141129

142130
<!-- Lightblue Ldap -->
@@ -176,37 +164,37 @@
176164
<dependency>
177165
<groupId>com.unboundid</groupId>
178166
<artifactId>unboundid-ldapsdk</artifactId>
179-
<version>${unboundid.version}</version>
167+
<version>2.3.8</version>
180168
</dependency>
181169
<dependency>
182170
<groupId>com.netflix.hystrix</groupId>
183171
<artifactId>hystrix-core</artifactId>
184-
<version>${hystrix.version}</version>
172+
<version>1.3.16</version>
185173
</dependency>
186174

187175
<!-- Test -->
188176
<dependency>
189177
<groupId>junit</groupId>
190178
<artifactId>junit</artifactId>
191-
<version>${junit.version}</version>
179+
<version>4.11</version>
192180
<scope>test</scope>
193181
</dependency>
194182
<dependency>
195183
<groupId>org.slf4j</groupId>
196184
<artifactId>slf4j-simple</artifactId>
197-
<version>${slf4j.version}</version>
185+
<version>1.7.7</version>
198186
<scope>test</scope>
199187
</dependency>
200188
<dependency>
201189
<groupId>org.mockito</groupId>
202190
<artifactId>mockito-core</artifactId>
203-
<version>${mockito.version}</version>
191+
<version>1.10.8</version>
204192
<scope>test</scope>
205193
</dependency>
206194
<dependency>
207195
<groupId>com.redhat.lightblue</groupId>
208196
<artifactId>lightblue-core-test</artifactId>
209-
<version>${lightblue-core.version}</version>
197+
<version>1.3.0-SNAPSHOT</version>
210198
<scope>test</scope>
211199
</dependency>
212200
</dependencies>

0 commit comments

Comments
 (0)