Allow changing the connect timeout after the proxy has been started

jekh · jekh · commit 657a78fcb538 · 2016-04-23T13:13:18.000-07:00
diff --git a/browsermob-core-littleproxy/src/main/java/net/lightbody/bmp/BrowserMobProxyServer.java b/browsermob-core-littleproxy/src/main/java/net/lightbody/bmp/BrowserMobProxyServer.java
@@ -892,11 +892,11 @@ public void setWriteLimitKbps(long writeLimitKbps) {
 
     @Override
     public void setConnectTimeout(int connectTimeout, TimeUnit timeUnit) {
+        this.connectTimeoutMs = (int) TimeUnit.MILLISECONDS.convert(connectTimeout, timeUnit);
+
         if (isStarted()) {
-            throw new IllegalStateException("LittleProxy implementation does not allow changes to connect timeout after proxy has been started");
+            proxyServer.setConnectTimeout((int) TimeUnit.MILLISECONDS.convert(connectTimeout, timeUnit));
         }
-
-        this.connectTimeoutMs = (int) TimeUnit.MILLISECONDS.convert(connectTimeout, timeUnit);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -892,11 +892,11 @@ public void setWriteLimitKbps(long writeLimitKbps) {`
`892`	`892`
`893`	`893`	`@Override`
`894`	`894`	`public void setConnectTimeout(int connectTimeout, TimeUnit timeUnit) {`
	`895`	`+ this.connectTimeoutMs = (int) TimeUnit.MILLISECONDS.convert(connectTimeout, timeUnit);`
	`896`	`+`
`895`	`897`	`if (isStarted()) {`
`896`		`- throw new IllegalStateException("LittleProxy implementation does not allow changes to connect timeout after proxy has been started");`
	`898`	`+ proxyServer.setConnectTimeout((int) TimeUnit.MILLISECONDS.convert(connectTimeout, timeUnit));`
`897`	`899`	`}`
`898`		`-`
`899`		`- this.connectTimeoutMs = (int) TimeUnit.MILLISECONDS.convert(connectTimeout, timeUnit);`
`900`	`900`	`}`
`901`	`901`
`902`	`902`	`/**`