rebase fixes 2021-09-07

Author: ksedgwic

channeld/commit_tx.c

@@ -272,6 +272,7 @@ struct bitcoin_tx *commit_tx(const tal_t *ctx,
 	 *    `dust_limit_satoshis`, add a [`to_remote`
 	 *    output](#to_remote-output).
 	 */
+	const u8 *redeem = NULL;
 	if (amount_msat_greater_eq_sat(other_pay, dust_limit)) {
 		struct amount_sat amount = amount_msat_to_sat_round_down(other_pay);
 		u8 *scriptpubkey;
@@ -290,11 +291,10 @@ struct bitcoin_tx *commit_tx(const tal_t *ctx,
 		 * Otherwise, this output is a simple P2WPKH to `remotepubkey`.
 		 */
 		if (option_anchor_outputs) {
-			const u8 *redeem
-				= anchor_to_remote_redeem(tmpctx,
-							  &keyset->other_payment_key,
-							  (!side) == lessor ?
-								csv_lock : 1);
+			redeem = anchor_to_remote_redeem(tmpctx,
+							 &keyset->other_payment_key,
+							 (!side) == lessor ?
+							 csv_lock : 1);
 			/* BOLT- #3:
 			 * ##### Leased channel (`option_will_fund`)
 			 *
@@ -312,7 +312,7 @@ struct bitcoin_tx *commit_tx(const tal_t *ctx,
 			scriptpubkey = scriptpubkey_p2wpkh(tmpctx,
 							   &keyset->other_payment_key);
 		}
-		pos = bitcoin_tx_add_output(tx, scriptpubkey, redeem, amount);
+		pos = bitcoin_tx_add_output(tx, scriptpubkey, (u8 *) redeem, amount);
 		assert(pos == n);
 		(*htlcmap)[n] = direct_outputs ? dummy_to_remote : NULL;
 		/* We don't assign cltvs[n]: if we use it, order doesn't matter.

closingd/closingd.c

@@ -508,7 +508,9 @@ static size_t closing_tx_weight_estimate(u8 *scriptpubkey[NUM_SIDES],
 					 const u8 *funding_wscript,
 					 const struct amount_sat *out,
 					 struct amount_sat funding,
-					 struct amount_sat dust_limit)
+					 struct amount_sat dust_limit,
+					 u32 local_wallet_index,
+					 const struct ext_key *local_wallet_ext_key)
 {
 	/* We create a dummy close */
 	struct bitcoin_tx *tx;
@@ -520,6 +522,7 @@ static size_t closing_tx_weight_estimate(u8 *scriptpubkey[NUM_SIDES],
 
 	memset(&dummy_txid, 0, sizeof(dummy_txid));
 	tx = create_close_tx(tmpctx, chainparams,
+			     local_wallet_index, local_wallet_ext_key,
 			     scriptpubkey[LOCAL], scriptpubkey[REMOTE],
 			     funding_wscript,
 			     &dummy_txid, 0,
@@ -623,7 +626,7 @@ int main(int argc, char *argv[])
 				    &out[LOCAL],
 				    &out[REMOTE],
 				    &our_dust_limit,
-				    &min_fee_to_accept, &initial_feerate,
+				    &min_feerate, &initial_feerate,
 				    &commitment_fee,
 				    &local_wallet_index,
 				    &local_wallet_ext_key,
@@ -645,7 +648,9 @@ int main(int argc, char *argv[])
 	/* Start at what we consider a reasonable feerate for this tx. */
 	calc_fee_bounds(closing_tx_weight_estimate(scriptpubkey,
 						   funding_wscript,
-						   out, funding, our_dust_limit),
+						   out, funding, our_dust_limit,
+						   local_wallet_index,
+						   &local_wallet_ext_key),
 			min_feerate, initial_feerate, commitment_fee,
 			&min_fee_to_accept, &offer[LOCAL]);
 

closingd/closingd_wire.csv

@@ -21,7 +21,6 @@ msgdata,closingd_init,our_dust_limit,amount_sat,
 msgdata,closingd_init,min_feerate_perksipa,u32,
 msgdata,closingd_init,preferred_feerate_perksipa,u32,
 msgdata,closingd_init,fee_limit_satoshi,amount_sat,
-msgdata,closingd_init,initial_fee_satoshi,amount_sat,
 msgdata,closingd_init,local_wallet_index,u32,
 msgdata,closingd_init,local_wallet_ext_key,ext_key,
 msgdata,closingd_init,local_scriptpubkey_len,u16,

closingd/closingd_wiregen.c

@@ -246,19 +246,19 @@ struct bitcoin_tx *initial_commit_tx(const tal_t *ctx,
 		 */
 		u8 *scriptpubkey;
 		int pos;
+		const u8 *redeem = NULL;
 
 		amount = amount_msat_to_sat_round_down(other_pay);
 		if (option_anchor_outputs) {
-			const u8 *redeem
-				= anchor_to_remote_redeem(tmpctx,
+			redeem = anchor_to_remote_redeem(tmpctx,
 						&keyset->other_payment_key,
 						(!side) == lessor ? csv_lock : 1);
 			scriptpubkey = scriptpubkey_p2wsh(tmpctx, redeem);
 		} else {
 			scriptpubkey = scriptpubkey_p2wpkh(tmpctx,
 							   &keyset->other_payment_key);
 		}
-		pos = bitcoin_tx_add_output(tx, scriptpubkey, redeem, amount);
+		pos = bitcoin_tx_add_output(tx, scriptpubkey, (u8 *) redeem, amount);
 		assert(pos == n);
 		output_order[n] = dummy_remote;
 		n++;

closingd/closingd_wiregen.h

@@ -1581,6 +1581,28 @@ static struct io_plan *handle_sign_message(struct io_conn *conn,
 			 take(towire_hsmd_sign_message_reply(NULL, &rsig)));
 }
 
+/*~ lightningd asks us to sign a liquidity ad offer */
+static struct io_plan *handle_sign_option_will_fund_offer(struct io_conn *conn,
+					      struct client *c,
+					      const u8 *msg_in)
+{
+	struct pubkey funding_pubkey;
+	u32 lease_expiry, channel_fee_base_max_msat;
+	u16 channel_fee_max_ppt;
+
+	if (!fromwire_hsmd_sign_option_will_fund_offer(msg_in,
+						       &funding_pubkey,
+						       &lease_expiry,
+						       &channel_fee_base_max_msat,
+						       &channel_fee_max_ppt))
+		return bad_req(conn, c, msg_in);
+
+	status_failed(STATUS_FAIL_INTERNAL_ERROR,
+		      "handle_sign_option_will_fund_offer unimplemented");
+	return bad_req_fmt(conn, c, msg_in,
+			   "handle_sign_option_will_fund_offer unimplemented");
+}
+
 /*~ lightningd asks us to sign a bolt12 (e.g. offer). */
 static struct io_plan *handle_sign_bolt12(struct io_conn *conn,
 					   struct client *c,
@@ -1676,6 +1698,9 @@ static bool check_client_capabilities(struct client *client,
 	case WIRE_HSMD_SIGN_MUTUAL_CLOSE_TX:
 		return (client->capabilities & HSM_CAP_SIGN_CLOSING_TX) != 0;
 
+	case WIRE_HSMD_SIGN_OPTION_WILL_FUND_OFFER:
+		return (client->capabilities & HSM_CAP_SIGN_WILL_FUND_OFFER) != 0;
+
 	case WIRE_HSMD_INIT:
 	case WIRE_HSMD_NEW_CHANNEL:
 	case WIRE_HSMD_CLIENT_HSMFD:
@@ -1707,6 +1732,7 @@ static bool check_client_capabilities(struct client *client,
 	case WIRE_HSMD_VALIDATE_COMMITMENT_TX_REPLY:
 	case WIRE_HSMD_VALIDATE_REVOCATION_REPLY:
 	case WIRE_HSMD_SIGN_TX_REPLY:
+	case WIRE_HSMD_SIGN_OPTION_WILL_FUND_OFFER_REPLY:
 	case WIRE_HSMD_GET_PER_COMMITMENT_POINT_REPLY:
 	case WIRE_HSMD_CHECK_FUTURE_SECRET_REPLY:
 	case WIRE_HSMD_GET_CHANNEL_BASEPOINTS_REPLY:
@@ -1818,6 +1844,9 @@ static struct io_plan *handle_client(struct io_conn *conn, struct client *c)
 	case WIRE_HSMD_SIGN_MESSAGE:
 		return handle_sign_message(conn, c, c->msg_in);
 
+	case WIRE_HSMD_SIGN_OPTION_WILL_FUND_OFFER:
+		return handle_sign_option_will_fund_offer(conn, c, c->msg_in);
+
 	case WIRE_HSMD_SIGN_BOLT12:
 		return handle_sign_bolt12(conn, c, c->msg_in);
 #if DEVELOPER
@@ -1841,6 +1870,7 @@ static struct io_plan *handle_client(struct io_conn *conn, struct client *c)
 	case WIRE_HSMD_VALIDATE_COMMITMENT_TX_REPLY:
 	case WIRE_HSMD_VALIDATE_REVOCATION_REPLY:
 	case WIRE_HSMD_SIGN_TX_REPLY:
+	case WIRE_HSMD_SIGN_OPTION_WILL_FUND_OFFER_REPLY:
 	case WIRE_HSMD_GET_PER_COMMITMENT_POINT_REPLY:
 	case WIRE_HSMD_CHECK_FUTURE_SECRET_REPLY:
 	case WIRE_HSMD_GET_CHANNEL_BASEPOINTS_REPLY: