Skip to content

Commit 10da9de

Browse files
committed
Skip test which are not valid w/ VLSD
1 parent 69d49b6 commit 10da9de

File tree

8 files changed

+47
-0
lines changed

8 files changed

+47
-0
lines changed

tests/test_closing.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -728,6 +728,7 @@ def test_penalty_outhtlc(node_factory, bitcoind, executor, chainparams):
728728

729729

730730
@unittest.skipIf(TEST_NETWORK != 'regtest', 'elementsd doesnt yet support PSBT features we need')
731+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "handle_sign_option_will_fund_offer unimplemented")
731732
@pytest.mark.openchannel('v2')
732733
@pytest.mark.slow_test
733734
@pytest.mark.developer("requres 'dev-queryrates'")
@@ -769,6 +770,7 @@ def test_channel_lease_falls_behind(node_factory, bitcoind):
769770

770771

771772
@unittest.skipIf(TEST_NETWORK != 'regtest', 'elementsd doesnt yet support PSBT features we need')
773+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "handle_sign_option_will_fund_offer unimplemented")
772774
@pytest.mark.openchannel('v2')
773775
@pytest.mark.developer("requres 'dev-queryrates'")
774776
@pytest.mark.slow_test
@@ -873,6 +875,7 @@ def test_channel_lease_post_expiry(node_factory, bitcoind, chainparams):
873875

874876

875877
@unittest.skipIf(TEST_NETWORK != 'regtest', 'elementsd doesnt yet support PSBT features we need')
878+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "handle_sign_option_will_fund_offer unimplemented")
876879
@pytest.mark.openchannel('v2')
877880
@pytest.mark.slow_test
878881
@pytest.mark.developer("requres 'dev-queryrates'")
@@ -979,6 +982,7 @@ def test_channel_lease_unilat_closes(node_factory, bitcoind):
979982

980983

981984
@unittest.skipIf(TEST_NETWORK != 'regtest', 'elementsd doesnt yet support PSBT features we need')
985+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "handle_sign_option_will_fund_offer unimplemented")
982986
@pytest.mark.openchannel('v2')
983987
@unittest.skipIf(os.getenv('TEST_DB_PROVIDER', 'sqlite3') != 'sqlite3', "Makes use of the sqlite3 db")
984988
@pytest.mark.developer("requres 'dev-queryrates'")
@@ -1055,6 +1059,7 @@ def test_channel_lease_lessor_cheat(node_factory, bitcoind, chainparams):
10551059

10561060

10571061
@unittest.skipIf(TEST_NETWORK != 'regtest', 'elementsd doesnt yet support PSBT features we need')
1062+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "handle_sign_option_will_fund_offer unimplemented")
10581063
@pytest.mark.openchannel('v2')
10591064
@unittest.skipIf(os.getenv('TEST_DB_PROVIDER', 'sqlite3') != 'sqlite3', "Makes use of the sqlite3 db")
10601065
@pytest.mark.developer("requres 'dev-queryrates'")
@@ -1130,6 +1135,7 @@ def test_channel_lease_lessee_cheat(node_factory, bitcoind, chainparams):
11301135

11311136
@pytest.mark.developer("needs DEVELOPER=1")
11321137
@unittest.skipIf(os.getenv('TEST_DB_PROVIDER', 'sqlite3') != 'sqlite3', "Makes use of the sqlite3 db")
1138+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "policy: can't sign revoked commitment number")
11331139
@pytest.mark.slow_test
11341140
def test_penalty_htlc_tx_fulfill(node_factory, bitcoind, chainparams):
11351141
""" Test that the penalizing node claims any published
@@ -1297,6 +1303,7 @@ def test_penalty_htlc_tx_fulfill(node_factory, bitcoind, chainparams):
12971303

12981304
@pytest.mark.developer("needs DEVELOPER=1")
12991305
@unittest.skipIf(os.getenv('TEST_DB_PROVIDER', 'sqlite3') != 'sqlite3', "Makes use of the sqlite3 db")
1306+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "policy: can't sign revoked commitment number")
13001307
@pytest.mark.slow_test
13011308
def test_penalty_htlc_tx_timeout(node_factory, bitcoind, chainparams):
13021309
""" Test that the penalizing node claims any published
@@ -1505,6 +1512,7 @@ def test_penalty_htlc_tx_timeout(node_factory, bitcoind, chainparams):
15051512

15061513

15071514
@pytest.mark.developer("uses dev_sign_last_tx")
1515+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "exceeds max fee policy")
15081516
def test_penalty_rbf_normal(node_factory, bitcoind, executor, chainparams):
15091517
'''
15101518
Test that penalty transactions are RBFed.
@@ -1629,6 +1637,7 @@ def get_rbf_tx(self, depth, name, resolve):
16291637

16301638

16311639
@pytest.mark.developer("uses dev_sign_last_tx")
1640+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "exceeds max fee policy")
16321641
def test_penalty_rbf_burn(node_factory, bitcoind, executor, chainparams):
16331642
'''
16341643
Test that penalty transactions are RBFed and we are willing to burn
@@ -3084,6 +3093,7 @@ def test_permfail_htlc_out(node_factory, bitcoind, executor):
30843093

30853094

30863095
@pytest.mark.developer("needs DEVELOPER=1")
3096+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "policy: can't withdraw to non-wallet address")
30873097
def test_permfail(node_factory, bitcoind):
30883098
l1, l2 = node_factory.line_graph(2)
30893099

@@ -3188,6 +3198,7 @@ def test_shutdown(node_factory):
31883198

31893199
@flaky
31903200
@pytest.mark.developer("needs to set upfront_shutdown_script")
3201+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "policy failure: validate_mutual_close_tx: holder_script doesn't match upfront holder_shutdown_script")
31913202
def test_option_upfront_shutdown_script(node_factory, bitcoind, executor):
31923203
# There's a workaround in channeld, that it treats incoming errors
31933204
# before both sides are locked in as warnings; this happens in

tests/test_connection.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1499,6 +1499,7 @@ def test_funding_v2_cancel_race(node_factory, bitcoind, executor):
14991499
@pytest.mark.openchannel('v1')
15001500
@pytest.mark.openchannel('v2')
15011501
@unittest.skipIf(TEST_NETWORK != 'regtest', "External wallet support doesn't work with elements yet.")
1502+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "remote_hsmd can't handle random external addresses (allowlist)")
15021503
def test_funding_close_upfront(node_factory, bitcoind):
15031504
opts = {'plugin': os.path.join(os.getcwd(), 'tests/plugins/openchannel_hook_accepter.py')}
15041505

@@ -2627,6 +2628,7 @@ def mock_sendrawtransaction(r):
26272628

26282629

26292630
@pytest.mark.developer("needs dev_fail")
2631+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "policy: can't withdraw to non-wallet address")
26302632
def test_no_fee_estimate(node_factory, bitcoind, executor):
26312633
l1 = node_factory.get_node(start=False, options={'dev-no-fake-fees': True})
26322634

@@ -3278,6 +3280,7 @@ def test_channel_features(node_factory, bitcoind):
32783280

32793281

32803282
@pytest.mark.developer("need dev-force-features")
3283+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "remote_hsmd doesn't support non-option_static_remotekey")
32813284
def test_nonstatic_channel(node_factory, bitcoind):
32823285
"""Smoke test for a channel without option_static_remotekey"""
32833286
l1, l2 = node_factory.line_graph(2,

tests/test_db.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,7 @@ def test_max_channel_id(node_factory, bitcoind):
134134
@unittest.skipIf(not COMPAT, "needs COMPAT to convert obsolete db")
135135
@unittest.skipIf(os.getenv('TEST_DB_PROVIDER', 'sqlite3') != 'sqlite3', "This test is based on a sqlite3 snapshot")
136136
@unittest.skipIf(TEST_NETWORK != 'regtest', "The network must match the DB snapshot")
137+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "remote_hsmd doesn't like channel_nonce changing")
137138
def test_scid_upgrade(node_factory, bitcoind):
138139
bitcoind.generate_block(1)
139140

@@ -147,6 +148,7 @@ def test_scid_upgrade(node_factory, bitcoind):
147148
@unittest.skipIf(not COMPAT, "needs COMPAT to convert obsolete db")
148149
@unittest.skipIf(os.getenv('TEST_DB_PROVIDER', 'sqlite3') != 'sqlite3', "This test is based on a sqlite3 snapshot")
149150
@unittest.skipIf(TEST_NETWORK != 'regtest', "The network must match the DB snapshot")
151+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "remote_hsmd doesn't like channel_nonce changing")
150152
def test_last_tx_inflight_psbt_upgrade(node_factory, bitcoind):
151153
bitcoind.generate_block(12)
152154

@@ -169,6 +171,7 @@ def test_last_tx_inflight_psbt_upgrade(node_factory, bitcoind):
169171
@unittest.skipIf(not COMPAT, "needs COMPAT to convert obsolete db")
170172
@unittest.skipIf(os.getenv('TEST_DB_PROVIDER', 'sqlite3') != 'sqlite3', "This test is based on a sqlite3 snapshot")
171173
@unittest.skipIf(TEST_NETWORK != 'regtest', "The network must match the DB snapshot")
174+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "remote_hsmd doesn't like channel_nonce changing")
172175
def test_last_tx_psbt_upgrade(node_factory, bitcoind):
173176
bitcoind.generate_block(12)
174177

@@ -205,6 +208,7 @@ def test_last_tx_psbt_upgrade(node_factory, bitcoind):
205208

206209
@unittest.skipIf(os.getenv('TEST_DB_PROVIDER', 'sqlite3') != 'sqlite3', "This test is based on a sqlite3 snapshot")
207210
@unittest.skipIf(TEST_NETWORK != 'regtest', "The network must match the DB snapshot")
211+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "remote_hsmd doesn't support backfill yet")
208212
def test_backfill_scriptpubkeys(node_factory, bitcoind):
209213
bitcoind.generate_block(214)
210214

@@ -331,6 +335,7 @@ def get_dsn(self):
331335
os.getenv('TEST_DB_PROVIDER', 'sqlite3') != 'sqlite3',
332336
"This test is based on a sqlite3 snapshot"
333337
)
338+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "remote_hsmd doesn't support DB migration")
334339
def test_local_basepoints_cache(bitcoind, node_factory):
335340
"""XXX started caching the local basepoints as well as the remote ones.
336341

tests/test_misc.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -462,6 +462,7 @@ def is_p2wpkh(output):
462462
assert only_one(fundingtx['vin'])['txid'] == res['wallettxid']
463463

464464

465+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "policy: can't withdraw to non-wallet address")
465466
def test_withdraw_misc(node_factory, bitcoind, chainparams):
466467
def dont_spend_outputs(n, txid):
467468
"""Reserve both outputs (we assume there are two!) in case any our ours, so we don't spend change: wrecks accounting checks"""
@@ -998,6 +999,7 @@ def test_cli(node_factory):
998999
assert [l for l in lines if not re.search(r'^help\[[0-9]*\].', l)] == ['format-hint=simple']
9991000

10001001

1002+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "remote_hsmd integration test job control fails here")
10011003
def test_daemon_option(node_factory):
10021004
"""
10031005
Make sure --daemon at least vaguely works!
@@ -1032,6 +1034,7 @@ def test_daemon_option(node_factory):
10321034

10331035
@flaky
10341036
@pytest.mark.developer("needs DEVELOPER=1")
1037+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "remote_hsmd doesn't have repeatable random seeding")
10351038
def test_blockchaintrack(node_factory, bitcoind):
10361039
"""Check that we track the blockchain correctly across reorgs
10371040
"""
@@ -1477,6 +1480,7 @@ def check_new_log():
14771480

14781481
@unittest.skipIf(VALGRIND,
14791482
"Valgrind sometimes fails assert on injected SEGV")
1483+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "temporary, until fedora-34 gets crashlog libs fixed")
14801484
def test_crashlog(node_factory):
14811485
l1 = node_factory.get_node(may_fail=True, allow_broken_log=True)
14821486

@@ -1710,6 +1714,7 @@ def mock_fail(*args):
17101714

17111715
@pytest.mark.developer("needs --dev-force-bip32-seed")
17121716
@unittest.skipIf(TEST_NETWORK != 'regtest', "Addresses are network specific")
1717+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "remote_hsmd doesn't support forced secrets")
17131718
def test_dev_force_bip32_seed(node_factory):
17141719
l1 = node_factory.get_node(options={'dev-force-bip32-seed': '0000000000000000000000000000000000000000000000000000000000000001'})
17151720
# First is m/0/0/1 ..
@@ -2042,6 +2047,7 @@ def test_regtest_upgrade(node_factory):
20422047

20432048
@unittest.skipIf(VALGRIND, "valgrind files can't be written since we rmdir")
20442049
@unittest.skipIf(TEST_NETWORK != "regtest", "needs bitcoin mainnet")
2050+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "remote_hsmd doesn't create hsm_secret file")
20452051
def test_new_node_is_mainnet(node_factory):
20462052
"""Test that an empty directory causes us to be on mainnet"""
20472053
l1 = node_factory.get_node(start=False, may_fail=True)
@@ -2207,6 +2213,7 @@ def test_sendcustommsg(node_factory):
22072213

22082214

22092215
@pytest.mark.developer("needs --dev-force-privkey")
2216+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "remote_hsmd doesn't support dev-force-privkey")
22102217
def test_getsharedsecret(node_factory):
22112218
"""
22122219
Test getsharedsecret command.

tests/test_opening.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
only_one, wait_for, sync_blockheight, first_channel_id, calc_lease_fee
66
)
77

8+
import os
89
import pytest
910
import re
1011
import unittest
@@ -16,6 +17,7 @@ def find_next_feerate(node, peer):
1617

1718

1819
@unittest.skipIf(TEST_NETWORK != 'regtest', 'elementsd doesnt yet support PSBT features we need')
20+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "handle_sign_option_will_fund_offer unimplemented")
1921
@pytest.mark.openchannel('v2')
2022
@pytest.mark.developer("requres 'dev-queryrates'")
2123
def test_queryrates(node_factory, bitcoind):
@@ -335,6 +337,7 @@ def test_v2_rbf_single(node_factory, bitcoind, chainparams):
335337

336338

337339
@unittest.skipIf(TEST_NETWORK != 'regtest', 'elementsd doesnt yet support PSBT features we need')
340+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "handle_sign_option_will_fund_offer unimplemented")
338341
@pytest.mark.openchannel('v2')
339342
def test_v2_rbf_liquidity_ad(node_factory, bitcoind, chainparams):
340343

@@ -1128,6 +1131,7 @@ def test_funder_options(node_factory, bitcoind):
11281131

11291132

11301133
@unittest.skipIf(TEST_NETWORK != 'regtest', 'elementsd doesnt yet support PSBT features we need')
1134+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "dual-funding not supported yet")
11311135
def test_funder_contribution_limits(node_factory, bitcoind):
11321136
opts = {'experimental-dual-fund': None,
11331137
'feerates': (5000, 5000, 5000, 5000)}

tests/test_pay.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2499,6 +2499,7 @@ def test_htlc_too_dusty_outgoing(node_factory, bitcoind, chainparams):
24992499
l1.rpc.sendpay(route, inv['payment_hash'], payment_secret=inv['payment_secret'])
25002500

25012501

2502+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "fee above maximum: 81720 > 80000")
25022503
@pytest.mark.developer("needs DEVELOPER=1 for dev_ignore_htlcs")
25032504
def test_htlc_too_dusty_incoming(node_factory, bitcoind):
25042505
""" Try to hit the 'too much dust' limit, should fail the HTLC """
@@ -4100,6 +4101,7 @@ def test_large_mpp_presplit(node_factory):
41004101

41014102
@pytest.mark.developer("builds large network, which is slow if not DEVELOPER")
41024103
@pytest.mark.slow_test
4104+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "remote_hsmd doesn't allow push of greater than 20k sat")
41034105
def test_mpp_overload_payee(node_factory, bitcoind):
41044106
"""
41054107
We had a bug where if the payer is unusually well-connected compared
@@ -4170,6 +4172,7 @@ def test_offer_needs_option(node_factory):
41704172
assert l1.rpc.decode('lno1qgsqvgnwgcg35z6ee2h3yczraddm72xrfua9uve2rlrm9deu7xyfzrcgqyys5qq7ypnwgkvdr57yzh6h92zg3qctvrm7w38djg67kzcm4yeg8vc4cq633uzqaxlsxzxergsrav494jjrpuy9hcldjeglha57lxvz20fhha6hjwhv69nnzwzjsajntyf0c4z8h9e70dfdlfq8jdvc9rdht8vr955udtg')['valid']
41714173

41724174

4175+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "remote_hsmd doesn't support bolt12 yet")
41734176
def test_offer(node_factory, bitcoind):
41744177
plugin = os.path.join(os.path.dirname(__file__), 'plugins/currencyUSDAUD5000.py')
41754178
l1 = node_factory.get_node(options={'plugin': plugin, 'experimental-offers': None})
@@ -4362,6 +4365,7 @@ def test_offer(node_factory, bitcoind):
43624365
assert 'recurrence: every 600 seconds paywindow -10 to +600 (pay proportional)\n' in output
43634366

43644367

4368+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "remote_hsmd doesn't support bolt12 yet")
43654369
@pytest.mark.developer("dev-no-modern-onion is DEVELOPER-only")
43664370
def test_fetchinvoice_3hop(node_factory, bitcoind):
43674371
l1, l2, l3, l4 = node_factory.line_graph(4, wait_for_announce=True,
@@ -4396,6 +4400,7 @@ def test_fetchinvoice_3hop(node_factory, bitcoind):
43964400
l1.rpc.call('fetchinvoice', {'offer': offer1['bolt12']})
43974401

43984402

4403+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "remote_hsmd doesn't support bolt12 yet")
43994404
def test_fetchinvoice(node_factory, bitcoind):
44004405
# We remove the conversion plugin on l3, causing it to get upset.
44014406
l1, l2, l3 = node_factory.line_graph(3, wait_for_announce=True,
@@ -4609,6 +4614,7 @@ def test_fetchinvoice(node_factory, bitcoind):
46094614

46104615

46114616
@pytest.mark.developer("Needs dev-allow-localhost for autoconnect, dev-force-features to avoid routing onionmsgs")
4617+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "remote_hsmd doesn't support bolt12 yet")
46124618
def test_fetchinvoice_autoconnect(node_factory, bitcoind):
46134619
"""We should autoconnect if we need to, to route."""
46144620

@@ -4675,6 +4681,7 @@ def test_pay_waitblockheight_timeout(node_factory, bitcoind):
46754681

46764682

46774683
@pytest.mark.developer("dev-rawrequest is DEVELOPER-only")
4684+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "remote_hsmd doesn't support bolt12 yet")
46784685
def test_dev_rawrequest(node_factory):
46794686
l1, l2 = node_factory.line_graph(2, fundchannel=False,
46804687
opts={'experimental-offers': None})
@@ -4691,6 +4698,7 @@ def test_dev_rawrequest(node_factory):
46914698
assert 'invoice' in ret
46924699

46934700

4701+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "remote_hsmd doesn't support bolt12 yet")
46944702
def do_test_sendinvoice(node_factory, bitcoind, disable):
46954703
l2opts = {'experimental-offers': None}
46964704
if disable:

tests/test_plugin.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2064,6 +2064,7 @@ def test_3847_repro(node_factory, bitcoind):
20642064
l1.rpc.paystatus(i1)
20652065

20662066

2067+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "trouble managing remotesigner when node killed this way")
20672068
def test_important_plugin(node_factory):
20682069
# Cache it here.
20692070
pluginsdir = os.path.join(os.path.dirname(__file__), "plugins")

tests/test_wallet.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525

2626

2727
@unittest.skipIf(TEST_NETWORK != 'regtest', "Test relies on a number of example addresses valid only in regtest")
28+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "policy: can't withdraw to non-wallet address")
2829
def test_withdraw(node_factory, bitcoind):
2930
amount = 1000000
3031
# Don't get any funds from previous runs.
@@ -688,6 +689,7 @@ def test_utxopsbt(node_factory, bitcoind, chainparams):
688689
reservedok=True)
689690

690691

692+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "policy: can't withdraw to non-wallet address")
691693
def test_sign_and_send_psbt(node_factory, bitcoind, chainparams):
692694
"""
693695
Tests for the sign + send psbt RPCs
@@ -886,6 +888,7 @@ def test_sign_and_send_psbt(node_factory, bitcoind, chainparams):
886888
check_coin_moves(l1, 'wallet', wallet_coin_mvts, chainparams)
887889

888890

891+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "policy: can't withdraw to non-wallet address")
889892
def test_txsend(node_factory, bitcoind, chainparams):
890893
amount = 1000000
891894
l1 = node_factory.get_node(random_hsm=True)
@@ -1010,6 +1013,7 @@ def write_all(fd, bytestr):
10101013

10111014

10121015
@unittest.skipIf(VALGRIND, "It does not play well with prompt and key derivation.")
1016+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "remote_hsmd doesn't support hsm_secret file")
10131017
def test_hsm_secret_encryption(node_factory):
10141018
l1 = node_factory.get_node(may_fail=True) # May fail when started without key
10151019
password = "reckful&é🍕\n"
@@ -1073,6 +1077,7 @@ def __init__(self, *args):
10731077

10741078

10751079
@unittest.skipIf(VALGRIND, "It does not play well with prompt and key derivation.")
1080+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "remote_hsmd doesn't support hsm_secret file")
10761081
def test_hsmtool_secret_decryption(node_factory):
10771082
l1 = node_factory.get_node()
10781083
password = "reckless123#{ù}\n"
@@ -1224,6 +1229,7 @@ def test_hsmtool_dump_descriptors(node_factory, bitcoind):
12241229

12251230

12261231
@unittest.skipIf(VALGRIND, "It does not play well with prompt and key derivation.")
1232+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "remote_hsmd doesn't support generatehsm")
12271233
def test_hsmtool_generatehsm(node_factory):
12281234
l1 = node_factory.get_node()
12291235
l1.stop()
@@ -1325,6 +1331,7 @@ def test_withdraw_nlocktime_fuzz(node_factory, bitcoind):
13251331
raise Exception("No transaction with fuzzed nLockTime !")
13261332

13271333

1334+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "policy: can't withdraw to non-wallet address")
13281335
def test_multiwithdraw_simple(node_factory, bitcoind, chainparams):
13291336
"""
13301337
Test simple multiwithdraw usage.
@@ -1421,6 +1428,7 @@ def test_repro_4258(node_factory, bitcoind):
14211428

14221429

14231430
@unittest.skipIf(TEST_NETWORK == 'liquid-regtest', "Uses regtest addresses")
1431+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "policy: can't withdraw to non-wallet address")
14241432
def test_withdraw_bech32m(node_factory, bitcoind):
14251433
l1 = node_factory.get_node()
14261434
l1.fundwallet(10000000)

0 commit comments

Comments
 (0)