tests: Add explicit preapprove{invoice,keysend} calls before sendpay

Author: ksedgwic

tests/test_closing.py

@@ -3773,6 +3773,7 @@ def test_closing_anchorspend_htlc_tx_rbf(node_factory, bitcoind):
         'delay': 12,
         'channel': first_scid(l1, l2)
     }
+    l1.rpc.preapprovekeysend(routestep['id'], rhash, routestep['amount_msat'])
     l1.rpc.sendpay([routestep], rhash, payment_secret=inv['payment_secret'])
     l2.daemon.wait_for_log('dev_disconnect')
     l2.stop()
@@ -3841,6 +3842,7 @@ def test_htlc_no_force_close(node_factory, bitcoind, anchors):
               'id': l3.info['id'],
               'delay': 10,
               'channel': first_scid(l2, l3)}]
+    l1.rpc.preapproveinvoice(bolt11=inv['bolt11']) # let the signer know this payment is coming
     l1.rpc.sendpay(route, inv['payment_hash'],
                    payment_secret=inv['payment_secret'])
     l3.daemon.wait_for_log('dev_disconnect')

tests/test_renepay.py

@@ -36,6 +36,8 @@ def test_mpp(node_factory):
 
     send_amount = Millisatoshi('1200000sat')
     inv = l6.rpc.invoice(send_amount, 'test_renepay', 'description')['bolt11']
+    # FIXME - This shouldn't be necessary, renepay should automatically generate ... vls-hsmd:#6
+    l1.rpc.preapproveinvoice(bolt11=inv) # let the signer know this payment is coming
     details = l1.rpc.call('renepay', {'invstring': inv})
     assert details['status'] == 'complete'
     assert details['amount_msat'] == send_amount