Removed all private keys/secrets from remote_hsmd.

Author: ksedgwic

contrib/remote_hsmd/NOTES.md

@@ -86,16 +86,13 @@ Some popular tests:
     export THETEST=tests/test_connection.py::test_fee_limits
     export THETEST=tests/test_closing.py::test_option_upfront_shutdown_script
 
-
 rust-lightning-signer
 ----------------------------------------------------------------
 
     cargo run --bin server |& tee log3
 
 
 Signing Formats
-----------------------------------------------------------------
-
 ```
 rust-lightning  c-lightning     rust-lightning-signer
 p2pkh                           P2PKH
@@ -107,6 +104,11 @@ p2shwsh
 ```
 
 
+Failing tests after removing seed from hsmd:
 ```
-
+    export THETEST=tests/test_misc.py::test_blockchaintrack
+    export THETEST=tests/test_misc.py::test_new_node_is_mainnet
+    export THETEST=tests/test_misc.py::test_getsharedsecret
+    export THETEST=tests/test_wallet.py::test_hsm_secret_encryption
+    export THETEST=tests/test_wallet.py::test_hsmtool_secret_decryption
 ```

contrib/remote_hsmd/dump.cc

@@ -12,6 +12,7 @@ extern "C" {
 #include <common/utils.h>
 #include <common/utxo.h>
 #include <secp256k1_recovery.h>
+#include <wally_bip32.h>
 }
 
 #include "contrib/remote_hsmd/dump.h"
@@ -75,6 +76,16 @@ string dump_pubkey(const struct pubkey *kp)
 	return dump_hex(kp->pubkey.data, sizeof(kp->pubkey.data));
 }
 
+string dump_ext_pubkey(const struct ext_key *xp)
+{
+	char *out;
+	int rv = bip32_key_to_base58(xp, BIP32_FLAG_KEY_PUBLIC, &out);
+	assert(rv == WALLY_OK);
+	string retval(out);
+	wally_free_string(out);
+	return retval;
+}
+
 string dump_witnesses(const u8 ***wp)
 {
 	ostringstream ostrm;

contrib/remote_hsmd/dump.h

@@ -9,6 +9,7 @@ std::string dump_secp256k1_ecdsa_recoverable_signature(const secp256k1_ecdsa_rec
 std::string dump_secret(const struct secret *sp);
 std::string dump_node_id(const struct node_id *pp);
 std::string dump_pubkey(const struct pubkey *kp);
+std::string dump_ext_pubkey(const struct ext_key *xp);
 std::string dump_witnesses(const u8 ***wp);
 std::string dump_unilateral_close_info(const struct unilateral_close_info *ip);
 std::string dump_utxo(const struct utxo *in);